You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/17 10:15:50 UTC

[GitHub] [airflow] ashb commented on pull request #17648: Speed up tests that use BackfillJob

ashb commented on pull request #17648:
URL: https://github.com/apache/airflow/pull/17648#issuecomment-900171378


   > I wonder if we should just make `heartbeat` read the configuration directly instead of using `only_if_necessary`. That’s make it easier to further customise the behaviour for unit tests if we need to.
   
   `heartbeat()` is in BaseJob, and different jobs want different behavoiur here, so the "best" I think we could do is to provide override heartbeat in BackfillJob. But then we'd have to call `conf.getboolean` each time (or cache it -- it's a suprisingly slow operation)
   
   So I'm not sure it really buys is that much.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org