[GitHub] maskit commented on issue #671: Should authParamsString for Authentication support another format ?

[gi...@git.apache.org]

maskit commented on issue #671: Should authParamsString for Authentication support another format ?
URL: https://github.com/apache/incubator-pulsar/issues/671#issuecomment-322178751
 
 
   We can manage the compatibility if we provided an extra interface below.
   
   ```java
   /**
    * Plugins which use ":" and/or "," in a configuration parameter value need to implement this interface.
    * This interface will be integrated into Authentication interface and be required for all plugins on version x.y.
    */
   public interface EncodedAuthenticationParameterSupport {
       void configure(String encodedAuthParamString);
   }
   ```
   
   URL encoding is just a hack for the compatibility. We can use any encode once we added new interface. So, I think the step 1 is not mandatory. Please keep in mind that the configuration value will be written by humans. Support for double-quotation is much easier to use than URL encoding.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services