You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "marcingrzejszczak (via GitHub)" <gi...@apache.org> on 2023/01/26 13:06:09 UTC
[GitHub] [skywalking-java] marcingrzejszczak opened a new pull request, #443: Uncommented Mircometer Observation CI test
marcingrzejszczak opened a new pull request, #443:
URL: https://github.com/apache/skywalking-java/pull/443
<!--
⚠️ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
<!-- ==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👇 ====
### Fix <bug description or the bug issue number or bug issue link>
- [ ] Add a unit test to verify that the fix works.
- [ ] Explain briefly why the bug exists and how to fix it.
==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👆 ==== -->
<!-- ==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👇 ====
### Add an agent plugin to support <framework name>
- [ ] Add a test case for the new plugin, refer to [the doc](https://github.com/apache/skywalking-java/blob/main/docs/en/setup/service-agent/java-agent/Plugin-test.md)
- [ ] Add a component id in [the component-libraries.yml](https://github.com/apache/skywalking/blob/master/oap-server/server-starter/src/main/resources/component-libraries.yml)
- [ ] Add a logo in [the UI repo](https://github.com/apache/skywalking-rocketbot-ui/tree/master/src/views/components/topology/assets)
==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👆 ==== -->
<!-- ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👇 ====
### Improve the performance of <class or module or ...>
- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking-java/blob/main/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
- [ ] The benchmark result.
```text
<Paste the benchmark results here>
```
- [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👆 ==== -->
<!-- ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👇 ====
### <Feature description>
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👆 ==== -->
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
- [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking-java/blob/main/CHANGES.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #443: Uncommented Mircometer Observation CI test
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #443:
URL: https://github.com/apache/skywalking-java/pull/443#issuecomment-1405141591
SkyWalking version dependencies should be set like you did.
There are only two styles of this kind of toolkit testing
1. Your way
2. Copy all toolkit codes to test scenario. (trace toolkit scenario)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #443: Uncommented Mircometer Observation CI test
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #443:
URL: https://github.com/apache/skywalking-java/pull/443#issuecomment-1405023222
The test scenario seems missing some setup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] marcingrzejszczak commented on pull request #443: Uncommented Mircometer Observation CI test
Posted by "marcingrzejszczak (via GitHub)" <gi...@apache.org>.
marcingrzejszczak commented on PR #443:
URL: https://github.com/apache/skywalking-java/pull/443#issuecomment-1405041135
Actually, I've decided to hardcode that value, because otherwise we would need to fix the way the plugins tests are ran. We would need to know upfront what the latest release version is and pass it as a property to the plugin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng merged pull request #443: Uncommented Mircometer Observation CI test
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #443:
URL: https://github.com/apache/skywalking-java/pull/443
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] marcingrzejszczak commented on pull request #443: Uncommented Mircometer Observation CI test
Posted by "marcingrzejszczak (via GitHub)" <gi...@apache.org>.
marcingrzejszczak commented on PR #443:
URL: https://github.com/apache/skywalking-java/pull/443#issuecomment-1405032010
I think that the github actions CI setup is strange. The only place I see that `sw.version` is set is for e2e yaml. e2e is using jdk8 and different setup than the jdk17 based tests for plugins (where you told me to add the resttemplate 6 scenario). So for the latter sw.version is never set...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] marcingrzejszczak commented on pull request #443: Uncommented Mircometer Observation CI test
Posted by "marcingrzejszczak (via GitHub)" <gi...@apache.org>.
marcingrzejszczak commented on PR #443:
URL: https://github.com/apache/skywalking-java/pull/443#issuecomment-1405021844
```
Error: ] Some problems were encountered while processing the POMs:
Error: 'dependencies.dependency.version' for org.apache.skywalking:apm-toolkit-micrometer-1.10:jar is missing. @ line 57, column 22
@
Error: The build could not read 1 project -> [Help 1]
Error:
Error: The project org.apache.skywalking:resttemplate-6.x-scenario:6.5.0 (/home/runner/work/skywalking-java/skywalking-java/test/plugin/scenarios/resttemplate-6.x-scenario/pom.xml) has 1 error
Error: 'dependencies.dependency.version' for org.apache.skywalking:apm-toolkit-micrometer-1.10:jar is missing. @ line 57, column 22
Error:
Error: To see the full stack trace of the errors, re-run Maven with the -e switch.
Error: Re-run Maven using the -X switch to enable full debug logging.
Error:
Error: For more information about the errors and possible solutions, please read the following articles:
Error: [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException
```
@wu-sheng any idea why is the `sw.version` not passed to the build?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] marcingrzejszczak commented on pull request #443: Uncommented Mircometer Observation CI test
Posted by "marcingrzejszczak (via GitHub)" <gi...@apache.org>.
marcingrzejszczak commented on PR #443:
URL: https://github.com/apache/skywalking-java/pull/443#issuecomment-1405061882
Now, with the version fixed the test is passing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org