[GitHub] [superset] zhaoyongjie commented on pull request #16077: fix: ensure that users viewing chart does not automatically save edit data

[GitBox <gi...@apache.org>]

zhaoyongjie commented on pull request #16077:
URL: https://github.com/apache/superset/pull/16077#issuecomment-894133818


   @pkdotson I'm curious as to why a get method would modify the metadata? Should we avoid this operation? I searched all of the codebases seems that only [save_or_overwrite_slice](https://github.com/apache/superset/blob/423ff50768cd1d70fc63a29ac3312916d4aaf65e/superset/views/core.py#L919) can change slice object.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org