You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Pinal Shah <pi...@freestoneinfotech.com> on 2020/02/21 12:20:33 UTC
Review Request 72156: ATLAS-3618 Entities with no guid appears in
search result
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72156/
-----------------------------------------------------------
Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
Bugs: ATLAS-3618
https://issues.apache.org/jira/browse/ATLAS-3618
Repository: atlas
Description
-------
1) Entities of struct types appears when ALL_ENTITY_TYPES is selected
2) Entities of internal types like AtlasGlossary etc appears when ALL_ENTITY_TYPES is selected
Diffs
-----
intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 2824feb16
repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java b5606d046
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasGraphUtilsV2.java bf13338b6
Diff: https://reviews.apache.org/r/72156/diff/1/
Testing
-------
1) typeName: ALL_ENTITY_TYPES returns all entities with no struct types(whoes guid isnotnull) and no internal types(whoes supertype is not _internal)
2) typeName: ALL_ENTITY_TYPES, filter: guid isnull, returns no result
3) typeName: ALL_ENTITY_TYPES, filter: typeName begins_with Atlas
Thanks,
Pinal Shah
Re: Review Request 72156: ATLAS-3618 Entities with no guid appears in
search result
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72156/#review219628
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java
Line 296 (original), 298 (patched)
<https://reviews.apache.org/r/72156/#comment307840>
Consider replacing the changes in #298 to #324 with setting up 'typeNamePredicate' in #101 to an in-memory filter that checks if the given vertex is an entity vertext or not.
typeNamePredicate = SearchPredicateUtil.generateIsEntityVertexPredicate(context.getTypeRegistry());
Similar one might be needed to check for classifications as well, to handle ALL_CLASSIFICATIONS filter. Please review and update.
class SearchPredicateUtil {
public static Predicate generateIsEntityVertexPredicate(AtlasTypeRegistry typeRegistry) {
return new IsEntityVertexPredicate(typeRegistry)
}
static class IsEntityVertexPredicate extends Predicate {
final AtlasTypeRegistry typeRegistry;
public IsEntityVertexPredicate(AtlasTypeRegistry typeRegistry) {
this.typeRegistry = typeRegistry;
}
@Override
public boolean evaluate(final Object object) {
final boolean ret;
AtlasVertex vertex = (object instanceof AtlasVertex) ? (AtlasVertex)object : null;
if (vertex != null) {
String typeName = AtlasGraphUtilsV2.getTypeName(vertex);
AtlasEntityType entityType = typeRegistry.getEntityType(typeName);
ret = entityType != null;
} else {
ret = false;
}
}
}
repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java
Lines 333 (patched)
<https://reviews.apache.org/r/72156/#comment307839>
'isLastResultPage' should be set based on # of vertices in entityVertices before in-memory filters are applied in #327, #330 and #309/#318. Consider the case where all entries in entityVertices are removed by in-memory filter but the graph-db has more vertices for the search critieria.
- Madhan Neethiraj
On Feb. 21, 2020, 12:23 p.m., Pinal Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72156/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2020, 12:23 p.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3618
> https://issues.apache.org/jira/browse/ATLAS-3618
>
>
> Repository: atlas
>
>
> Description
> -------
>
> 1) Entities of struct types appears when ALL_ENTITY_TYPES is selected
> 2) Entities of internal types like AtlasGlossary etc appears when ALL_ENTITY_TYPES is selected
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 2824feb16
> repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java b5606d046
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasGraphUtilsV2.java bf13338b6
>
>
> Diff: https://reviews.apache.org/r/72156/diff/1/
>
>
> Testing
> -------
>
> 1) typeName: ALL_ENTITY_TYPES returns all entities with no struct types(whoes guid isnotnull) and no internal types(whoes supertype is not _internal)
> 2) typeName: ALL_ENTITY_TYPES, filter: guid isnull, returns no result
> 3) typeName: ALL_ENTITY_TYPES, filter: typeName begins_with Atlas, returns no result
>
>
> Thanks,
>
> Pinal Shah
>
>
Re: Review Request 72156: ATLAS-3618 Entities with no guid appears in
search result
Posted by Pinal Shah <pi...@freestoneinfotech.com>.
> On March 4, 2020, 7:29 a.m., Madhan Neethiraj wrote:
> > repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java
> > Lines 286 (patched)
> > <https://reviews.apache.org/r/72156/diff/2/?file=2212025#file2212025line286>
> >
> > typeNamePredicate can be null here (see #159 above); please review if #286 should be surrounded with:
> > if (typeNamePredicate != null)
Thanks Madhan will surely add it
- Pinal
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72156/#review219751
-----------------------------------------------------------
On Feb. 25, 2020, 7:11 a.m., Pinal Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72156/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2020, 7:11 a.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3618
> https://issues.apache.org/jira/browse/ATLAS-3618
>
>
> Repository: atlas
>
>
> Description
> -------
>
> 1) Entities of struct types appears when ALL_ENTITY_TYPES is selected
> 2) Entities of internal types like AtlasGlossary etc appears when ALL_ENTITY_TYPES is selected
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java c0a5a46dd
> repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java b5606d046
> repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java bb1e9f633
>
>
> Diff: https://reviews.apache.org/r/72156/diff/2/
>
>
> Testing
> -------
>
> 1) typeName: ALL_ENTITY_TYPES returns all entities with no struct types(whoes guid isnotnull) and no internal types(whoes supertype is not _internal)
> 2) typeName: ALL_ENTITY_TYPES, filter: guid isnull, returns no result
> 3) typeName: ALL_ENTITY_TYPES, filter: typeName begins_with Atlas, returns no result
>
> Usecase:
> -> Added, term1 in Glossary
> -> added classification1 to term1
> 1) In search Panel(showing all entities) -> term1 shouln't appear
> 2) In classification Panel, showing all entities associated to classification1 -> term1 shouldn't appear
>
>
> Thanks,
>
> Pinal Shah
>
>
Re: Review Request 72156: ATLAS-3618 Entities with no guid appears in
search result
Posted by Pinal Shah <pi...@freestoneinfotech.com>.
> On March 4, 2020, 7:29 a.m., Madhan Neethiraj wrote:
> > repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java
> > Lines 169 (patched)
> > <https://reviews.apache.org/r/72156/diff/2/?file=2212026#file2212026line171>
> >
> > Wouldn't this overwrite earlier assignment to inMemoryPredicate - line #121, #123? Please review and update.
Thanks Madhan, for reviewing the patch.
Yes, it will overwrite.
When it is GraphQuery, query itself includes type filter(except incase of _ALL_ENTITY_TYPES) and attribute filters(except incase when operator is NEQ in pipeSeperatedSystemAttributes)
So I think, inMemoryPredicate should only be typeNamePredicate when isEntityRootType
- Pinal
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72156/#review219751
-----------------------------------------------------------
On Feb. 25, 2020, 7:11 a.m., Pinal Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72156/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2020, 7:11 a.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3618
> https://issues.apache.org/jira/browse/ATLAS-3618
>
>
> Repository: atlas
>
>
> Description
> -------
>
> 1) Entities of struct types appears when ALL_ENTITY_TYPES is selected
> 2) Entities of internal types like AtlasGlossary etc appears when ALL_ENTITY_TYPES is selected
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java c0a5a46dd
> repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java b5606d046
> repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java bb1e9f633
>
>
> Diff: https://reviews.apache.org/r/72156/diff/2/
>
>
> Testing
> -------
>
> 1) typeName: ALL_ENTITY_TYPES returns all entities with no struct types(whoes guid isnotnull) and no internal types(whoes supertype is not _internal)
> 2) typeName: ALL_ENTITY_TYPES, filter: guid isnull, returns no result
> 3) typeName: ALL_ENTITY_TYPES, filter: typeName begins_with Atlas, returns no result
>
> Usecase:
> -> Added, term1 in Glossary
> -> added classification1 to term1
> 1) In search Panel(showing all entities) -> term1 shouln't appear
> 2) In classification Panel, showing all entities associated to classification1 -> term1 shouldn't appear
>
>
> Thanks,
>
> Pinal Shah
>
>
Re: Review Request 72156: ATLAS-3618 Entities with no guid appears in
search result
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72156/#review219751
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java
Lines 286 (patched)
<https://reviews.apache.org/r/72156/#comment307950>
typeNamePredicate can be null here (see #159 above); please review if #286 should be surrounded with:
if (typeNamePredicate != null)
repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java
Lines 169 (patched)
<https://reviews.apache.org/r/72156/#comment307951>
Wouldn't this overwrite earlier assignment to inMemoryPredicate - line #121, #123? Please review and update.
- Madhan Neethiraj
On Feb. 25, 2020, 7:11 a.m., Pinal Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72156/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2020, 7:11 a.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3618
> https://issues.apache.org/jira/browse/ATLAS-3618
>
>
> Repository: atlas
>
>
> Description
> -------
>
> 1) Entities of struct types appears when ALL_ENTITY_TYPES is selected
> 2) Entities of internal types like AtlasGlossary etc appears when ALL_ENTITY_TYPES is selected
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java c0a5a46dd
> repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java b5606d046
> repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java bb1e9f633
>
>
> Diff: https://reviews.apache.org/r/72156/diff/2/
>
>
> Testing
> -------
>
> 1) typeName: ALL_ENTITY_TYPES returns all entities with no struct types(whoes guid isnotnull) and no internal types(whoes supertype is not _internal)
> 2) typeName: ALL_ENTITY_TYPES, filter: guid isnull, returns no result
> 3) typeName: ALL_ENTITY_TYPES, filter: typeName begins_with Atlas, returns no result
>
> Usecase:
> -> Added, term1 in Glossary
> -> added classification1 to term1
> 1) In search Panel(showing all entities) -> term1 shouln't appear
> 2) In classification Panel, showing all entities associated to classification1 -> term1 shouldn't appear
>
>
> Thanks,
>
> Pinal Shah
>
>
Re: Review Request 72156: ATLAS-3618 Entities with no guid appears in
search result
Posted by Pinal Shah <pi...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72156/#review219750
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java
Line 99 (original), 99 (patched)
<https://reviews.apache.org/r/72156/#comment307949>
Handled Non entities (without guid) and internal entities
- Pinal Shah
On Feb. 25, 2020, 7:11 a.m., Pinal Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72156/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2020, 7:11 a.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3618
> https://issues.apache.org/jira/browse/ATLAS-3618
>
>
> Repository: atlas
>
>
> Description
> -------
>
> 1) Entities of struct types appears when ALL_ENTITY_TYPES is selected
> 2) Entities of internal types like AtlasGlossary etc appears when ALL_ENTITY_TYPES is selected
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java c0a5a46dd
> repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java b5606d046
> repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java bb1e9f633
>
>
> Diff: https://reviews.apache.org/r/72156/diff/2/
>
>
> Testing
> -------
>
> 1) typeName: ALL_ENTITY_TYPES returns all entities with no struct types(whoes guid isnotnull) and no internal types(whoes supertype is not _internal)
> 2) typeName: ALL_ENTITY_TYPES, filter: guid isnull, returns no result
> 3) typeName: ALL_ENTITY_TYPES, filter: typeName begins_with Atlas, returns no result
>
> Usecase:
> -> Added, term1 in Glossary
> -> added classification1 to term1
> 1) In search Panel(showing all entities) -> term1 shouln't appear
> 2) In classification Panel, showing all entities associated to classification1 -> term1 shouldn't appear
>
>
> Thanks,
>
> Pinal Shah
>
>
Re: Review Request 72156: ATLAS-3618 Entities with no guid appears in
search result
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72156/#review219807
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java
Lines 73 (patched)
<https://reviews.apache.org/r/72156/#comment308038>
typeNamePredicate => isEntityPredicate
- Madhan Neethiraj
On March 6, 2020, 5:37 a.m., Pinal Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72156/
> -----------------------------------------------------------
>
> (Updated March 6, 2020, 5:37 a.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3618
> https://issues.apache.org/jira/browse/ATLAS-3618
>
>
> Repository: atlas
>
>
> Description
> -------
>
> 1) Entities of struct types appears when ALL_ENTITY_TYPES is selected
> 2) Entities of internal types like AtlasGlossary etc appears when ALL_ENTITY_TYPES is selected
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java 6ab0afbf9
> repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java ebd5992cd
> repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java b5ede0b82
>
>
> Diff: https://reviews.apache.org/r/72156/diff/4/
>
>
> Testing
> -------
>
> 1) typeName: ALL_ENTITY_TYPES returns all entities with no struct types(whoes guid isnotnull) and no internal types(whoes supertype is not _internal)
> 2) typeName: ALL_ENTITY_TYPES, filter: guid isnull, returns no result
> 3) typeName: ALL_ENTITY_TYPES, filter: typeName begins_with Atlas, returns no result
>
> Usecase:
> -> Added, term1 in Glossary
> -> added classification1 to term1
> 1) In search Panel(showing all entities) -> term1 shouln't appear
> 2) In classification Panel, showing all entities associated to classification1 -> term1 shouldn't appear
>
>
> Thanks,
>
> Pinal Shah
>
>
Re: Review Request 72156: ATLAS-3618 Entities with no guid appears in
search result
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72156/#review219817
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On March 6, 2020, 6:26 a.m., Pinal Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72156/
> -----------------------------------------------------------
>
> (Updated March 6, 2020, 6:26 a.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3618
> https://issues.apache.org/jira/browse/ATLAS-3618
>
>
> Repository: atlas
>
>
> Description
> -------
>
> 1) Entities of struct types appears when ALL_ENTITY_TYPES is selected
> 2) Entities of internal types like AtlasGlossary etc appears when ALL_ENTITY_TYPES is selected
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java 6ab0afbf9
> repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java ebd5992cd
> repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java b5ede0b82
>
>
> Diff: https://reviews.apache.org/r/72156/diff/5/
>
>
> Testing
> -------
>
> 1) typeName: ALL_ENTITY_TYPES returns all entities with no struct types(whoes guid isnotnull) and no internal types(whoes supertype is not _internal)
> 2) typeName: ALL_ENTITY_TYPES, filter: guid isnull, returns no result
> 3) typeName: ALL_ENTITY_TYPES, filter: typeName begins_with Atlas, returns no result
>
> Usecase:
> -> Added, term1 in Glossary
> -> added classification1 to term1
> 1) In search Panel(showing all entities) -> term1 shouln't appear
> 2) In classification Panel, showing all entities associated to classification1 -> term1 shouldn't appear
>
>
> Thanks,
>
> Pinal Shah
>
>
Re: Review Request 72156: ATLAS-3618 Entities with no guid appears in
search result
Posted by Pinal Shah <pi...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72156/
-----------------------------------------------------------
(Updated March 6, 2020, 6:26 a.m.)
Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
Changes
-------
Changed typeNamePredicate to EntityPredicate
Bugs: ATLAS-3618
https://issues.apache.org/jira/browse/ATLAS-3618
Repository: atlas
Description
-------
1) Entities of struct types appears when ALL_ENTITY_TYPES is selected
2) Entities of internal types like AtlasGlossary etc appears when ALL_ENTITY_TYPES is selected
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java 6ab0afbf9
repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java ebd5992cd
repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java b5ede0b82
Diff: https://reviews.apache.org/r/72156/diff/5/
Changes: https://reviews.apache.org/r/72156/diff/4-5/
Testing
-------
1) typeName: ALL_ENTITY_TYPES returns all entities with no struct types(whoes guid isnotnull) and no internal types(whoes supertype is not _internal)
2) typeName: ALL_ENTITY_TYPES, filter: guid isnull, returns no result
3) typeName: ALL_ENTITY_TYPES, filter: typeName begins_with Atlas, returns no result
Usecase:
-> Added, term1 in Glossary
-> added classification1 to term1
1) In search Panel(showing all entities) -> term1 shouln't appear
2) In classification Panel, showing all entities associated to classification1 -> term1 shouldn't appear
Thanks,
Pinal Shah
Re: Review Request 72156: ATLAS-3618 Entities with no guid appears in
search result
Posted by Pinal Shah <pi...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72156/
-----------------------------------------------------------
(Updated March 6, 2020, 5:37 a.m.)
Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
Changes
-------
Rebase patch
Bugs: ATLAS-3618
https://issues.apache.org/jira/browse/ATLAS-3618
Repository: atlas
Description
-------
1) Entities of struct types appears when ALL_ENTITY_TYPES is selected
2) Entities of internal types like AtlasGlossary etc appears when ALL_ENTITY_TYPES is selected
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java 6ab0afbf9
repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java ebd5992cd
repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java b5ede0b82
Diff: https://reviews.apache.org/r/72156/diff/4/
Changes: https://reviews.apache.org/r/72156/diff/3-4/
Testing
-------
1) typeName: ALL_ENTITY_TYPES returns all entities with no struct types(whoes guid isnotnull) and no internal types(whoes supertype is not _internal)
2) typeName: ALL_ENTITY_TYPES, filter: guid isnull, returns no result
3) typeName: ALL_ENTITY_TYPES, filter: typeName begins_with Atlas, returns no result
Usecase:
-> Added, term1 in Glossary
-> added classification1 to term1
1) In search Panel(showing all entities) -> term1 shouln't appear
2) In classification Panel, showing all entities associated to classification1 -> term1 shouldn't appear
Thanks,
Pinal Shah
Re: Review Request 72156: ATLAS-3618 Entities with no guid appears in
search result
Posted by Pinal Shah <pi...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72156/
-----------------------------------------------------------
(Updated March 5, 2020, 11:35 a.m.)
Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
Changes
-------
addressed typeNamePredicate null check
Bugs: ATLAS-3618
https://issues.apache.org/jira/browse/ATLAS-3618
Repository: atlas
Description
-------
1) Entities of struct types appears when ALL_ENTITY_TYPES is selected
2) Entities of internal types like AtlasGlossary etc appears when ALL_ENTITY_TYPES is selected
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java 6ab0afbf9
repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java 8f531876b
repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java bb1e9f633
Diff: https://reviews.apache.org/r/72156/diff/3/
Changes: https://reviews.apache.org/r/72156/diff/2-3/
Testing
-------
1) typeName: ALL_ENTITY_TYPES returns all entities with no struct types(whoes guid isnotnull) and no internal types(whoes supertype is not _internal)
2) typeName: ALL_ENTITY_TYPES, filter: guid isnull, returns no result
3) typeName: ALL_ENTITY_TYPES, filter: typeName begins_with Atlas, returns no result
Usecase:
-> Added, term1 in Glossary
-> added classification1 to term1
1) In search Panel(showing all entities) -> term1 shouln't appear
2) In classification Panel, showing all entities associated to classification1 -> term1 shouldn't appear
Thanks,
Pinal Shah
Re: Review Request 72156: ATLAS-3618 Entities with no guid appears in
search result
Posted by Pinal Shah <pi...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72156/
-----------------------------------------------------------
(Updated Feb. 25, 2020, 7:11 a.m.)
Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
Changes
-------
added method to check Nonentity vertices
Bugs: ATLAS-3618
https://issues.apache.org/jira/browse/ATLAS-3618
Repository: atlas
Description
-------
1) Entities of struct types appears when ALL_ENTITY_TYPES is selected
2) Entities of internal types like AtlasGlossary etc appears when ALL_ENTITY_TYPES is selected
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java c0a5a46dd
repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java b5606d046
repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java bb1e9f633
Diff: https://reviews.apache.org/r/72156/diff/2/
Changes: https://reviews.apache.org/r/72156/diff/1-2/
Testing (updated)
-------
1) typeName: ALL_ENTITY_TYPES returns all entities with no struct types(whoes guid isnotnull) and no internal types(whoes supertype is not _internal)
2) typeName: ALL_ENTITY_TYPES, filter: guid isnull, returns no result
3) typeName: ALL_ENTITY_TYPES, filter: typeName begins_with Atlas, returns no result
Usecase:
-> Added, term1 in Glossary
-> added classification1 to term1
1) In search Panel(showing all entities) -> term1 shouln't appear
2) In classification Panel, showing all entities associated to classification1 -> term1 shouldn't appear
Thanks,
Pinal Shah
Re: Review Request 72156: ATLAS-3618 Entities with no guid appears in
search result
Posted by Pinal Shah <pi...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72156/
-----------------------------------------------------------
(Updated Feb. 21, 2020, 12:23 p.m.)
Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
Bugs: ATLAS-3618
https://issues.apache.org/jira/browse/ATLAS-3618
Repository: atlas
Description
-------
1) Entities of struct types appears when ALL_ENTITY_TYPES is selected
2) Entities of internal types like AtlasGlossary etc appears when ALL_ENTITY_TYPES is selected
Diffs
-----
intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 2824feb16
repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java b5606d046
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasGraphUtilsV2.java bf13338b6
Diff: https://reviews.apache.org/r/72156/diff/1/
Testing (updated)
-------
1) typeName: ALL_ENTITY_TYPES returns all entities with no struct types(whoes guid isnotnull) and no internal types(whoes supertype is not _internal)
2) typeName: ALL_ENTITY_TYPES, filter: guid isnull, returns no result
3) typeName: ALL_ENTITY_TYPES, filter: typeName begins_with Atlas, returns no result
Thanks,
Pinal Shah