You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2020/06/22 16:03:13 UTC

[GitHub] [servicecomb-pack] coolbeevip opened a new pull request #667: [SCB-2004] Fix compensation retry failure during business service startup

coolbeevip opened a new pull request #667:
URL: https://github.com/apache/servicecomb-pack/pull/667


   * Use message-driven compensation retry instead of recursive compensation
   * In Omega, if CallbackContenxt does not contain callbackMethod, send TxCompensateAckFailedEvent to Alpha instead of throwing NPE
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-pack] coveralls commented on pull request #667: [SCB-2004] Fix compensation retry failure during business service startup

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #667:
URL: https://github.com/apache/servicecomb-pack/pull/667#issuecomment-647654794


   
   [![Coverage Status](https://coveralls.io/builds/31608817/badge)](https://coveralls.io/builds/31608817)
   
   Coverage increased (+0.03%) to 80.698% when pulling **7b352ba06f5fb3e9e5fec25de34dcbcb2bb9bab1 on coolbeevip:SCB-2004** into **b476b8b7b98e3feafacfb26beafd78523176b83a on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-pack] coolbeevip commented on a change in pull request #667: [SCB-2004] Fix compensation retry failure during business service startup

Posted by GitBox <gi...@apache.org>.
coolbeevip commented on a change in pull request #667:
URL: https://github.com/apache/servicecomb-pack/pull/667#discussion_r444440343



##########
File path: alpha/alpha-core/src/main/java/org/apache/servicecomb/pack/alpha/core/fsm/event/internal/ComponsitedCheckEvent.java
##########
@@ -17,10 +17,17 @@
 
 package org.apache.servicecomb.pack.alpha.core.fsm.event.internal;
 
+import org.apache.servicecomb.pack.alpha.core.fsm.TxState;
 import org.apache.servicecomb.pack.alpha.core.fsm.event.base.TxEvent;
 
 public class ComponsitedCheckEvent extends TxEvent {
 
+  private TxState preState;
+
+  public TxState getPreState() {

Review comment:
       I renamed that `preState` to `preComponsitedState`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-pack] coveralls edited a comment on pull request #667: [SCB-2004] Fix compensation retry failure during business service startup

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #667:
URL: https://github.com/apache/servicecomb-pack/pull/667#issuecomment-647654794


   
   [![Coverage Status](https://coveralls.io/builds/31621616/badge)](https://coveralls.io/builds/31621616)
   
   Coverage increased (+0.03%) to 80.698% when pulling **992fc6adab7fa6cfda65da10c0f6145f40871525 on coolbeevip:SCB-2004** into **b476b8b7b98e3feafacfb26beafd78523176b83a on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-pack] WillemJiang merged pull request #667: [SCB-2004] Fix compensation retry failure during business service startup

Posted by GitBox <gi...@apache.org>.
WillemJiang merged pull request #667:
URL: https://github.com/apache/servicecomb-pack/pull/667


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-pack] WillemJiang commented on a change in pull request #667: [SCB-2004] Fix compensation retry failure during business service startup

Posted by GitBox <gi...@apache.org>.
WillemJiang commented on a change in pull request #667:
URL: https://github.com/apache/servicecomb-pack/pull/667#discussion_r444039232



##########
File path: alpha/alpha-core/src/main/java/org/apache/servicecomb/pack/alpha/core/fsm/event/internal/ComponsitedCheckEvent.java
##########
@@ -17,10 +17,17 @@
 
 package org.apache.servicecomb.pack.alpha.core.fsm.event.internal;
 
+import org.apache.servicecomb.pack.alpha.core.fsm.TxState;
 import org.apache.servicecomb.pack.alpha.core.fsm.event.base.TxEvent;
 
 public class ComponsitedCheckEvent extends TxEvent {
 
+  private TxState preState;
+
+  public TxState getPreState() {

Review comment:
       This states is used store the state of componsited command execution state. 
   It's better to update the name to reflect the meaning of this variable.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-pack] coveralls edited a comment on pull request #667: [SCB-2004] Fix compensation retry failure during business service startup

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #667:
URL: https://github.com/apache/servicecomb-pack/pull/667#issuecomment-647654794


   
   [![Coverage Status](https://coveralls.io/builds/31640580/badge)](https://coveralls.io/builds/31640580)
   
   Coverage increased (+0.03%) to 80.698% when pulling **150e0d1adf4c95e6aa475d03b655e4f4a9e5eb7c on coolbeevip:SCB-2004** into **b476b8b7b98e3feafacfb26beafd78523176b83a on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org