You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/13 13:59:49 UTC
[GitHub] [doris] yixiutt opened a new pull request, #12995: [feature-wip](vertical-compaction) support dup key&uniq key vertical compaction
yixiutt opened a new pull request, #12995:
URL: https://github.com/apache/doris/pull/12995
# Proposed changes
Issue Number: #12966
This pr is not finished with unique-key and agg-key not implement。Just review the overall design。
I'll continue to update this pr.
09.27 ---- basic functions and support duplicate key compaction
09.29 ---- support unique key compaction
10.08 ---- support delele handler and add unit test
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] BiteTheDDDDt commented on a diff in pull request #12995: [feature-wip](vertical-compaction) support dup-key vertical compaction
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt commented on code in PR #12995:
URL: https://github.com/apache/doris/pull/12995#discussion_r982137902
##########
be/src/common/config.h:
##########
@@ -250,12 +250,18 @@ CONF_Bool(enable_storage_vectorization, "true");
CONF_Bool(enable_low_cardinality_optimize, "true");
// be policy
+// whether check compaction checksum
+CONF_mBool(enable_compaction_checksum, "false");
Review Comment:
better split enable_compaction_checksum to a single pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Gabriel39 commented on a diff in pull request #12995: [feature-wip](vertical-compaction) support dup-key vertical compaction
Posted by GitBox <gi...@apache.org>.
Gabriel39 commented on code in PR #12995:
URL: https://github.com/apache/doris/pull/12995#discussion_r980662717
##########
be/src/vec/CMakeLists.txt:
##########
@@ -209,6 +209,8 @@ set(VEC_FILES
olap/vcollect_iterator.cpp
olap/block_reader.cpp
olap/olap_data_convertor.cpp
+ olap/vertical_merge_iterator.cpp
Review Comment:
format it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yixiutt closed pull request #12995: [feature-wip](vertical-compaction) support dup key&uniq key vertical compaction
Posted by GitBox <gi...@apache.org>.
yixiutt closed pull request #12995: [feature-wip](vertical-compaction) support dup key&uniq key vertical compaction
URL: https://github.com/apache/doris/pull/12995
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yixiutt closed pull request #12995: [feature-wip](vertical-compaction) support dup key&uniq key vertical compaction
Posted by GitBox <gi...@apache.org>.
yixiutt closed pull request #12995: [feature-wip](vertical-compaction) support dup key&uniq key vertical compaction
URL: https://github.com/apache/doris/pull/12995
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org