You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "shuiqiangchen (via GitHub)" <gi...@apache.org> on 2023/02/09 02:58:17 UTC
[GitHub] [flink] shuiqiangchen opened a new pull request, #21897: [FLINK-30922][table-planner] Apply persisted columns when doing appendPartitionAndNu…
shuiqiangchen opened a new pull request, #21897:
URL: https://github.com/apache/flink/pull/21897
…llsProjects
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Fix the bug that it excludes all metadata and computed columns when doing preValidateRewrite with partial insert.
## Brief change log
- Added util to get persisted schema.
- Apply persisted columns as target row type when doing pre-validate rewrite for partial insert.
## Verifying this change
This change has test cases covered in PartialInsertTest.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] shuiqiangchen commented on pull request #21897: [FLINK-30922][table-planner] Apply persisted columns when doing appendPartitionAndNu…
Posted by "shuiqiangchen (via GitHub)" <gi...@apache.org>.
shuiqiangchen commented on PR #21897:
URL: https://github.com/apache/flink/pull/21897#issuecomment-1426584980
@MartijnVisser Thank you for reminding. It worked after rebasing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] MartijnVisser commented on pull request #21897: [FLINK-30922][table-planner] Apply persisted columns when doing appendPartitionAndNu…
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on PR #21897:
URL: https://github.com/apache/flink/pull/21897#issuecomment-1426325867
@shuiqiangchen You need to rebase your PR on the latest changes in `master`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] lincoln-lil commented on a diff in pull request #21897: [FLINK-30922][table-planner] Apply persisted columns when doing appendPartitionAndNullsProjects
Posted by "lincoln-lil (via GitHub)" <gi...@apache.org>.
lincoln-lil commented on code in PR #21897:
URL: https://github.com/apache/flink/pull/21897#discussion_r1124356820
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/utils/TableSchemaUtils.java:
##########
@@ -68,6 +68,36 @@ public static TableSchema getPhysicalSchema(TableSchema tableSchema) {
return builder.build();
}
+ /**
+ * Return {@link TableSchema} which consists of all persisted columns. That means, the virtual
+ * computed columns and metadata columns are filterd out.
Review Comment:
nit: -> filtered
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/utils/TableSchemaUtils.java:
##########
@@ -68,6 +68,36 @@ public static TableSchema getPhysicalSchema(TableSchema tableSchema) {
return builder.build();
}
+ /**
+ * Return {@link TableSchema} which consists of all persisted columns. That means, the virtual
+ * computed columns and metadata columns are filterd out.
+ *
+ * <p>Readers(or writers) such as {@link TableSource} and {@link TableSink} should use this
+ * persisted schema to generate {@link TableSource#getProducedDataType()} and {@link
Review Comment:
Users should know the difference between this method and `getPhysicalSchema`
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/utils/TableSchemaUtils.java:
##########
@@ -68,6 +68,36 @@ public static TableSchema getPhysicalSchema(TableSchema tableSchema) {
return builder.build();
}
+ /**
+ * Return {@link TableSchema} which consists of all persisted columns. That means, the virtual
+ * computed columns and metadata columns are filterd out.
+ *
+ * <p>Readers(or writers) such as {@link TableSource} and {@link TableSink} should use this
+ * persisted schema to generate {@link TableSource#getProducedDataType()} and {@link
+ * TableSource#getTableSchema()} rather than using the raw TableSchema which may contains
+ * additional columns.
+ */
+ public static TableSchema getPersistedSchema(TableSchema tableSchema) {
Review Comment:
we'd better extract a common method for this and `getPhysicalSchema` since only one condition differs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] shuiqiangchen commented on pull request #21897: [FLINK-30922][table-planner] Apply persisted columns when doing appendPartitionAndNu…
Posted by "shuiqiangchen (via GitHub)" <gi...@apache.org>.
shuiqiangchen commented on PR #21897:
URL: https://github.com/apache/flink/pull/21897#issuecomment-1423763350
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] shuiqiangchen commented on pull request #21897: [FLINK-30922][table-planner] Apply persisted columns when doing appendPartitionAndNullsProjects
Posted by "shuiqiangchen (via GitHub)" <gi...@apache.org>.
shuiqiangchen commented on PR #21897:
URL: https://github.com/apache/flink/pull/21897#issuecomment-1455945219
@lincoln-lil Thank you for your comments. I have added a test case for partialInsert with computed columns and optimized the comments according to your suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] lincoln-lil merged pull request #21897: [FLINK-30922][table-planner] Apply persisted columns when doing appendPartitionAndNullsProjects
Posted by "lincoln-lil (via GitHub)" <gi...@apache.org>.
lincoln-lil merged PR #21897:
URL: https://github.com/apache/flink/pull/21897
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] shuiqiangchen commented on pull request #21897: [FLINK-30922][table-planner] Apply persisted columns when doing appendPartitionAndNu…
Posted by "shuiqiangchen (via GitHub)" <gi...@apache.org>.
shuiqiangchen commented on PR #21897:
URL: https://github.com/apache/flink/pull/21897#issuecomment-1425101680
@PatrickRen could you please help figure out why it didn't trigger the azure run after the `@flinkbot run azure` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] shuiqiangchen commented on pull request #21897: [FLINK-30922][table-planner] Apply persisted columns when doing appendPartitionAndNullsProjects
Posted by "shuiqiangchen (via GitHub)" <gi...@apache.org>.
shuiqiangchen commented on PR #21897:
URL: https://github.com/apache/flink/pull/21897#issuecomment-1456203299
@lincoln-lil Thank you, I will do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #21897: [FLINK-30922][table-planner] Apply persisted columns when doing appendPartitionAndNu…
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #21897:
URL: https://github.com/apache/flink/pull/21897#issuecomment-1423557880
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "996be992c58c60029dccd14a3ae39d361fed4ff9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "996be992c58c60029dccd14a3ae39d361fed4ff9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 996be992c58c60029dccd14a3ae39d361fed4ff9 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] shuiqiangchen commented on pull request #21897: [FLINK-30922][table-planner] Apply persisted columns when doing appendPartitionAndNu…
Posted by "shuiqiangchen (via GitHub)" <gi...@apache.org>.
shuiqiangchen commented on PR #21897:
URL: https://github.com/apache/flink/pull/21897#issuecomment-1423711042
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] lincoln-lil commented on pull request #21897: [FLINK-30922][table-planner] Apply persisted columns when doing appendPartitionAndNullsProjects
Posted by "lincoln-lil (via GitHub)" <gi...@apache.org>.
lincoln-lil commented on PR #21897:
URL: https://github.com/apache/flink/pull/21897#issuecomment-1456196620
@shuiqiangchen could you also create backport pr to release-1.17 branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org