You are viewing a plain text version of this content. The canonical link for it is here.
Posted to scm-dev@maven.apache.org by "John Didion (JIRA)" <ji...@codehaus.org> on 2006/02/23 04:45:35 UTC
[jira] Created: (SCM-165) PerforceChangeLogCommand needs to use the
same clientspec as the update command
PerforceChangeLogCommand needs to use the same clientspec as the update command
-------------------------------------------------------------------------------
Key: SCM-165
URL: http://jira.codehaus.org/browse/SCM-165
Project: Maven SCM
Type: Bug
Components: maven-scm-provider-perforce
Versions: 1.0-beta-3
Reporter: John Didion
Priority: Critical
Attachments: PerforceChangeLogCommand.diff
The PerforceChangeLogCommand as written does not work if the update was done with the client spec generated by the checkout/update command. The attached diff will fix the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (SCM-165) PerforceChangeLogCommand needs to use
the same clientspec as the update command
Posted by "Emmanuel Venisse (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/SCM-165?page=comments#action_59501 ]
Emmanuel Venisse commented on SCM-165:
--------------------------------------
update and changelog commands doesn't run necessarily as part of a single VM invocation.
> PerforceChangeLogCommand needs to use the same clientspec as the update command
> -------------------------------------------------------------------------------
>
> Key: SCM-165
> URL: http://jira.codehaus.org/browse/SCM-165
> Project: Maven SCM
> Type: Bug
> Components: maven-scm-provider-perforce
> Versions: 1.0
> Reporter: John Didion
> Assignee: Mike Perham
> Priority: Critical
> Attachments: PerforceChangeLogCommand.diff, svn.diff
>
>
> The PerforceChangeLogCommand as written does not work if the update was done with the client spec generated by the checkout/update command. The attached diff will fix the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (SCM-165) PerforceChangeLogCommand needs to use
the same clientspec as the update command
Posted by "Mike Perham (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/SCM-165?page=comments#action_59326 ]
Mike Perham commented on SCM-165:
---------------------------------
John, please attach a standard SVN diff. Your diff does not contain the filename headers.
svn diff > patch.diff
> PerforceChangeLogCommand needs to use the same clientspec as the update command
> -------------------------------------------------------------------------------
>
> Key: SCM-165
> URL: http://jira.codehaus.org/browse/SCM-165
> Project: Maven SCM
> Type: Bug
> Components: maven-scm-provider-perforce
> Versions: 1.0-beta-3
> Reporter: John Didion
> Assignee: Mike Perham
> Priority: Critical
> Attachments: PerforceChangeLogCommand.diff
>
>
> The PerforceChangeLogCommand as written does not work if the update was done with the client spec generated by the checkout/update command. The attached diff will fix the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (SCM-165) PerforceChangeLogCommand needs to use
the same clientspec as the update command
Posted by "Emmanuel Venisse (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/SCM-165?page=comments#action_59801 ]
Emmanuel Venisse commented on SCM-165:
--------------------------------------
Mike, we have 2 changelog plugins:
- in maven-scm plugin that can be use for test
- in mojo project, this plugin generate changelog reports and doc are online
> PerforceChangeLogCommand needs to use the same clientspec as the update command
> -------------------------------------------------------------------------------
>
> Key: SCM-165
> URL: http://jira.codehaus.org/browse/SCM-165
> Project: Maven SCM
> Type: Bug
> Components: maven-scm-provider-perforce
> Versions: 1.0
> Reporter: John Didion
> Assignee: Mike Perham
> Priority: Critical
> Attachments: PerforceChangeLogCommand.diff, svn.diff
>
>
> The PerforceChangeLogCommand as written does not work if the update was done with the client spec generated by the checkout/update command. The attached diff will fix the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (SCM-165) PerforceChangeLogCommand needs to use
the same clientspec as the update command
Posted by "Mike Perham (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/SCM-165?page=comments#action_59481 ]
Mike Perham commented on SCM-165:
---------------------------------
This patch fails when running the changelog command in standalone mode. Use the SCM plugin to run a changelog on some directory "mvn scm:changelog -DconnectionUrl=XXX" where XXX is your developerConnection string in the POM and you will find that the command fails due to the clientspec not existing. This is because your patch assumes it is always run after an update.
Nonetheless, I'm inclined to think this is better than before since Continuum is the major user of the changelog command and it wasn't working for Continuum before. I'm assuming that most people don't use the SCM plugin except for testing.
Emmanuel, do you have any opinion here? Would you rather see the changelog command only work as part of an update/checkout or not work with those but work standalone?
> PerforceChangeLogCommand needs to use the same clientspec as the update command
> -------------------------------------------------------------------------------
>
> Key: SCM-165
> URL: http://jira.codehaus.org/browse/SCM-165
> Project: Maven SCM
> Type: Bug
> Components: maven-scm-provider-perforce
> Versions: 1.0
> Reporter: John Didion
> Assignee: Mike Perham
> Priority: Critical
> Attachments: PerforceChangeLogCommand.diff, svn.diff
>
>
> The PerforceChangeLogCommand as written does not work if the update was done with the client spec generated by the checkout/update command. The attached diff will fix the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (SCM-165) PerforceChangeLogCommand needs to use
the same clientspec as the update command
Posted by "Mike Perham (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/SCM-165?page=comments#action_59482 ]
Mike Perham commented on SCM-165:
---------------------------------
Would it be acceptable for me to set the clientspec in use as a system property or static variable and the changelog command would do the following?
if (clientspec preset)
{
use that clientspec
}
else
{
default to no clientspec
}
Can I assume that the update/checkout and changelog commands are run as part of a single VM invocation?
> PerforceChangeLogCommand needs to use the same clientspec as the update command
> -------------------------------------------------------------------------------
>
> Key: SCM-165
> URL: http://jira.codehaus.org/browse/SCM-165
> Project: Maven SCM
> Type: Bug
> Components: maven-scm-provider-perforce
> Versions: 1.0
> Reporter: John Didion
> Assignee: Mike Perham
> Priority: Critical
> Attachments: PerforceChangeLogCommand.diff, svn.diff
>
>
> The PerforceChangeLogCommand as written does not work if the update was done with the client spec generated by the checkout/update command. The attached diff will fix the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (SCM-165) PerforceChangeLogCommand needs to use
the same clientspec as the update command
Posted by "Mike Perham (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/SCM-165?page=all ]
Mike Perham reassigned SCM-165:
-------------------------------
Assign To: Mike Perham
> PerforceChangeLogCommand needs to use the same clientspec as the update command
> -------------------------------------------------------------------------------
>
> Key: SCM-165
> URL: http://jira.codehaus.org/browse/SCM-165
> Project: Maven SCM
> Type: Bug
> Components: maven-scm-provider-perforce
> Versions: 1.0-beta-3
> Reporter: John Didion
> Assignee: Mike Perham
> Priority: Critical
> Attachments: PerforceChangeLogCommand.diff
>
>
> The PerforceChangeLogCommand as written does not work if the update was done with the client spec generated by the checkout/update command. The attached diff will fix the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (SCM-165) PerforceChangeLogCommand needs to use
the same clientspec as the update command
Posted by "Emmanuel Venisse (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/SCM-165?page=comments#action_59500 ]
Emmanuel Venisse commented on SCM-165:
--------------------------------------
changelog command must work in standalone mode (require by changelog mojo and by changelog report mojo) AND as part of update command (require by update mojo and continuum).
> PerforceChangeLogCommand needs to use the same clientspec as the update command
> -------------------------------------------------------------------------------
>
> Key: SCM-165
> URL: http://jira.codehaus.org/browse/SCM-165
> Project: Maven SCM
> Type: Bug
> Components: maven-scm-provider-perforce
> Versions: 1.0
> Reporter: John Didion
> Assignee: Mike Perham
> Priority: Critical
> Attachments: PerforceChangeLogCommand.diff, svn.diff
>
>
> The PerforceChangeLogCommand as written does not work if the update was done with the client spec generated by the checkout/update command. The attached diff will fix the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (SCM-165) PerforceChangeLogCommand needs to use
the same clientspec as the update command
Posted by "Mike Perham (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/SCM-165?page=comments#action_59517 ]
Mike Perham commented on SCM-165:
---------------------------------
I don't see how I can make this work in all cases without forcing the user to provide a parameter or use something like the release.properties file that the release plugin uses. I will brainstorm tonight and come up with the best compromise I can.
> PerforceChangeLogCommand needs to use the same clientspec as the update command
> -------------------------------------------------------------------------------
>
> Key: SCM-165
> URL: http://jira.codehaus.org/browse/SCM-165
> Project: Maven SCM
> Type: Bug
> Components: maven-scm-provider-perforce
> Versions: 1.0
> Reporter: John Didion
> Assignee: Mike Perham
> Priority: Critical
> Attachments: PerforceChangeLogCommand.diff, svn.diff
>
>
> The PerforceChangeLogCommand as written does not work if the update was done with the client spec generated by the checkout/update command. The attached diff will fix the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (SCM-165) PerforceChangeLogCommand needs to use
the same clientspec as the update command
Posted by "John Didion (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/SCM-165?page=comments#action_59346 ]
John Didion commented on SCM-165:
---------------------------------
I can't get svn diff to work....it can't find the source file when I point it at the tagged version, and when I try to specify the revision (?rev=...) it complains about the URL formatting.
> PerforceChangeLogCommand needs to use the same clientspec as the update command
> -------------------------------------------------------------------------------
>
> Key: SCM-165
> URL: http://jira.codehaus.org/browse/SCM-165
> Project: Maven SCM
> Type: Bug
> Components: maven-scm-provider-perforce
> Versions: 1.0-beta-3
> Reporter: John Didion
> Assignee: Mike Perham
> Priority: Critical
> Attachments: PerforceChangeLogCommand.diff
>
>
> The PerforceChangeLogCommand as written does not work if the update was done with the client spec generated by the checkout/update command. The attached diff will fix the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (SCM-165) PerforceChangeLogCommand needs to use
the same clientspec as the update command
Posted by "Mike Perham (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/SCM-165?page=comments#action_59591 ]
Mike Perham commented on SCM-165:
---------------------------------
Here's my understanding of the requirements:
1) Continuum needs to be able to run update/checkout and changelog in the same VM when running a build. Since this uses a persistent clientspec, the changelog command needs to reuse the same clientspec. That's what this bug is about and it should work with my changes 3 days ago.
2) The changelog mojo needs to be able to run the changelog command as a standalone feature. The command should default to NO clientspec but allow the user to pass in a clientspec on the command line.
3) The user should be able to run 'mvn scm:update scm:changelog' to get results similar to (1) and 'mvn scm:changelog' to get results similar to (2).
Any comments? Any other usecases?
> PerforceChangeLogCommand needs to use the same clientspec as the update command
> -------------------------------------------------------------------------------
>
> Key: SCM-165
> URL: http://jira.codehaus.org/browse/SCM-165
> Project: Maven SCM
> Type: Bug
> Components: maven-scm-provider-perforce
> Versions: 1.0
> Reporter: John Didion
> Assignee: Mike Perham
> Priority: Critical
> Attachments: PerforceChangeLogCommand.diff, svn.diff
>
>
> The PerforceChangeLogCommand as written does not work if the update was done with the client spec generated by the checkout/update command. The attached diff will fix the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (SCM-165) PerforceChangeLogCommand needs to use
the same clientspec as the update command
Posted by "Mike Perham (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/SCM-165?page=comments#action_59599 ]
Mike Perham commented on SCM-165:
---------------------------------
Posted a release candidate with my small changes to allow these usecases. I'm still afraid there will be edge cases I've missed - Emmanuel, can you point me to the changelog plugin and the documentation on how to use it so I can test it here?
> PerforceChangeLogCommand needs to use the same clientspec as the update command
> -------------------------------------------------------------------------------
>
> Key: SCM-165
> URL: http://jira.codehaus.org/browse/SCM-165
> Project: Maven SCM
> Type: Bug
> Components: maven-scm-provider-perforce
> Versions: 1.0
> Reporter: John Didion
> Assignee: Mike Perham
> Priority: Critical
> Attachments: PerforceChangeLogCommand.diff, svn.diff
>
>
> The PerforceChangeLogCommand as written does not work if the update was done with the client spec generated by the checkout/update command. The attached diff will fix the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (SCM-165) PerforceChangeLogCommand needs to use the
same clientspec as the update command
Posted by "John Didion (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/SCM-165?page=all ]
John Didion updated SCM-165:
----------------------------
Attachment: svn.diff
> PerforceChangeLogCommand needs to use the same clientspec as the update command
> -------------------------------------------------------------------------------
>
> Key: SCM-165
> URL: http://jira.codehaus.org/browse/SCM-165
> Project: Maven SCM
> Type: Bug
> Components: maven-scm-provider-perforce
> Versions: 1.0-beta-3
> Reporter: John Didion
> Assignee: Mike Perham
> Priority: Critical
> Attachments: PerforceChangeLogCommand.diff, svn.diff
>
>
> The PerforceChangeLogCommand as written does not work if the update was done with the client spec generated by the checkout/update command. The attached diff will fix the problem.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira