You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "tkaymak (via GitHub)" <gi...@apache.org> on 2026/05/13 18:10:14 UTC
[PR] [runners-spark] Spark 4 follow-up: address remaining review comments from #38255 [beam]
tkaymak opened a new pull request, #38489:
URL: https://github.com/apache/beam/pull/38489
Small follow-up to PR #38255 (`[runners-spark] Add Spark 4 runner`) addressing the two review comments left at the approved/merged head SHA that weren't folded in before merge.
## Changes
1. **Restore `CHANGES.md` `feature Y added to Java SDK` placeholder line** — lost to a rebase; reinstated verbatim. Addresses [`r3204237226`](https://github.com/apache/beam/pull/38255#discussion_r3204237226).
2. **Delete two orphaned `.github/trigger_files/*.json`** — addresses [`r3204241059`](https://github.com/apache/beam/pull/38255#discussion_r3204241059):
- `beam_PreCommit_Java_Spark4_Versions.json` — its workflow YAML was deleted in #38255.
- `beam_PostCommit_Java_ValidatesRunner_Spark4StructuredStreaming.json` — flagged as "not effective yet"; since the comment was written, #38478 renamed the associated workflow YAML to `beam_PostCommit_Java_ValidatesRunner_Spark4.yml`, so this trigger JSON is doubly orphaned.
The renamed workflow YAML stays in place — per the trigger-files convention, these JSONs are only added when an author wants to manually trigger a specific PostCommit.
## Verification
- Local `:validateChanges` passes (build successful, "CHANGES.md validation successful").
R: @Abacn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [runners-spark] Spark 4 follow-up: Announce in CHANGES.md and address remaining review comments from #38255 [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #38489:
URL: https://github.com/apache/beam/pull/38489#discussion_r3236665073
##########
CHANGES.md:
##########
@@ -60,6 +60,8 @@
## Highlights
* New highly anticipated feature X added to Python SDK ([#X](https://github.com/apache/beam/issues/X)).
+* New highly anticipated feature Y added to Java SDK ([#Y](https://github.com/apache/beam/issues/Y)).
+* Spark 4 runner added to Java SDK ([#38255](https://github.com/apache/beam/issues/38255)).
Review Comment:
```suggestion
* Spark 4 runner support for Java SDK ([#38255](https://github.com/apache/beam/issues/38255)).
```
SDK and runner are two different components though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [runners-spark] Spark 4 follow-up: address remaining review comments from #38255 [beam]
Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on PR #38489:
URL: https://github.com/apache/beam/pull/38489#issuecomment-4443971742
## Summary of Changes
Hello, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request serves as a follow-up to the Spark 4 runner implementation, addressing minor review comments that were missed during the initial merge. The changes focus on maintaining documentation accuracy and cleaning up obsolete configuration files.
### Highlights
* **Documentation Update**: Restored the missing 'feature Y added to Java SDK' placeholder line in CHANGES.md.
* **Cleanup**: Removed two orphaned trigger JSON files (.github/trigger_files/) that were no longer associated with active workflows.
<details>
<summary><b>New Features</b></summary>
🧠 You can now enable **Memory** (public preview) to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.**
</details>
<details>
<summary><b>Using Gemini Code Assist</b></summary>
<br>
The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips.
<b>Invoking Gemini</b>
You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page.
Feature | Command | Description
--- | --- | ---
Code Review | `/gemini review` | Performs a code review for the current pull request in its current state.
Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state.
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help | `/gemini help` | Displays a list of available commands.
<b>Customization</b>
To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github).
<b>Limitations & Feedback</b>
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG).
</details>
[^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [runners-spark] Spark 4 follow-up: Announce in CHANGES.md and address remaining review comments from #38255 [beam]
Posted by "tkaymak (via GitHub)" <gi...@apache.org>.
tkaymak commented on code in PR #38489:
URL: https://github.com/apache/beam/pull/38489#discussion_r3236997389
##########
CHANGES.md:
##########
@@ -60,6 +60,8 @@
## Highlights
* New highly anticipated feature X added to Python SDK ([#X](https://github.com/apache/beam/issues/X)).
+* New highly anticipated feature Y added to Java SDK ([#Y](https://github.com/apache/beam/issues/Y)).
+* Spark 4 runner added to Java SDK ([#38255](https://github.com/apache/beam/issues/38255)).
Review Comment:
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [runners-spark] Spark 4 follow-up: Announce in CHANGES.md and address remaining review comments from #38255 [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn merged PR #38489:
URL: https://github.com/apache/beam/pull/38489
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [runners-spark] Spark 4 follow-up: address remaining review comments from #38255 [beam]
Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on code in PR #38489:
URL: https://github.com/apache/beam/pull/38489#discussion_r3236486596
##########
.github/trigger_files/beam_PostCommit_Java_ValidatesRunner_Spark4StructuredStreaming.json:
##########
@@ -1,3 +0,0 @@
-{
Review Comment:
The PR description mentions that the associated workflow was renamed to `beam_PostCommit_Java_ValidatesRunner_Spark4.yml`. In the Beam repository, these trigger files are used by the CI system to allow manual triggering of jobs via GitHub comments (e.g., for ValidatesRunner tests). Deleting this file without providing a replacement with the new name (`beam_PostCommit_Java_ValidatesRunner_Spark4.json`) will break the ability for contributors to manually trigger these tests. It is recommended to rename the file to match the new workflow name instead of just deleting it.
##########
CHANGES.md:
##########
@@ -60,6 +60,7 @@
## Highlights
* New highly anticipated feature X added to Python SDK ([#X](https://github.com/apache/beam/issues/X)).
+* New highly anticipated feature Y added to Java SDK ([#Y](https://github.com/apache/beam/issues/Y)).
Review Comment:
While restoring the placeholder is helpful for future entries, the Spark 4 runner (added in #38255) is a significant feature that should be explicitly listed in the 'Highlights' section of `CHANGES.md`. Consider adding a specific entry for it here to ensure it is properly announced in the release notes.
```suggestion
* New highly anticipated feature Y added to Java SDK ([#Y](https://github.com/apache/beam/issues/Y)).
* Spark 4 runner added to Java SDK ([#38255](https://github.com/apache/beam/pull/38255)).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [runners-spark] Spark 4 follow-up: Announce in CHANGES.md and address remaining review comments from #38255 [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38489:
URL: https://github.com/apache/beam/pull/38489#issuecomment-4444411119
Assigning reviewers:
R: @Abacn added as fallback since no labels match configuration
Note: If you would like to opt out of this review, comment `assign to next reviewer`.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [runners-spark] Spark 4 follow-up: address remaining review comments from #38255 [beam]
Posted by "tkaymak (via GitHub)" <gi...@apache.org>.
tkaymak commented on code in PR #38489:
URL: https://github.com/apache/beam/pull/38489#discussion_r3236515238
##########
.github/trigger_files/beam_PostCommit_Java_ValidatesRunner_Spark4StructuredStreaming.json:
##########
@@ -1,3 +0,0 @@
-{
Review Comment:
Thanks @gemini-code-assist, but my read of @Abacn's guidance on #38453 is that we don't add stub trigger JSONs for new workflow YAMLs. Quoting his reply on #38453 (https://github.com/apache/beam/pull/38453#discussion_r3225387943):
> I've seen a few occurrences AI-assisted PRs keep adding trigger file json for new workflow addition, which is not necessary. Creation or modification of trigger file is only needed when the PR author want to trigger a specific PostCommit manually.
So the deletion here removes a doubly-orphaned file (workflow YAML deleted in #38255, then renamed in #38478), and we deliberately do not add a `beam_PostCommit_Java_ValidatesRunner_Spark4.json` replacement. Manual triggering still works via the standard `Run Java_ValidatesRunner_Spark4 PostCommit` comment phrase that the workflow YAML defines; the trigger JSON is only one of several activation paths.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [runners-spark] Spark 4 follow-up: address remaining review comments from #38255 [beam]
Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on code in PR #38489:
URL: https://github.com/apache/beam/pull/38489#discussion_r3236517444
##########
.github/trigger_files/beam_PostCommit_Java_ValidatesRunner_Spark4StructuredStreaming.json:
##########
@@ -1,3 +0,0 @@
-{
Review Comment:
Thank you for the clarification regarding the trigger file policy. Understanding that these files are not required for new workflows and that manual triggering is handled via the workflow YAML directly clarifies the situation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org