You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by omalley <gi...@git.apache.org> on 2016/06/02 21:52:34 UTC
[GitHub] orc pull request #33: ORC-62 Clean up for orc-1.1.0 release.
GitHub user omalley opened a pull request:
https://github.com/apache/orc/pull/33
ORC-62 Clean up for orc-1.1.0 release.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/omalley/orc orc-62
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/orc/pull/33.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #33
----
commit 54686e5db9766822c587dd4c3cb4afc4b44e5684
Author: Owen O'Malley <om...@apache.org>
Date: 2016-06-02T21:51:33Z
ORC-62 Clean up for orc-1.1.0 release.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] orc pull request #33: ORC-62 Clean up for orc-1.1.0 release.
Posted by prasanthj <gi...@git.apache.org>.
Github user prasanthj commented on a diff in the pull request:
https://github.com/apache/orc/pull/33#discussion_r65625940
--- Diff: CMakeLists.txt ---
@@ -56,16 +64,17 @@ set (ZLIB_LIBRARIES zlib)
#
# Compiler specific flags
#
+set(CMAKE_CXX_FLAGS_DEBUG "-O0 -g")
--- End diff --
Will be good to have these in README.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] orc issue #33: ORC-62 Clean up for orc-1.1.0 release.
Posted by prasanthj <gi...@git.apache.org>.
Github user prasanthj commented on the issue:
https://github.com/apache/orc/pull/33
LGTM, +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] orc pull request #33: ORC-62 Clean up for orc-1.1.0 release.
Posted by omalley <gi...@git.apache.org>.
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/33#discussion_r65626684
--- Diff: CMakeLists.txt ---
@@ -56,16 +64,17 @@ set (ZLIB_LIBRARIES zlib)
#
# Compiler specific flags
#
+set(CMAKE_CXX_FLAGS_DEBUG "-O0 -g")
--- End diff --
Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] orc pull request #33: ORC-62 Clean up for orc-1.1.0 release.
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/orc/pull/33
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---