[GitHub] dpogue closed pull request #486: GH-485: (android) Replace deprecated "compile" with "implementation"

[GitBox <gi...@apache.org>]

dpogue closed pull request #486: GH-485: (android) Replace deprecated "compile" with "implementation"
URL: https://github.com/apache/cordova-android/pull/486
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/bin/templates/cordova/lib/builders/ProjectBuilder.js b/bin/templates/cordova/lib/builders/ProjectBuilder.js
index bba971d5d..b146b8b0f 100644
--- a/bin/templates/cordova/lib/builders/ProjectBuilder.js
+++ b/bin/templates/cordova/lib/builders/ProjectBuilder.js
@@ -196,7 +196,7 @@ class ProjectBuilder {
                     throw new CordovaError('Unsupported system library (does not work with gradle): ' + p);
                 }
             }
-            depsList += '    compile "' + mavenRef + '"\n';
+            depsList += '    implementation "' + mavenRef + '"\n';
         });
 
         buildGradle = buildGradle.replace(/(SUB-PROJECT DEPENDENCIES START)[\s\S]*(\/\/ SUB-PROJECT DEPENDENCIES END)/, '$1\n' + depsList + '    $2');


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org