You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/01 16:56:43 UTC

[GitHub] [airflow] rossturk commented on pull request #25449: Move breeze commands to sub-commands

rossturk commented on PR #25449:
URL: https://github.com/apache/airflow/pull/25449#issuecomment-1201465628

   @potiuk I have successfully run through the `start-airflow`, `prod-image build-image`, `compile-www-assets`, and `build-docs` commands. They all seem to work as before. And I like the new subcommand structure 👍 
   
   I have noticed that the output no longer wraps properly in terminals less than 180 characters wide. I'm not much of an expert in click, so I'm not sure how to fix this. I suspect `click.rich_click.MAX_WIDTH = 180` is somehow involved.
   
   Here is what I get when running breeze from `main`:
   <img width="828" alt="Screenshot 2022-08-01 at 12 40 13 PM" src="https://user-images.githubusercontent.com/1434475/182200111-0ec544c3-1f0f-42c4-afa7-e00f179ebf5f.png">
   
   And here is what I get when running breeze from your branch:
   <img width="872" alt="Screenshot 2022-08-01 at 12 40 14 PM" src="https://user-images.githubusercontent.com/1434475/182200139-b0479041-b946-4354-9432-680b9fbc3c40.png">
   
   I haven't reviewed any of the CI stuff, FYI. Not sure I understand it well enough to contribute much there.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org