[GitHub] [netbeans] eirikbakke commented on a change in pull request #504: Option to skip CoS copying of class files when the target is already newer, such as from an external compilation

[GitBox <gi...@apache.org>]

eirikbakke commented on a change in pull request #504:
URL: https://github.com/apache/netbeans/pull/504#discussion_r625459422



##########
File path: java/java.source.base/arch.xml
##########
@@ -803,9 +803,19 @@
         </question>
 -->
  <answer id="exec-property">
-  <p>
-   XXX no answer for exec-property
-  </p>
+  <ul>
+   <li>
+    <api type="export" group="systemproperty" name="org.netbeans.modules.java.source.usages.BuildArtifactMapperImpl.COMPARE_TIMESTAMPS" category="private">
+     <p>
+      If set to <code>true</code>,
+      <code>*.class</code> files generated by external build processes
+      will not be overwritten by the IDE’s Java parser
+      when running in “compile-on-save” mode

Review comment:
       I was doing a build on Windows today, and got the following amusing error :-)
   
   ```
   BUILD FAILED
   C:\Users\ebakke\ZRoot\nbsrc\incubator-netbeans\nbbuild\build.xml:395: The following error occurred while executing this line:
   C:\Users\ebakke\ZRoot\nbsrc\incubator-netbeans\nbbuild\javadoctools\build.xml:48: The following error occurred while executing this line:
   C:\Users\ebakke\ZRoot\nbsrc\incubator-netbeans\nbbuild\javadoctools\build.xml:149: javax.xml.transform.TransformerException: javax.xml.transform.TransformerException: com.sun.org.apache.xml.internal.utils.WrappedRuntimeException: Invalid byte 3 of 3-byte UTF-8 sequence.
   ```
   
   Examining build.xml:149, it points to the file nbbuild/build/javadoc/alldatas.xml, which indeed appears to have a malformed UTF-8 character somewhere.
   
   Doing some further investigation...
   
   ```
   ebakke@EBLEN:/z/nbsrc/incubator-netbeans/nbbuild/build/javadoc$ diff alldatas1.xml alldatas2.xml
   5139c5139
   <       when running in “compile-on-save? mode
   ---
   >       when running in “compile-on-save�? mode
   ```
   
   So these odd quotes did indeed cause some trouble down the line...
   
   Should I open a PR to fix it?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists