You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/07/29 19:40:47 UTC
[GitHub] [arrow-rs] alamb opened a new pull request #631: Fix clippy lints for Rust 1.54
alamb opened a new pull request #631:
URL: https://github.com/apache/arrow-rs/pull/631
# Which issue does this PR close?
NA
# Rationale for this change
It's that time again! [Rust released 1.54 today](https://github.com/rust-lang/rust/blob/master/RELEASES.md#version-1540-2021-07-29) which causes some additional clippy errors:
If you run clippy on master after running `rustup update` you get erros such as the following
```
error: this expression borrows a reference (`&arrow::ipc::writer::IpcWriteOptions`) that is immediately dereferenced by the compiler
--> integration-testing/src/flight_client_scenarios/integration_test.rs:131:66
|
131 | arrow_flight::utils::flight_data_from_arrow_batch(batch, &options);
| ^^^^^^^^ help: change this to: `options`
|
= note: `-D clippy::needless-borrow` implied by `-D warnings`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
error: this expression borrows a reference (`&[arrow::record_batch::RecordBatch]`) that is immediately dereferenced by the compiler
--> integration-testing/src/flight_client_scenarios/integration_test.rs:169:17
|
169 | &expected_data,
| ^^^^^^^^^^^^^^ help: change this to: `expected_data`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
```
# What changes are included in this PR?
1. Fix clippy errors by doing its suggestions or suppressing
# Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] Dandandan merged pull request #631: Fix clippy lints for Rust 1.54
Posted by GitBox <gi...@apache.org>.
Dandandan merged pull request #631:
URL: https://github.com/apache/arrow-rs/pull/631
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org