You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/12/12 21:46:30 UTC
[GitHub] [netbeans] rkeen-siemens opened a new issue, #5098: Output window sub-tabs don't honor TabbedPane foreground color settings
rkeen-siemens opened a new issue, #5098:
URL: https://github.com/apache/netbeans/issues/5098
### Apache NetBeans version
Apache NetBeans 16
### What happened
Attempting to modify the tabbed pane foreground colors does not work for output window sub-tabs.
### How to reproduce
Go to Tools > Options > Appearance > FlatLaf and click Edit custom properties and add the following line
```
TabbedPane.selectedForeground = $TabbedPane.underlineColor
```
Restart the IDE and open two output window sub-tabs (e.g. by running two files from different projects). I would expect the selected tab to be the same as the focused underline color. If you make the same change for `EditorTab.selectedForeground`, those tabs do render with the correct color.
### Did this work correctly in an earlier version?
No / Don't know
### Operating System
Windows 10 Pro, CentOS 7.6 with Gnome 3
### JDK
Java 17.0.4.1
### Apache NetBeans packaging
Apache NetBeans provided installer
### Anything else
These tabs appear to be generated via `org.netbeans.core.windows.view.ui.CloseButtonTabbedPane` which sets a custom component to render the title for each tab (`ButtonTab`). This component should inherit the colors from the enclosing tabbed pane or provide a separate setting to allow setting the colors as done with `EditorTab` and `ViewTab`.
### Are you willing to submit a pull request?
No
### Code of Conduct
Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] IanKrL commented on issue #5098: Output window sub-tabs don't honor TabbedPane foreground color settings
Posted by "IanKrL (via GitHub)" <gi...@apache.org>.
IanKrL commented on issue #5098:
URL: https://github.com/apache/netbeans/issues/5098#issuecomment-1614822132
These tabs also don't honor font settings. If you set:
`TabbedPane.font = +bold`
Nothing happens to the Output window sub-tabs.
My fix is to add
`label.setFont(UIManager.getFont("TabbedPane.font"));`
in the ButtonTab constructor, after 'label' has been declared.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on issue #5098: Output window sub-tabs don't honor TabbedPane foreground color settings
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on issue #5098:
URL: https://github.com/apache/netbeans/issues/5098#issuecomment-1623729369
Given FlatLaf has its own closable tabs (eg. https://github.com/JFormDesigner/FlatLaf/pull/193 ) might also want to see if we should provide an alternative `TabbedPaneFactory`, or otherwise different implementation of `CloseButtonTabbedPane` when it is the active LaF? cc/ @DevCharly - what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on issue #5098: Output window sub-tabs don't honor TabbedPane foreground color settings
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on issue #5098:
URL: https://github.com/apache/netbeans/issues/5098#issuecomment-1350826539
Makes sense IMO, and the label should probably just inherit the container colour. Could possibly provide extra key, defaulting to tabbed pane colour, for the outer container.
Aside - amount of LAF specific code in that class is hideous.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] rkeen-siemens commented on issue #5098: Output window sub-tabs don't honor TabbedPane foreground color settings
Posted by "rkeen-siemens (via GitHub)" <gi...@apache.org>.
rkeen-siemens commented on issue #5098:
URL: https://github.com/apache/netbeans/issues/5098#issuecomment-1628943198
That sounds like a good idea and perhaps also use that factory for the top level tabs as well (editor and view tabs).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists