You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by zhangminglei <gi...@git.apache.org> on 2017/04/18 02:01:30 UTC

[GitHub] flink pull request #3730: [FLINK-5943] [YARN] Fix unprotected access to haSe...

GitHub user zhangminglei opened a pull request:

    https://github.com/apache/flink/pull/3730

    [FLINK-5943] [YARN] Fix unprotected access to haServices in YarnFlink\u2026

    \u2026ApplicationMasterRunner#shutdown().
    
    Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your changes.
    
    - [ ] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [ ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [ ] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zhangminglei/flink flink-5943

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3730.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3730
    
----
commit f31052dbe8a7b8150504757c15b3e731cc6f87c2
Author: zhangminglei <zm...@163.com>
Date:   2017-04-18T02:00:09Z

    [FLINK-5943] [YARN] Fix unprotected access to haServices in YarnFlinkApplicationMasterRunner#shutdown().

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #3730: [FLINK-5943] [YARN] Fix unprotected access to haSe...

Posted by zhangminglei <gi...@git.apache.org>.

Github user zhangminglei closed the pull request at:

    https://github.com/apache/flink/pull/3730


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3730: [FLINK-5943] [YARN] Fix unprotected access to haServices ...

Posted by tillrohrmann <gi...@git.apache.org>.

Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/3730
  
    Hi @zhangminglei, I think the logic to access the `RunningJobsRegistry` from the `YarnApplicationMasterRunner` is wrong. The decision to clear a job or not should be done by the `JobManagerRunner`. Therefore, the right solution would be to remove the `clearJob` call from the `shutdown` method. I will do this. Consequently, please close this PR and the corresponding JIRA issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3730: [FLINK-5943] [YARN] Fix unprotected access to haServices ...

Posted by zhangminglei <gi...@git.apache.org>.

Github user zhangminglei commented on the issue:

    https://github.com/apache/flink/pull/3730
  
    @tillrohrmann  Thanks for telling me so useful information. very appreciate it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---