[GitHub] [ozone] guihecheng commented on a diff in pull request #3292: HDDS-6541. [Merge rocksdb in datanode] Per-disk DB location management.

[GitBox <gi...@apache.org>]

guihecheng commented on code in PR #3292:
URL: https://github.com/apache/ozone/pull/3292#discussion_r848264850


##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/ozoneimpl/OzoneContainer.java:
##########
@@ -133,6 +138,16 @@ public OzoneContainer(
     volumeSet.setFailedVolumeListener(this::handleVolumeFailures);
     metaVolumeSet = new MutableVolumeSet(datanodeDetails.getUuidString(), conf,
         context, VolumeType.META_VOLUME, volumeChecker);
+    if (VersionedDatanodeFeatures.SchemaV3.chooseSchemaVersion()
+        .equals(OzoneConsts.SCHEMA_V3)) {
+      dbVolumeSet = HddsServerUtil.getDatanodeDbDirs(conf).isEmpty() ? null :

Review Comment:
   1. Oh, yes, we should shutdown there
   2. Sure.
   3. That's a good idea, we could have a new scanner to check the db instances in another PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org