You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/12 16:40:19 UTC
[GitHub] [apisix] Miss-you opened a new pull request #2731: remove upstream 'Server' header info. fix #2714
Miss-you opened a new pull request #2731:
URL: https://github.com/apache/apisix/pull/2731
### What this PR does / why we need it:
I think it's better to just leave `Server: APISIX/2.0` and override the other `server` header field!
demoļ¼
```
$ curl http://127.0.0.1:9080/test_core -i
HTTP/1.1 200 OK
Content-Type: text/html; charset=utf-8
Transfer-Encoding: chunked
Connection: keep-alive
Server: APISIX/2.0
Date: Thu, 12 Nov 2020 04:31:03 GMT
tested by python
```
ref:
https://github.com/apache/apisix/issues/2714
### Pre-submission checklist:
* [ ] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #2731: fix: remove upstream 'Server' header info. fix #2714
Posted by GitBox <gi...@apache.org>.
spacewander commented on pull request #2731:
URL: https://github.com/apache/apisix/pull/2731#issuecomment-726447133
Please remove the `proxy_pass_header Server` from the template and test suite. Remember to update the tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tokers commented on pull request #2731: fix: remove upstream 'Server' header info. fix #2714
Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #2731:
URL: https://github.com/apache/apisix/pull/2731#issuecomment-728811051
@Miss-you Any updates?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on pull request #2731: fix: remove upstream 'Server' header info. fix #2714
Posted by GitBox <gi...@apache.org>.
Firstsawyou commented on pull request #2731:
URL: https://github.com/apache/apisix/pull/2731#issuecomment-729049087
You need to check the failed test case: `t/core/utils.t` .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #2731: fix: remove upstream 'Server' header info. fix #2714
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #2731:
URL: https://github.com/apache/apisix/pull/2731
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Miss-you commented on pull request #2731: fix: remove upstream 'Server' header info. fix #2714
Posted by GitBox <gi...@apache.org>.
Miss-you commented on pull request #2731:
URL: https://github.com/apache/apisix/pull/2731#issuecomment-729070512
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Miss-you commented on pull request #2731: fix: remove upstream 'Server' header info. fix #2714
Posted by GitBox <gi...@apache.org>.
Miss-you commented on pull request #2731:
URL: https://github.com/apache/apisix/pull/2731#issuecomment-729065574
> Please remove the `proxy_pass_header Server` from the template and test suite. Remember to update the tests.
Let me examine the proxy_pass_header parameter first....
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Miss-you edited a comment on pull request #2731: fix: remove upstream 'Server' header info. fix #2714
Posted by GitBox <gi...@apache.org>.
Miss-you edited a comment on pull request #2731:
URL: https://github.com/apache/apisix/pull/2731#issuecomment-729065574
> Please remove the `proxy_pass_header Server` from the template and test suite. Remember to update the tests.
Let me examine the proxy_pass_header parameter first....
ref:
http://nginx.org/en/docs/http/ngx_http_proxy_module.html#proxy_pass_header
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org