You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eagle.apache.org by r7raul1984 <gi...@git.apache.org> on 2016/08/05 06:01:12 UTC
[GitHub] incubator-eagle pull request #303: [EAGLE-416] Add check style support
GitHub user r7raul1984 opened a pull request:
https://github.com/apache/incubator-eagle/pull/303
[EAGLE-416] Add check style support
- Add checkstyle plugin config in pom file.
- Add eagle_checks and suppressions file.
https://issues.apache.org/jira/browse/EAGLE-416
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/r7raul1984/incubator-eagle checkstyle-EAGLE416
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-eagle/pull/303.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #303
----
commit edfa70cdffa9fa362f16bc6b5db575b2ed0d937c
Author: r7raul1984 <ta...@yhd.com>
Date: 2016-08-05T05:18:28Z
[EAGLE-416] Add check style support
- Add checkstyle plugin config in pom file.
- Add eagle_checks and suppressions file.
https://issues.apache.org/jira/browse/EAGLE-416
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle issue #303: [EAGLE-416] Add check style support
Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on the issue:
https://github.com/apache/incubator-eagle/pull/303
@r7raul1984 thanks for the update, looks very good now. Would you please raise a discussion in dev list about main specification defined in the check style configuration? For example, titled "[Discuss] Check Style Specification", so that the community could leave comments about it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle issue #303: [EAGLE-416] Add check style support
Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on the issue:
https://github.com/apache/incubator-eagle/pull/303
Jenkins building failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle issue #303: [EAGLE-416] Add check style support
Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on the issue:
https://github.com/apache/incubator-eagle/pull/303
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle issue #303: [EAGLE-416] Add check style support
Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on the issue:
https://github.com/apache/incubator-eagle/pull/303
@r7raul1984 I am planing to merge this PR, but have little conflicts, could you please help resole it firstly?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle issue #303: [EAGLE-416] Add check style support
Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on the issue:
https://github.com/apache/incubator-eagle/pull/303
It seems that the PR created as new directory [`build`](/r7raul1984/incubator-eagle/tree/checkstyle-EAGLE416/build) under project root, would you please just put the checkstyle files under [`eagle-dev`](/apache/incubator-eagle/tree/master/eagle-dev) directly?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-eagle pull request #303: [EAGLE-416] Add check style support
Posted by r7raul1984 <gi...@git.apache.org>.
Github user r7raul1984 closed the pull request at:
https://github.com/apache/incubator-eagle/pull/303
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---