You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by terbolous <gi...@git.apache.org> on 2015/10/13 08:53:12 UTC
[GitHub] cloudstack-www pull request: Improvements to survey.html
GitHub user terbolous opened a pull request:
https://github.com/apache/cloudstack-www/pull/16
Improvements to survey.html
Made the survey.html agnostic to protocol used, previously
the iframe was hardcoded with a http:// link and this breaks when
visiting the site over https.
Also set the iframe height to 2000px and enabled scrollbars, this is
to allow longer sides to show properly without the need of having a
really long page for all other pages
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/terbolous/cloudstack-www master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack-www/pull/16.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #16
----
commit a08136e7eff0818a0f8b0edcbb7311be0eff3568
Author: Erik Weber <te...@gmail.com>
Date: 2015-10-12T13:11:42Z
Improvements to survey.html
Made the survey.html agnostic to protocol used, previously
the iframe was hardcoded with a http:// link and this breaks when
visiting the site over https.
Also set the iframe height to 2000px and enabled scrollbars, this is
to allow longer sides to show properly without the need of having a
really long page for all other pages
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack-www pull request: Improvements to survey.html
Posted by runseb <gi...@git.apache.org>.
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack-www/pull/16#issuecomment-147636042
+0
I don't think we need two LGTM etc for this.
But it's automatically built, so you don't need to touch the .html.
Jut edit the .md file, and build with the script build.sh
You can build on master and then merge in asf-site branch, which will get deployed automatically.
I basically use master branch for dev/test and merge for prod.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack-www pull request: Improvements to survey.html
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack-www/pull/16
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack-www pull request: Improvements to survey.html
Posted by terbolous <gi...@git.apache.org>.
Github user terbolous commented on the pull request:
https://github.com/apache/cloudstack-www/pull/16#issuecomment-147637056
I didn't touch the html manually, but included the generated html in the commit. Not sure if that is necessary or not.
Should I wait for a couple of others to comment on the LGTM thing, or just merge it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack-www pull request: Improvements to survey.html
Posted by runseb <gi...@git.apache.org>.
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack-www/pull/16#issuecomment-147640430
you can merge. but make sure to merge in the other branch as well, otherwise it won't go live.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---