You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/01/01 19:21:13 UTC
[GitHub] [maven] michael-o opened a new pull request #425: Consistent logging
michael-o opened a new pull request #425:
URL: https://github.com/apache/maven/pull/425
This strives to consistently quote non-numeric args and bracketing collections as done in other spots of the codebase. `DefaultBuildResumptionDataRepository` wasn't touched intentionally as this will be subject so a separate PR.
IT PR: https://github.com/apache/maven-integration-testing/pull/97
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] mthmulders commented on a change in pull request #425: Consistent logging
Posted by GitBox <gi...@apache.org>.
mthmulders commented on a change in pull request #425:
URL: https://github.com/apache/maven/pull/425#discussion_r550858021
##########
File path: maven-embedder/src/main/java/org/apache/maven/cli/configuration/SettingsXmlConfigurationProcessor.java
##########
@@ -151,16 +151,16 @@ public void process( CliRequest cliRequest )
populateFromSettings( request, settingsResult.getEffectiveSettings() );
- if ( !settingsResult.getProblems().isEmpty() && logger.isWarnEnabled() )
+ if ( !settingsResult.getProblems().isEmpty() && LOGGER.isWarnEnabled() )
{
- logger.warn( "" );
- logger.warn( "Some problems were encountered while building the effective settings" );
+ LOGGER.warn( "" );
+ LOGGER.warn( "Some problems were encountered while building the effective settings" );
for ( SettingsProblem problem : settingsResult.getProblems() )
{
- logger.warn( "{} @ {}", problem.getMessage(), problem.getLocation() );
+ LOGGER.warn( "{} @ {}", problem.getMessage(), problem.getLocation() );
Review comment:
Shouldn't there be single quotes here, too, since the message and the location are both non-numeric arguments?
##########
File path: maven-core/src/main/java/org/apache/maven/project/collector/MultiModuleCollectionStrategy.java
##########
@@ -76,7 +76,7 @@ public MultiModuleCollectionStrategy( ModelLocator modelLocator, ProjectsSelecto
}
else
{
- logger.debug( "Multi module project collection failed: {}"
+ LOGGER.debug( "Multi module project collection failed:{}"
Review comment:
Please restore the space after the colon.
##########
File path: maven-core/src/main/java/org/apache/maven/project/collector/MultiModuleCollectionStrategy.java
##########
@@ -91,7 +91,7 @@ public MultiModuleCollectionStrategy( ModelLocator modelLocator, ProjectsSelecto
if ( fallThrough )
{
- logger.debug( "Multi module project collection failed: {}"
+ LOGGER.debug( "Multi module project collection failed:{}"
Review comment:
Please restore the space after the colon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #425: Consistent logging
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #425:
URL: https://github.com/apache/maven/pull/425#issuecomment-754690509
Merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #425: Consistent logging
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #425:
URL: https://github.com/apache/maven/pull/425#discussion_r550871932
##########
File path: maven-core/src/main/java/org/apache/maven/project/collector/MultiModuleCollectionStrategy.java
##########
@@ -76,7 +76,7 @@ public MultiModuleCollectionStrategy( ModelLocator modelLocator, ProjectsSelecto
}
else
{
- logger.debug( "Multi module project collection failed: {}"
+ LOGGER.debug( "Multi module project collection failed:{}"
Review comment:
Have a look at the first arg: line separator.
##########
File path: maven-core/src/main/java/org/apache/maven/project/collector/MultiModuleCollectionStrategy.java
##########
@@ -91,7 +91,7 @@ public MultiModuleCollectionStrategy( ModelLocator modelLocator, ProjectsSelecto
if ( fallThrough )
{
- logger.debug( "Multi module project collection failed: {}"
+ LOGGER.debug( "Multi module project collection failed:{}"
Review comment:
Same here
##########
File path: maven-embedder/src/main/java/org/apache/maven/cli/configuration/SettingsXmlConfigurationProcessor.java
##########
@@ -151,16 +151,16 @@ public void process( CliRequest cliRequest )
populateFromSettings( request, settingsResult.getEffectiveSettings() );
- if ( !settingsResult.getProblems().isEmpty() && logger.isWarnEnabled() )
+ if ( !settingsResult.getProblems().isEmpty() && LOGGER.isWarnEnabled() )
{
- logger.warn( "" );
- logger.warn( "Some problems were encountered while building the effective settings" );
+ LOGGER.warn( "" );
+ LOGGER.warn( "Some problems were encountered while building the effective settings" );
for ( SettingsProblem problem : settingsResult.getProblems() )
{
- logger.warn( "{} @ {}", problem.getMessage(), problem.getLocation() );
+ LOGGER.warn( "{} @ {}", problem.getMessage(), problem.getLocation() );
Review comment:
Technically yes, but it is in both cases a multi word message (sentence) which does not make sense to be quoted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o closed pull request #425: Consistent logging
Posted by GitBox <gi...@apache.org>.
michael-o closed pull request #425:
URL: https://github.com/apache/maven/pull/425
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org