You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/01/07 11:59:37 UTC
[GitHub] [hadoop-ozone] adoroszlai opened a new pull request #413:
HDDS-2834. Directly read into ByteBuffer if it has array
adoroszlai opened a new pull request #413: HDDS-2834. Directly read into ByteBuffer if it has array
URL: https://github.com/apache/hadoop-ozone/pull/413
## What changes were proposed in this pull request?
* Use target `ByteBuffer`'s array, if it has one, to avoid buffer copy in `OzoneFSInputStream`.
* Skip `ByteBuffer#put` on EOF (see similar logic in `CryptoInputStream`).
* Rename `TestOzoneFSInputStreamUnit` to `TestOzoneFSInputStream` since integration test with same name was moved out to `integration-test`. Also move it to the correct package (where `OzoneFSInputStream` resides).
https://issues.apache.org/jira/browse/HDDS-2834
## How was this patch tested?
Tweaked unit test to exercise the `read` method with both heap and direct buffers.
https://github.com/adoroszlai/hadoop-ozone/runs/377273986
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on issue #413: HDDS-2834.
Directly read into ByteBuffer if it has array
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on issue #413: HDDS-2834. Directly read into ByteBuffer if it has array
URL: https://github.com/apache/hadoop-ozone/pull/413#issuecomment-571588381
@fapifta please review if you have some time
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on issue #413: HDDS-2834.
Directly read into ByteBuffer if it has array
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on issue #413: HDDS-2834. Directly read into ByteBuffer if it has array
URL: https://github.com/apache/hadoop-ozone/pull/413#issuecomment-571930008
Thanks @bharatviswa504 for reviewing and merging this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] bharatviswa504 commented on issue #413: HDDS-2834.
Directly read into ByteBuffer if it has array
Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on issue #413: HDDS-2834. Directly read into ByteBuffer if it has array
URL: https://github.com/apache/hadoop-ozone/pull/413#issuecomment-571898775
Thank You @adoroszlai for the contribution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] bharatviswa504 merged pull request #413: HDDS-2834.
Directly read into ByteBuffer if it has array
Posted by GitBox <gi...@apache.org>.
bharatviswa504 merged pull request #413: HDDS-2834. Directly read into ByteBuffer if it has array
URL: https://github.com/apache/hadoop-ozone/pull/413
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org