You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/02/04 01:06:54 UTC
[GitHub] [lucene] gautamworah96 commented on a change in pull request #632: LUCENE-10050 Remove DrillSideways#search(DrillDownQuery,Collector) in favor of DrillSideways#search(DrillDownQuery,CollectorManager)
gautamworah96 commented on a change in pull request #632:
URL: https://github.com/apache/lucene/pull/632#discussion_r799091771
##########
File path: lucene/facet/src/java/org/apache/lucene/facet/DrillSideways.java
##########
@@ -351,45 +344,36 @@ public DrillSidewaysResult search(ScoreDoc after, DrillDownQuery query, int topN
}
final int fTopN = Math.min(topN, limit);
- if (executor != null) { // We have an executor, let use the multi-threaded version
+ final CollectorManager<TopScoreDocCollector, TopDocs> collectorManager =
+ new CollectorManager<>() {
- final CollectorManager<TopScoreDocCollector, TopDocs> collectorManager =
- new CollectorManager<>() {
+ @Override
+ public TopScoreDocCollector newCollector() {
+ return TopScoreDocCollector.create(fTopN, after, Integer.MAX_VALUE);
+ }
- @Override
- public TopScoreDocCollector newCollector() {
- return TopScoreDocCollector.create(fTopN, after, Integer.MAX_VALUE);
- }
-
- @Override
- public TopDocs reduce(Collection<TopScoreDocCollector> collectors) {
- final TopDocs[] topDocs = new TopDocs[collectors.size()];
- int pos = 0;
- for (TopScoreDocCollector collector : collectors)
- topDocs[pos++] = collector.topDocs();
- return TopDocs.merge(topN, topDocs);
- }
- };
- ConcurrentDrillSidewaysResult<TopDocs> r = searchConcurrently(query, collectorManager);
- return new DrillSidewaysResult(
- r.facets,
- r.collectorResult,
- r.drillDownFacetsCollector,
- r.drillSidewaysFacetsCollector,
- r.drillSidewaysDims);
+ @Override
+ public TopDocs reduce(Collection<TopScoreDocCollector> collectors) {
+ final TopDocs[] topDocs = new TopDocs[collectors.size()];
+ int pos = 0;
+ for (TopScoreDocCollector collector : collectors) topDocs[pos++] = collector.topDocs();
Review comment:
Yeah. Spotless automatically moved it to the previous line. Fixed it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org