You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hawq.apache.org by armenatzoglou <gi...@git.apache.org> on 2016/02/24 01:52:46 UTC
[GitHub] incubator-hawq pull request: HAWQ-445. Support large strings (up t...
GitHub user armenatzoglou opened a pull request:
https://github.com/apache/incubator-hawq/pull/378
HAWQ-445. Support large strings (up to a GB) in text_to_array()
This commit is adding support to handle large strings (up to a GB) in text_to_array(). The fix has been picked from GPDB.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gcaragea/incubator-hawq nikos-HAWQ-445
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/378.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #378
----
commit 3933f12af3c3eb1fadc13b4192a056f055d434a8
Author: Nikos Armenatzoglou <ni...@gmail.com>
Date: 2016-02-23T00:27:02Z
HAWQ-445. Support large strings (up to a GB) in text_to_array()
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-445. Support large strings (up t...
Posted by armenatzoglou <gi...@git.apache.org>.
Github user armenatzoglou closed the pull request at:
https://github.com/apache/incubator-hawq/pull/378
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-445. Support large strings (up t...
Posted by armenatzoglou <gi...@git.apache.org>.
Github user armenatzoglou commented on the pull request:
https://github.com/apache/incubator-hawq/pull/378#issuecomment-200532790
Thanks @wengyanqing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-445. Support large strings (up t...
Posted by armenatzoglou <gi...@git.apache.org>.
Github user armenatzoglou commented on the pull request:
https://github.com/apache/incubator-hawq/pull/378#issuecomment-187993259
@foyzur Please take a look when you have time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-445. Support large strings (up t...
Posted by foyzur <gi...@git.apache.org>.
Github user foyzur commented on the pull request:
https://github.com/apache/incubator-hawq/pull/378#issuecomment-188903783
@armenatzoglou is it possible to preserve the original cherry-picked commit and add any additional modification on top of that? Going forward we will be porting many fixes from GPDB to HAWQ and it might be a good practice to preserve the authorship :-) That's also the way we port fixes from Postgres to GPDB, e.g.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-445. Support large strings (up t...
Posted by wengyanqing <gi...@git.apache.org>.
Github user wengyanqing commented on the pull request:
https://github.com/apache/incubator-hawq/pull/378#issuecomment-200185372
I had merged this PR, @armenatzoglou would you please close it ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-445. Support large strings (up t...
Posted by armenatzoglou <gi...@git.apache.org>.
Github user armenatzoglou commented on the pull request:
https://github.com/apache/incubator-hawq/pull/378#issuecomment-189530006
@foyzur I see your point, but I do not think that this is possible for this PR. The reason is that this code comes from a commit three years ago. Unfortunately, in GPDB OSS there is no commits' history from back then. In particular, the history of the files changed in this PR starts from 10/23/2015 with a commit that squashes all previous ones. Consequently, those commits are not appropriate for this PR. Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-445. Support large strings (up t...
Posted by armenatzoglou <gi...@git.apache.org>.
Github user armenatzoglou commented on the pull request:
https://github.com/apache/incubator-hawq/pull/378#issuecomment-190363151
@foyzur I gave it a try to cherry-pick the changes from stash, but it is not possible, since they have different folder structure. I have added the hash of your commits in this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-445. Support large strings (up t...
Posted by foyzur <gi...@git.apache.org>.
Github user foyzur commented on the pull request:
https://github.com/apache/incubator-hawq/pull/378#issuecomment-188453389
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-445. Support large strings (up t...
Posted by karthijrk <gi...@git.apache.org>.
Github user karthijrk commented on the pull request:
https://github.com/apache/incubator-hawq/pull/378#issuecomment-188423548
LGTM :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-445. Support large strings (up t...
Posted by armenatzoglou <gi...@git.apache.org>.
Github user armenatzoglou commented on the pull request:
https://github.com/apache/incubator-hawq/pull/378#issuecomment-190366671
@changleicn Please add the hash of GPDB commits (see first comment) in the final commit. thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---