You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by "lhotari (via GitHub)" <gi...@apache.org> on 2026/03/05 18:22:05 UTC
Re: [PR] [client] fix writeLac memory leak and thread safety issue [bookkeeper]
lhotari commented on code in PR #4713:
URL: https://github.com/apache/bookkeeper/pull/4713#discussion_r2891518336
##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingWriteLacOp.java:
##########
Review Comment:
just wondering if `initiate` should also be made `synchronized` or `toSend` `volatile`. Since this method is only called once, it's most likely not necessary if the reference of PendingWriteLacOp is passed across threads using ways where happens-before is ensured (such as passing the reference via an Executor, ConcurrentHashMap or other solutions that already ensure happens-before).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org