[GitHub] [incubator-pinot] fx19880617 commented on pull request #6506: Fix hadoop batch ingest

[GitBox <gi...@apache.org>]

fx19880617 commented on pull request #6506:
URL: https://github.com/apache/incubator-pinot/pull/6506#issuecomment-770530393


   > Hi @fx19880617 - it was a weird issue. Building locally, I would get a URI to a Pinot plugin jar file with:
   > 
   > ```java
   > SomePintoClassInPluginJar.class.getProtectionDomain().getCodeSource().getLocation().toURI()
   > ```
   > 
   > But on the build server, this returns a URI to the directory containing the `SomePintoClassInPluginJar.class` file. I've changed the code to use a class from some dependency jar that's not part of Pinot (as we're just using it to test creating a tarball of files, and adding a dependency file to the distributed cache). So all checks seem to be passing now.
   
   I think that's fine. We can just test packaging the jar and ensure the unpacked jar is the same.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org