You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/09 01:26:23 UTC
[GitHub] [spark] JohnHBauer opened a new pull request #31530: Added KMeansSummary to __all__ in clustering.py
JohnHBauer opened a new pull request #31530:
URL: https://github.com/apache/spark/pull/31530
KMeansSummary was undocumented.
The KMeansSummary class is present in the code, not exposed in __all__, and therefore not documented in the Sphinx build.
Adding 'KMeansSummary' to __all__ in clustering.py seems to be all that is required to fix the above. (I am not familiar enough with the documentation build process to be certain I didn't miss anything.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31530: [SPARK-34429] [ML] KMeansSummary class is omitted from PySpark documentation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31530:
URL: https://github.com/apache/spark/pull/31530#issuecomment-797194394
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40572/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31530: [SPARK-34429] [ML] KMeansSummary class is omitted from PySpark documentation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31530:
URL: https://github.com/apache/spark/pull/31530#issuecomment-775584415
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31530: Added KMeansSummary to __all__ in clustering.py
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31530:
URL: https://github.com/apache/spark/pull/31530#issuecomment-775631560
Would you mind reading http://spark.apache.org/contributing.html and keeping [the GitHub PR template](https://github.com/apache/spark/blob/master/.github/PULL_REQUEST_TEMPLATE)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] JohnHBauer commented on pull request #31530: Added KMeansSummary to __all__ in clustering.py
Posted by GitBox <gi...@apache.org>.
JohnHBauer commented on pull request #31530:
URL: https://github.com/apache/spark/pull/31530#issuecomment-778559248
What changes were proposed in this pull request?
`KMeansSummary` was added to `__all__` in the file `clustering.py`.
Does this PR introduce any user-facing change?
Yes. The documentation for KMeansSummary is now emitted by Sphinx.
How was this patch tested?
Existing tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #31530: [SPARK-34429] [ML] KMeansSummary class is omitted from PySpark documentation
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #31530:
URL: https://github.com/apache/spark/pull/31530#issuecomment-797177932
Jenkins test this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on pull request #31530: [SPARK-34429] [ML] KMeansSummary class is omitted from PySpark documentation
Posted by GitBox <gi...@apache.org>.
huaxingao commented on pull request #31530:
URL: https://github.com/apache/spark/pull/31530#issuecomment-797278327
The change is for branch-2.4 and branch-3.0, right? I remembered @srowen added this missing `KMeansSummary` in master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31530: [SPARK-34429] [ML] KMeansSummary class is omitted from PySpark documentation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31530:
URL: https://github.com/apache/spark/pull/31530#issuecomment-797208394
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135988/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] JohnHBauer removed a comment on pull request #31530: [SPARK-34429] [ML] KMeansSummary class is omitted from PySpark documentation
Posted by GitBox <gi...@apache.org>.
JohnHBauer removed a comment on pull request #31530:
URL: https://github.com/apache/spark/pull/31530#issuecomment-778563640
### What changes were proposed in this pull request?
`KMeansSummary` was added to `__all__` in the file `clustering.py`.
### Why are the changes needed?
`KMeansSummary` class is undocumented, invisible to modules which import `clustering.py`.
### Does this PR introduce any user-facing change?
Yes. The documentation for `KMeansSummary` is now emitted by Sphinx.
### How was this patch tested?
Existing tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen closed pull request #31530: [SPARK-34429] [ML] KMeansSummary class is omitted from PySpark documentation
Posted by GitBox <gi...@apache.org>.
srowen closed pull request #31530:
URL: https://github.com/apache/spark/pull/31530
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #31530: [SPARK-34429] [ML] KMeansSummary class is omitted from PySpark documentation
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #31530:
URL: https://github.com/apache/spark/pull/31530#issuecomment-797486637
Oh right, I thought this sounded familiar. Yeah I think we've got this now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31530: Added KMeansSummary to __all__ in clustering.py
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31530:
URL: https://github.com/apache/spark/pull/31530#issuecomment-775584415
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #31530: [SPARK-34429] [ML] KMeansSummary class is omitted from PySpark documentation
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on pull request #31530:
URL: https://github.com/apache/spark/pull/31530#issuecomment-782551849
@JohnHBauer you can update the PR description by re-edit the first comment:
cc @huaxingao
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] JohnHBauer commented on pull request #31530: [SPARK-34429] [ML] KMeansSummary class is omitted from PySpark documentation
Posted by GitBox <gi...@apache.org>.
JohnHBauer commented on pull request #31530:
URL: https://github.com/apache/spark/pull/31530#issuecomment-778563640
### What changes were proposed in this pull request?
`KMeansSummary` was added to `__all__` in the file `clustering.py`.
### Why are the changes needed?
`KMeansSummary` class is undocumented, invisible to modules which import `clustering.py`.
### Does this PR introduce any user-facing change?
Yes. The documentation for `KMeansSummary` is now emitted by Sphinx.
### How was this patch tested?
Existing tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31530: [SPARK-34429] [ML] KMeansSummary class is omitted from PySpark documentation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31530:
URL: https://github.com/apache/spark/pull/31530#issuecomment-797208394
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135988/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31530: Added KMeansSummary to __all__ in clustering.py
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31530:
URL: https://github.com/apache/spark/pull/31530#issuecomment-778559417
Please edit the PR description, file a JIRA and fix the PR title too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org