You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/18 05:06:00 UTC
[GitHub] [incubator-superset] rusackas opened a new pull request #10949: ignore docs on several actions, give docs its own action
rusackas opened a new pull request #10949:
URL: https://github.com/apache/incubator-superset/pull/10949
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
First time fiddling with GitHub Actions... be kind to me :)
Attempting to skip several checks for file changes within the `/docs` directory. Also adding a new action that lints/builds the docs, _only when_ files in `/docs` are changed.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
Gonna tweak a few files herein, and see how it responds.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #10949: Ignore '/docs' on some GH actions, give docs its own action
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #10949:
URL: https://github.com/apache/incubator-superset/pull/10949#discussion_r491070036
##########
File path: .github/workflows/prefer-typescript.yml
##########
@@ -2,6 +2,8 @@ name: Prefer TypeScript
on:
pull_request:
+ paths-ignore:
+ - 'docs/**'
Review comment:
Yes, but I figured we didn't want it muddying our metrics tracked with that action
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #10949: Ignore '/docs' on some GH actions, give docs its own action
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #10949:
URL: https://github.com/apache/incubator-superset/pull/10949#discussion_r491147263
##########
File path: .github/workflows/prefer-typescript.yml
##########
@@ -2,6 +2,8 @@ name: Prefer TypeScript
on:
pull_request:
+ paths-ignore:
+ - 'docs/**'
Review comment:
In any case, undid this one, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai commented on pull request #10949: Ignore '/docs' on some GH actions, give docs its own action
Posted by GitBox <gi...@apache.org>.
nytai commented on pull request #10949:
URL: https://github.com/apache/incubator-superset/pull/10949#issuecomment-701641783
@rusackas The only thing I can think of is to build the file/path checking step into the actual test code. I did something like this for the fossa check a while back, https://github.com/preset-io/incubator-superset/blob/master/.github/workflows/license-check.yml#L36
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas merged pull request #10949: Ignore '/docs' on some GH actions, give docs its own action
Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #10949:
URL: https://github.com/apache/incubator-superset/pull/10949
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] craig-rueda commented on a change in pull request #10949: Ignore '/docs' on some GH actions, give docs its own action
Posted by GitBox <gi...@apache.org>.
craig-rueda commented on a change in pull request #10949:
URL: https://github.com/apache/incubator-superset/pull/10949#discussion_r491034176
##########
File path: .github/workflows/superset-frontend.yml
##########
@@ -25,18 +31,3 @@ jobs:
working-directory: ./superset-frontend
run: |
bash <(curl -s https://codecov.io/bash) -cF javascript
-
- docs:
Review comment:
Was this even working? Looks like it was running from `./superset-frontend`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai commented on a change in pull request #10949: Ignore '/docs' on some GH actions, give docs its own action
Posted by GitBox <gi...@apache.org>.
nytai commented on a change in pull request #10949:
URL: https://github.com/apache/incubator-superset/pull/10949#discussion_r509864228
##########
File path: .github/workflows/superset-frontend.yml
##########
@@ -1,6 +1,12 @@
name: Frontend
-on: [push, pull_request]
+on:
+ push:
Review comment:
I think the main issue is that the check cannot be conditionally run _and_ required. We'd have to make all these checks not required and rely on reviewers/mergers to use their best judgement when merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas edited a comment on pull request #10949: Ignore '/docs' on some GH actions, give docs its own action
Posted by GitBox <gi...@apache.org>.
rusackas edited a comment on pull request #10949:
URL: https://github.com/apache/incubator-superset/pull/10949#issuecomment-698153975
> This change makes it so that PRs with only changes to `docs/**` can never pass CI since required checks won't run. See #11026. Can we configure this filter to pass instead of remaining in a pending state forever?
@nytai @craig-rueda @ktmud
Welp... from the docs, I don't see a way to effectively skip a test AND return a positive exit code/status. I'm open to ideas if anybody has them, but my current inclination is to revert that change, and return to unnecessarily burning time/electricity.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on pull request #10949: Ignore '/docs' on some GH actions, give docs its own action
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #10949:
URL: https://github.com/apache/incubator-superset/pull/10949#issuecomment-698153975
> This change makes it so that PRs with only changes to `docs/**` can never pass CI since required checks won't run. See #11026. Can we configure this filter to pass instead of remaining in a pending state forever?
@nytai @craig-rueda @ktmud
Welp... from the docs, I don't see a way to effectively skip a test AND return a positive error code. I'm open to ideas if anybody has them, but my current inclination is to revert that change, and return to unnecessarily burning time/electricity.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai commented on pull request #10949: Ignore '/docs' on some GH actions, give docs its own action
Posted by GitBox <gi...@apache.org>.
nytai commented on pull request #10949:
URL: https://github.com/apache/incubator-superset/pull/10949#issuecomment-697926273
This change makes it so that PRs with only changes to `docs/**` can never pass CI since required checks won't run. See https://github.com/apache/incubator-superset/pull/11026. Can we configure this filter to pass instead of remaining in a pending state always?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request #10949: Ignore '/docs' on some GH actions, give docs its own action
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #10949:
URL: https://github.com/apache/incubator-superset/pull/10949#discussion_r490729941
##########
File path: .github/workflows/prefer-typescript.yml
##########
@@ -2,6 +2,8 @@ name: Prefer TypeScript
on:
pull_request:
+ paths-ignore:
+ - 'docs/**'
Review comment:
Don't we want to prefer TypeScript in docs?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #10949: Ignore '/docs' on some GH actions, give docs its own action
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on a change in pull request #10949:
URL: https://github.com/apache/incubator-superset/pull/10949#discussion_r497974119
##########
File path: .github/workflows/superset-frontend.yml
##########
@@ -1,6 +1,12 @@
name: Frontend
-on: [push, pull_request]
+on:
+ push:
Review comment:
oh nice I didn't know you could do this! GH actions ftw!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on a change in pull request #10949: Ignore '/docs' on some GH actions, give docs its own action
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #10949:
URL: https://github.com/apache/incubator-superset/pull/10949#discussion_r491084889
##########
File path: .github/workflows/superset-frontend.yml
##########
@@ -25,18 +31,3 @@ jobs:
working-directory: ./superset-frontend
run: |
bash <(curl -s https://codecov.io/bash) -cF javascript
-
- docs:
Review comment:
Nope... but I hope it will now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request #10949: Ignore '/docs' on some GH actions, give docs its own action
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #10949:
URL: https://github.com/apache/incubator-superset/pull/10949#discussion_r490730235
##########
File path: docs/src/pages/404.jsx
##########
@@ -25,7 +25,7 @@ const NotFoundPage = () => (
<Layout>
<SEO title="404: Not found" />
<h1>NOT FOUND</h1>
- <p>You just hit a route that does not exist... the sadness.</p>
Review comment:
😢
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas edited a comment on pull request #10949: Ignore '/docs' on some GH actions, give docs its own action
Posted by GitBox <gi...@apache.org>.
rusackas edited a comment on pull request #10949:
URL: https://github.com/apache/incubator-superset/pull/10949#issuecomment-698153975
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas edited a comment on pull request #10949: Ignore '/docs' on some GH actions, give docs its own action
Posted by GitBox <gi...@apache.org>.
rusackas edited a comment on pull request #10949:
URL: https://github.com/apache/incubator-superset/pull/10949#issuecomment-698153975
> This change makes it so that PRs with only changes to `docs/**` can never pass CI since required checks won't run. See #11026. Can we configure this filter to pass instead of remaining in a pending state forever?
@nytai @craig-rueda @ktmud
Welp... from the docs, I don't see a way to effectively skip a test AND return a positive exit code/status. I'm open to ideas if anybody has them, but my current inclination is to revert that change, and return to unnecessarily burning time/electricity.
I really _want_ it to work though, since there are surely other checks that could be bypassed in numerous PR scenarios, in order to make things faster and (probably) less flake-prone.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on a change in pull request #10949: Ignore '/docs' on some GH actions, give docs its own action
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #10949:
URL: https://github.com/apache/incubator-superset/pull/10949#discussion_r508237639
##########
File path: .github/workflows/superset-frontend.yml
##########
@@ -1,6 +1,12 @@
name: Frontend
-on: [push, pull_request]
+on:
+ push:
Review comment:
My original GA implementation actually had some path ignores, but was [removed](https://github.com/apache/incubator-superset/pull/9538) out of abundance of caution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai edited a comment on pull request #10949: Ignore '/docs' on some GH actions, give docs its own action
Posted by GitBox <gi...@apache.org>.
nytai edited a comment on pull request #10949:
URL: https://github.com/apache/incubator-superset/pull/10949#issuecomment-697926273
This change makes it so that PRs with only changes to `docs/**` can never pass CI since required checks won't run. See https://github.com/apache/incubator-superset/pull/11026. Can we configure this filter to pass instead of remaining in a pending state forever?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on pull request #10949: Ignore '/docs' on some GH actions, give docs its own action
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #10949:
URL: https://github.com/apache/incubator-superset/pull/10949#issuecomment-698153975
> This change makes it so that PRs with only changes to `docs/**` can never pass CI since required checks won't run. See #11026. Can we configure this filter to pass instead of remaining in a pending state forever?
@nytai @craig-rueda @ktmud
Welp... from the docs, I don't see a way to effectively skip a test AND return a positive error code. I'm open to ideas if anybody has them, but my current inclination is to revert that change, and return to unnecessarily burning time/electricity.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org