You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Sami Dalouche (JIRA)" <ji...@apache.org> on 2008/02/16 13:08:39 UTC
[jira] Created: (WW-2493) XHTML compliance errors in CSS_XHTML
theme
XHTML compliance errors in CSS_XHTML theme
------------------------------------------
Key: WW-2493
URL: https://issues.apache.org/struts/browse/WW-2493
Project: Struts 2
Issue Type: Bug
Affects Versions: 2.1.0
Reporter: Sami Dalouche
1] @s.form uses non standard HTML attributes
<form id="x" name="formName" onsubmit="return true;" action="actionName">...
=> action and name are not standard HTML attributes
2] Also, @s.submit always defaults to adding a "align=" attribute, which is not XHTML compliant.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2493) XHTML compliance errors in CSS_XHTML
theme
Posted by "marco.tombesi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=44587#action_44587 ]
marco.tombesi commented on WW-2493:
-----------------------------------
I ask for the BUG priority escalation, since It's a VERY disappointing problem in case of web accessibility concerns..
we have to develop a valid WAI interface using theme and templates so we need that these features are working
NOTE:
in XHTML Strict
the align attribute is INVALID
the form name attribute is INVALID...
> XHTML compliance errors in CSS_XHTML theme
> ------------------------------------------
>
> Key: WW-2493
> URL: https://issues.apache.org/struts/browse/WW-2493
> Project: Struts 2
> Issue Type: Bug
> Affects Versions: 2.1.0
> Reporter: Sami Dalouche
> Priority: Minor
> Fix For: Future
>
>
> 1] @s.form uses non standard HTML attributes
> <form id="x" name="formName" onsubmit="return true;" action="actionName">...
> => action and name are not standard HTML attributes
> 2] Also, @s.submit always defaults to adding a "align=" attribute, which is not XHTML compliant.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WW-2493) XHTML compliance errors in CSS_XHTML
theme
Posted by "Don Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Don Brown updated WW-2493:
--------------------------
Priority: Minor (was: Major)
Fix Version/s: Future
> XHTML compliance errors in CSS_XHTML theme
> ------------------------------------------
>
> Key: WW-2493
> URL: https://issues.apache.org/struts/browse/WW-2493
> Project: Struts 2
> Issue Type: Bug
> Affects Versions: 2.1.0
> Reporter: Sami Dalouche
> Priority: Minor
> Fix For: Future
>
>
> 1] @s.form uses non standard HTML attributes
> <form id="x" name="formName" onsubmit="return true;" action="actionName">...
> => action and name are not standard HTML attributes
> 2] Also, @s.submit always defaults to adding a "align=" attribute, which is not XHTML compliant.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2493) XHTML compliance errors in CSS_XHTML
theme
Posted by "Jeromy Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43252#action_43252 ]
Jeromy Evans commented on WW-2493:
----------------------------------
1) Which standard are you referring to?
action is a REQUIRED attribute in HTML4
name is an IMPLIED attribute in HTML4
http://www.w3.org/TR/html4/interact/forms.html#h-17.3
2) Which theme is the align="" attribute occurring in?
It's not present in the simple theme and appears to be conditional in css_xhtml and xhtml.
<#if parameters.align?exists>
align="${parameters.align?html}"<#t/>
</#if>
> XHTML compliance errors in CSS_XHTML theme
> ------------------------------------------
>
> Key: WW-2493
> URL: https://issues.apache.org/struts/browse/WW-2493
> Project: Struts 2
> Issue Type: Bug
> Affects Versions: 2.1.0
> Reporter: Sami Dalouche
>
> 1] @s.form uses non standard HTML attributes
> <form id="x" name="formName" onsubmit="return true;" action="actionName">...
> => action and name are not standard HTML attributes
> 2] Also, @s.submit always defaults to adding a "align=" attribute, which is not XHTML compliant.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2493) XHTML compliance errors in CSS_XHTML
theme
Posted by "Sami Dalouche (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43260#action_43260 ]
Sami Dalouche commented on WW-2493:
-----------------------------------
1] I am referring to the XHTML standard.
It looks like name has been deprecated in XHTML.
http://www.w3.org/TR/xhtml1/#h-4.10
> Note that in XHTML 1.0, the name attribute of these elements is formally deprecated, and will be removed in a subsequent version of XHTML.
Concerning the "action" attribute, I was just plain wrong. this is definitely required, and I don't even see how the form could work without that anyways ;)
2] on my setup, with struts 2.1.0 a simple call like :
<@s.submit
theme="css_xhtml"
value="Submit" />
generates the following code :
<div align="right" id="wwctrl_actionName">
<input type="submit" id="actionName_2_0" value="Submit" />
</div>
and yes, I do see the condition in the FTL template.
<#if parameters.align?exists>
align="${parameters.align?html}"<#t/>
</#if>
However, it does print the div align="right", so I guess this must come from the Java code that would set a default value
> XHTML compliance errors in CSS_XHTML theme
> ------------------------------------------
>
> Key: WW-2493
> URL: https://issues.apache.org/struts/browse/WW-2493
> Project: Struts 2
> Issue Type: Bug
> Affects Versions: 2.1.0
> Reporter: Sami Dalouche
>
> 1] @s.form uses non standard HTML attributes
> <form id="x" name="formName" onsubmit="return true;" action="actionName">...
> => action and name are not standard HTML attributes
> 2] Also, @s.submit always defaults to adding a "align=" attribute, which is not XHTML compliant.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.