[GitHub] [incubator-druid] asdf2014 commented on a change in pull request #8775: Fix NPE for subquery with limit

[GitBox <gi...@apache.org>]

asdf2014 commented on a change in pull request #8775: Fix NPE for subquery with limit
URL: https://github.com/apache/incubator-druid/pull/8775#discussion_r341477618
 
 

 ##########
 File path: sql/src/test/java/org/apache/druid/sql/calcite/http/SqlResourceTest.java
 ##########
 @@ -671,6 +671,46 @@ public void testResourceLimitExceeded() throws Exception
     checkSqlRequestLog(false);
   }
 
+  @Test
+  public void testSubQueryWithLimit() throws Exception
+  {
+    final List<Map<String, Object>> rows = doPost(
+        new SqlQuery(
+            "SELECT COUNT(*) AS cnt FROM ( SELECT * FROM ( SELECT * FROM druid.foo LIMIT 10 ) tmpA ) tmpB",
+            null,
+            false,
+            null
+        )
+    ).rhs;
+
+    Assert.assertEquals(
+        ImmutableList.of(),
+        rows
+    );
+    checkSqlRequestLog(true);
+  }
+
+  @Test
+  public void testSubQueryWithoutLimit() throws Exception
 
 Review comment:
   Good Suggestion :+1:

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org