You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "rajan123456 (via GitHub)" <gi...@apache.org> on 2023/02/06 01:52:40 UTC

[GitHub] [superset] rajan123456 opened a new pull request, #22713: feat(helm): allow persisting nodePort for services

rajan123456 opened a new pull request, #22713:
URL: https://github.com/apache/superset/pull/22713

   <!---
   Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   This PR allows persisting of port mappings for NodePort if service type being used in the helm chart is NodePort or LoadBalancer. Without this feature, each installation of the chart causes a change to the NodePort being used by the services which expose the application.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   Deploy the helm chart with following values.yaml changes:
   service.type: NodePort and service.nodePorts.http: "XXXXX" for service, 
   serivce.type: NodePort and service.nodePorts.http: "XXXXX" for supersetCeleryFlower and
   service.type: NodePort and service.nodePorts.http: "XXXXX" for supersetWebsockets
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] EugeneTorap commented on pull request #22713: feat(helm): allow persisting nodePort for services

Posted by "EugeneTorap (via GitHub)" <gi...@apache.org>.
EugeneTorap commented on PR #22713:
URL: https://github.com/apache/superset/pull/22713#issuecomment-1426011105

   @rajan123456 `helm-docs` is failing. Pls, fix it. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] craig-rueda commented on a diff in pull request #22713: feat(helm): allow persisting nodePort for services

Posted by GitBox <gi...@apache.org>.
craig-rueda commented on code in PR #22713:
URL: https://github.com/apache/superset/pull/22713#discussion_r1069689973


##########
helm/superset/README.md:
##########
@@ -144,6 +145,7 @@ helm install my-superset superset/superset
 | supersetCeleryFlower.service.annotations | object | `{}` |  |
 | supersetCeleryFlower.service.port | int | `5555` |  |
 | supersetCeleryFlower.service.type | string | `"ClusterIP"` |  |
+| supersetCeleryFlowerservice.nodePorts.http | int | `""` |  |

Review Comment:
   Were these added manually? Pls re-generate this file using `helm-docs`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] EugeneTorap commented on a diff in pull request #22713: feat(helm): allow persisting nodePort for services

Posted by "EugeneTorap (via GitHub)" <gi...@apache.org>.
EugeneTorap commented on code in PR #22713:
URL: https://github.com/apache/superset/pull/22713#discussion_r1103789844


##########
helm/superset/README.md:
##########
@@ -23,7 +23,9 @@ NOTE: This file is generated by helm-docs: https://github.com/norwoodj/helm-docs
 
 # superset
 
-![Version: 0.8.5](https://img.shields.io/badge/Version-0.8.5-informational?style=flat-square)
+
+

Review Comment:
   Hi @rajan123456! Remove these 2 empty line and I guess `helm-docs` will be fixed!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] craig-rueda commented on a diff in pull request #22713: feat(helm): allow persisting nodePort for services

Posted by "craig-rueda (via GitHub)" <gi...@apache.org>.
craig-rueda commented on code in PR #22713:
URL: https://github.com/apache/superset/pull/22713#discussion_r1092245837


##########
helm/superset/Chart.yaml:
##########
@@ -29,7 +29,7 @@ maintainers:
   - name: craig-rueda
     email: craig@craigrueda.com
     url: https://github.com/craig-rueda
-version: 0.8.4
+version: 0.8.5

Review Comment:
   Pls bump this to `0.8.6` as this PR is likely to collide: #22854



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] rajan123456 commented on a diff in pull request #22713: feat(helm): allow persisting nodePort for services

Posted by "rajan123456 (via GitHub)" <gi...@apache.org>.
rajan123456 commented on code in PR #22713:
URL: https://github.com/apache/superset/pull/22713#discussion_r1104020398


##########
helm/superset/README.md:
##########
@@ -23,7 +23,9 @@ NOTE: This file is generated by helm-docs: https://github.com/norwoodj/helm-docs
 
 # superset
 
-![Version: 0.8.5](https://img.shields.io/badge/Version-0.8.5-informational?style=flat-square)
+
+

Review Comment:
   Thanks. On my system, regenerating the helm-docs automatically adds these lines back, not sure why. I removed them manually and pushed it again. Hope CI is ok now. Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] rajan123456 closed pull request #22713: feat(helm): allow persisting nodePort for services

Posted by "rajan123456 (via GitHub)" <gi...@apache.org>.
rajan123456 closed pull request #22713: feat(helm): allow persisting nodePort for services
URL: https://github.com/apache/superset/pull/22713


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] EugeneTorap commented on pull request #22713: feat(helm): allow persisting nodePort for services

Posted by "EugeneTorap (via GitHub)" <gi...@apache.org>.
EugeneTorap commented on PR #22713:
URL: https://github.com/apache/superset/pull/22713#issuecomment-1423718000

   @dpgaspar @villebro Can you approve CI?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] craig-rueda commented on a diff in pull request #22713: feat(helm): allow persisting nodePort for services

Posted by GitBox <gi...@apache.org>.
craig-rueda commented on code in PR #22713:
URL: https://github.com/apache/superset/pull/22713#discussion_r1069694313


##########
helm/superset/templates/service.yaml:
##########
@@ -64,6 +69,11 @@ spec:
       targetPort: flower
       protocol: TCP
       name: flower
+      {{- if and (or (eq .Values.supersetCeleryFlower.service.type "NodePort") (eq .Values.supersetCeleryFlower.service.type "LoadBalancer")) (not (empty .Values.supersetCeleryFlower.service.nodePorts.http)) }}
+      nodePort: {{ .Values.supersetCeleryFlower.service.nodePorts.http }}
+      {{- else if eq .Values.supersetCeleryFlower.service.type "ClusterIP" }}
+      nodePort: null

Review Comment:
   Same comment as above



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] craig-rueda commented on a diff in pull request #22713: feat(helm): allow persisting nodePort for services

Posted by GitBox <gi...@apache.org>.
craig-rueda commented on code in PR #22713:
URL: https://github.com/apache/superset/pull/22713#discussion_r1069693604


##########
helm/superset/templates/service.yaml:
##########
@@ -35,6 +35,11 @@ spec:
       targetPort: http
       protocol: TCP
       name: http
+      {{- if and (or (eq .Values.service.type "NodePort") (eq .Values.service.type "LoadBalancer")) (not (empty .Values.service.nodePorts.http)) }}
+      nodePort: {{ .Values.service.nodePorts.http }}
+      {{- else if eq .Values.service.type "ClusterIP" }}
+      nodePort: null

Review Comment:
   Can we just omit the `else`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] rajan123456 commented on a diff in pull request #22713: feat(helm): allow persisting nodePort for services

Posted by GitBox <gi...@apache.org>.
rajan123456 commented on code in PR #22713:
URL: https://github.com/apache/superset/pull/22713#discussion_r1070504784


##########
helm/superset/README.md:
##########
@@ -144,6 +145,7 @@ helm install my-superset superset/superset
 | supersetCeleryFlower.service.annotations | object | `{}` |  |
 | supersetCeleryFlower.service.port | int | `5555` |  |
 | supersetCeleryFlower.service.type | string | `"ClusterIP"` |  |
+| supersetCeleryFlowerservice.nodePorts.http | int | `""` |  |

Review Comment:
   Updated, thanks!



##########
helm/superset/templates/service.yaml:
##########
@@ -35,6 +35,11 @@ spec:
       targetPort: http
       protocol: TCP
       name: http
+      {{- if and (or (eq .Values.service.type "NodePort") (eq .Values.service.type "LoadBalancer")) (not (empty .Values.service.nodePorts.http)) }}
+      nodePort: {{ .Values.service.nodePorts.http }}
+      {{- else if eq .Values.service.type "ClusterIP" }}
+      nodePort: null

Review Comment:
   Updated, thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] rajan123456 commented on pull request #22713: feat(helm): allow persisting nodePort for services

Posted by "rajan123456 (via GitHub)" <gi...@apache.org>.
rajan123456 commented on PR #22713:
URL: https://github.com/apache/superset/pull/22713#issuecomment-1409635616

   Hi @craig-rueda - could you please help to check the helm-docs issue? I have already generated helm-docs but I am not sure why the CI job is still failing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] craig-rueda commented on a diff in pull request #22713: feat(helm): allow persisting nodePort for services

Posted by GitBox <gi...@apache.org>.
craig-rueda commented on code in PR #22713:
URL: https://github.com/apache/superset/pull/22713#discussion_r1072552254


##########
helm/superset/values.yaml:
##########
@@ -200,6 +200,8 @@ service:
     {}
     # cloud.google.com/load-balancer-type: "Internal"
   loadBalancerIP: null
+  nodePort:
+    http: ""

Review Comment:
   These should be `nil` by default



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] EugeneTorap commented on a diff in pull request #22713: feat(helm): allow persisting nodePort for services

Posted by "EugeneTorap (via GitHub)" <gi...@apache.org>.
EugeneTorap commented on code in PR #22713:
URL: https://github.com/apache/superset/pull/22713#discussion_r1104105064


##########
helm/superset/README.md:
##########
@@ -23,7 +23,7 @@ NOTE: This file is generated by helm-docs: https://github.com/norwoodj/helm-docs
 
 # superset
 
-![Version: 0.8.5](https://img.shields.io/badge/Version-0.8.5-informational?style=flat-square)
+![Version: 0.8.6](https://img.shields.io/badge/Version-0.8.6-informational?style=flat-square) 

Review Comment:
   @rajan123456 trailing-whitespace is failing. Pls, remove the last whitespace for this line.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] rajan123456 commented on a diff in pull request #22713: feat(helm): allow persisting nodePort for services

Posted by "rajan123456 (via GitHub)" <gi...@apache.org>.
rajan123456 commented on code in PR #22713:
URL: https://github.com/apache/superset/pull/22713#discussion_r1096875625


##########
helm/superset/README.md:
##########
@@ -142,6 +145,7 @@ helm install my-superset superset/superset
 | supersetCeleryFlower.replicaCount | int | `1` |  |
 | supersetCeleryFlower.resources | object | `{}` | Resource settings for the CeleryBeat pods - these settings overwrite might existing values from the global resources object defined above. |
 | supersetCeleryFlower.service.annotations | object | `{}` |  |
+| supersetCeleryFlower.service.nodePort.http | string | `""` |  |

Review Comment:
   Done, thanks!



##########
helm/superset/values.yaml:
##########
@@ -200,6 +200,8 @@ service:
     {}
     # cloud.google.com/load-balancer-type: "Internal"
   loadBalancerIP: null
+  nodePort:
+    http: ""

Review Comment:
   Done, thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] rajan123456 commented on a diff in pull request #22713: feat(helm): allow persisting nodePort for services

Posted by GitBox <gi...@apache.org>.
rajan123456 commented on code in PR #22713:
URL: https://github.com/apache/superset/pull/22713#discussion_r1070504792


##########
helm/superset/templates/service.yaml:
##########
@@ -64,6 +69,11 @@ spec:
       targetPort: flower
       protocol: TCP
       name: flower
+      {{- if and (or (eq .Values.supersetCeleryFlower.service.type "NodePort") (eq .Values.supersetCeleryFlower.service.type "LoadBalancer")) (not (empty .Values.supersetCeleryFlower.service.nodePorts.http)) }}
+      nodePort: {{ .Values.supersetCeleryFlower.service.nodePorts.http }}
+      {{- else if eq .Values.supersetCeleryFlower.service.type "ClusterIP" }}
+      nodePort: null

Review Comment:
   Updated, thanks!



##########
helm/superset/values.yaml:
##########
@@ -200,6 +200,8 @@ service:
     {}
     # cloud.google.com/load-balancer-type: "Internal"
   loadBalancerIP: null
+  nodePorts:

Review Comment:
   Updated, thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] EugeneTorap commented on a diff in pull request #22713: feat(helm): allow persisting nodePort for services

Posted by "EugeneTorap (via GitHub)" <gi...@apache.org>.
EugeneTorap commented on code in PR #22713:
URL: https://github.com/apache/superset/pull/22713#discussion_r1103789844


##########
helm/superset/README.md:
##########
@@ -23,7 +23,9 @@ NOTE: This file is generated by helm-docs: https://github.com/norwoodj/helm-docs
 
 # superset
 
-![Version: 0.8.5](https://img.shields.io/badge/Version-0.8.5-informational?style=flat-square)
+
+

Review Comment:
   Hi @rajan123456! Remove these 2 line and I guess `helm-docs` will be fixed!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] craig-rueda commented on pull request #22713: feat(helm): allow persisting nodePort for services

Posted by "craig-rueda (via GitHub)" <gi...@apache.org>.
craig-rueda commented on PR #22713:
URL: https://github.com/apache/superset/pull/22713#issuecomment-1410741802

   Pls rebase from `master` as this fix should get things working again: https://github.com/apache/superset/pull/22907


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] craig-rueda commented on pull request #22713: feat(helm): allow persisting nodePort for services

Posted by GitBox <gi...@apache.org>.
craig-rueda commented on PR #22713:
URL: https://github.com/apache/superset/pull/22713#issuecomment-1387420533

   `helm-docs` is failing. Please re-gen `charts/superset/README.md`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] craig-rueda commented on a diff in pull request #22713: feat(helm): allow persisting nodePort for services

Posted by GitBox <gi...@apache.org>.
craig-rueda commented on code in PR #22713:
URL: https://github.com/apache/superset/pull/22713#discussion_r1072553265


##########
helm/superset/README.md:
##########
@@ -142,6 +145,7 @@ helm install my-superset superset/superset
 | supersetCeleryFlower.replicaCount | int | `1` |  |
 | supersetCeleryFlower.resources | object | `{}` | Resource settings for the CeleryBeat pods - these settings overwrite might existing values from the global resources object defined above. |
 | supersetCeleryFlower.service.annotations | object | `{}` |  |
+| supersetCeleryFlower.service.nodePort.http | string | `""` |  |

Review Comment:
   The type of nodePort should be `int` with a default of `nil`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] rajan123456 closed pull request #22713: feat(helm): allow persisting nodePort for services

Posted by "rajan123456 (via GitHub)" <gi...@apache.org>.
rajan123456 closed pull request #22713: feat(helm): allow persisting nodePort for services
URL: https://github.com/apache/superset/pull/22713


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] rajan123456 commented on a diff in pull request #22713: feat(helm): allow persisting nodePort for services

Posted by "rajan123456 (via GitHub)" <gi...@apache.org>.
rajan123456 commented on code in PR #22713:
URL: https://github.com/apache/superset/pull/22713#discussion_r1104109962


##########
helm/superset/README.md:
##########
@@ -23,7 +23,7 @@ NOTE: This file is generated by helm-docs: https://github.com/norwoodj/helm-docs
 
 # superset
 
-![Version: 0.8.5](https://img.shields.io/badge/Version-0.8.5-informational?style=flat-square)
+![Version: 0.8.6](https://img.shields.io/badge/Version-0.8.6-informational?style=flat-square) 

Review Comment:
   Updated. Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] rajan123456 commented on a diff in pull request #22713: feat(helm): allow persisting nodePort for services

Posted by "rajan123456 (via GitHub)" <gi...@apache.org>.
rajan123456 commented on code in PR #22713:
URL: https://github.com/apache/superset/pull/22713#discussion_r1096875538


##########
helm/superset/Chart.yaml:
##########
@@ -29,7 +29,7 @@ maintainers:
   - name: craig-rueda
     email: craig@craigrueda.com
     url: https://github.com/craig-rueda
-version: 0.8.4
+version: 0.8.5

Review Comment:
   Done, thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] craig-rueda commented on a diff in pull request #22713: feat(helm): allow persisting nodePort for services

Posted by GitBox <gi...@apache.org>.
craig-rueda commented on code in PR #22713:
URL: https://github.com/apache/superset/pull/22713#discussion_r1069696654


##########
helm/superset/values.yaml:
##########
@@ -200,6 +200,8 @@ service:
     {}
     # cloud.google.com/load-balancer-type: "Internal"
   loadBalancerIP: null
+  nodePorts:

Review Comment:
   Since the `service.port` is already singular, let's just make this `nodePort`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] craig-rueda commented on pull request #22713: feat(helm): allow persisting nodePort for services

Posted by GitBox <gi...@apache.org>.
craig-rueda commented on PR #22713:
URL: https://github.com/apache/superset/pull/22713#issuecomment-1385791118

   One more quick change and then LGTM :) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] craig-rueda merged pull request #22713: feat(helm): allow persisting nodePort for services

Posted by "craig-rueda (via GitHub)" <gi...@apache.org>.
craig-rueda merged PR #22713:
URL: https://github.com/apache/superset/pull/22713


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org