You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2025/07/22 09:37:47 UTC

[Impala-ASF-CR] IMPALA-14059: deflake test hms event sync timeout

Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23207


Change subject: IMPALA-14059: deflake test_hms_event_sync_timeout
......................................................................

IMPALA-14059: deflake test_hms_event_sync_timeout

test_hms_event_sync_timeout adds a sleep in events processing and runs a
SELECT in Impala after an INSERT in Hive. The Impala SELECT statement is
submitted with sync_hms_events_wait_time_s=2 and it's expected that
changes done in Hive haven't been applied in catalogd yet. However, the
changes is applied by a single event (ADD_PARTITION) and the event
processing delay is just 2s which is not longer enough. Sometimes the
event is applied just before the waitForHmsEvent request times out. So
the query still sees the latest results and fails the test.

This increases the event processing delay to 4s to deflake the test.

Change-Id: I91e9cbf234360446422259e274161a01a43ea3d9
---
M tests/custom_cluster/test_events_custom_configs.py
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/07/23207/1
-- 
To view, visit http://gerrit.cloudera.org:8080/23207
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I91e9cbf234360446422259e274161a01a43ea3d9
Gerrit-Change-Number: 23207
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-14059: deflake test hms event sync timeout

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23207 )

Change subject: IMPALA-14059: deflake test_hms_event_sync_timeout
......................................................................


Patch Set 1:

Thanks for the quick review!


-- 
To view, visit http://gerrit.cloudera.org:8080/23207
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91e9cbf234360446422259e274161a01a43ea3d9
Gerrit-Change-Number: 23207
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 22 Jul 2025 11:37:44 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14059: deflake test hms event sync timeout

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23207 )

Change subject: IMPALA-14059: deflake test_hms_event_sync_timeout
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/19938/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/23207
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91e9cbf234360446422259e274161a01a43ea3d9
Gerrit-Change-Number: 23207
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 22 Jul 2025 10:04:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14059: deflake test hms event sync timeout

Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/23207 )

Change subject: IMPALA-14059: deflake test_hms_event_sync_timeout
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/23207
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91e9cbf234360446422259e274161a01a43ea3d9
Gerrit-Change-Number: 23207
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 22 Jul 2025 10:59:52 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14059: deflake test hms event sync timeout

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23207 )

Change subject: IMPALA-14059: deflake test_hms_event_sync_timeout
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12219/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/23207
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91e9cbf234360446422259e274161a01a43ea3d9
Gerrit-Change-Number: 23207
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 22 Jul 2025 11:37:52 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14059: deflake test hms event sync timeout

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23207 )

Change subject: IMPALA-14059: deflake test_hms_event_sync_timeout
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/23207
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91e9cbf234360446422259e274161a01a43ea3d9
Gerrit-Change-Number: 23207
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 22 Jul 2025 17:45:30 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14059: deflake test hms event sync timeout

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23207 )

Change subject: IMPALA-14059: deflake test_hms_event_sync_timeout
......................................................................

IMPALA-14059: deflake test_hms_event_sync_timeout

test_hms_event_sync_timeout adds a sleep in events processing and runs a
SELECT in Impala after an INSERT in Hive. The Impala SELECT statement is
submitted with sync_hms_events_wait_time_s=2 and it's expected that
changes done in Hive haven't been applied in catalogd yet. However, the
changes is applied by a single event (ADD_PARTITION) and the event
processing delay is just 2s which is not longer enough. Sometimes the
event is applied just before the waitForHmsEvent request times out. So
the query still sees the latest results and fails the test.

This increases the event processing delay to 4s to deflake the test.

Change-Id: I91e9cbf234360446422259e274161a01a43ea3d9
Reviewed-on: http://gerrit.cloudera.org:8080/23207
Reviewed-by: Daniel Becker <da...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/custom_cluster/test_events_custom_configs.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Daniel Becker: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/23207
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I91e9cbf234360446422259e274161a01a43ea3d9
Gerrit-Change-Number: 23207
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>