You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/02/26 00:47:46 UTC

[GitHub] [incubator-dolphinscheduler] CalvinKirs commented on a change in pull request #4879: [Feature][server] Add support for multi sql queries

CalvinKirs commented on a change in pull request #4879:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4879#discussion_r583306598



##########
File path: dolphinscheduler-server/pom.xml
##########
@@ -143,6 +162,12 @@
             <groupId>org.springframework</groupId>
             <artifactId>spring-test</artifactId>
         </dependency>
+
+        <dependency>
+            <groupId>org.ohdsi.sql</groupId>
+            <artifactId>SqlRender</artifactId>
+            <version>1.7.0-SNAPSHOT</version>

Review comment:
       Very cool, but I noticed that you have introduced a new license. License is a more important issue. You can follow this document to proceed https://dolphinscheduler.apache.org/en-us/community/development/DS-License .html review.
   
   btw, don't use the snap package




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org