You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by "Avery Ching (JIRA)" <ji...@apache.org> on 2012/09/24 10:34:07 UTC
[jira] [Created] (GIRAPH-340) Added client/server ExecutionHandlers
to Netty to avoid and added
WrappedAdaptiveReceiveBufferSizePredictorFactory to debug/predict the size
of the incoming messages
Avery Ching created GIRAPH-340:
----------------------------------
Summary: Added client/server ExecutionHandlers to Netty to avoid and added WrappedAdaptiveReceiveBufferSizePredictorFactory to debug/predict the size of the incoming messages
Key: GIRAPH-340
URL: https://issues.apache.org/jira/browse/GIRAPH-340
Project: Giraph
Issue Type: Sub-task
Reporter: Avery Ching
- Added client and server ExecutionHandlers to Netty to avoid doing the business logic with I/O threads (This used to clog up the pipe)
- Added WrappedAdaptiveReceiveBufferSizePredictorFactory to debug/predict the size of the incoming messages and provide better performance tuning on the server instead of receiving a bunch of small messages.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-340) Added client/server ExecutionHandlers
to Netty to avoid and added
WrappedAdaptiveReceiveBufferSizePredictorFactory to debug/predict the size
of the incoming messages
Posted by "Avery Ching (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Avery Ching updated GIRAPH-340:
-------------------------------
Attachment: GIRAPH-340.2.patch
Updated per GIRAPH-337 changes.
> Added client/server ExecutionHandlers to Netty to avoid and added WrappedAdaptiveReceiveBufferSizePredictorFactory to debug/predict the size of the incoming messages
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: GIRAPH-340
> URL: https://issues.apache.org/jira/browse/GIRAPH-340
> Project: Giraph
> Issue Type: Sub-task
> Reporter: Avery Ching
> Assignee: Avery Ching
> Attachments: GIRAPH-340.2.patch, GIRAPH-340.patch
>
>
> - Added client and server ExecutionHandlers to Netty to avoid doing the business logic with I/O threads (This used to clog up the pipe)
> - Added WrappedAdaptiveReceiveBufferSizePredictorFactory to debug/predict the size of the incoming messages and provide better performance tuning on the server instead of receiving a bunch of small messages.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-340) Added client/server
ExecutionHandlers to Netty to avoid and added
WrappedAdaptiveReceiveBufferSizePredictorFactory to debug/predict the size
of the incoming messages
Posted by "Eli Reisman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463872#comment-13463872 ]
Eli Reisman commented on GIRAPH-340:
------------------------------------
This looks great, but I'm having trouble patching it into trunk. Might need to be rebased?
> Added client/server ExecutionHandlers to Netty to avoid and added WrappedAdaptiveReceiveBufferSizePredictorFactory to debug/predict the size of the incoming messages
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: GIRAPH-340
> URL: https://issues.apache.org/jira/browse/GIRAPH-340
> Project: Giraph
> Issue Type: Sub-task
> Reporter: Avery Ching
> Assignee: Avery Ching
> Attachments: GIRAPH-340.2.patch, GIRAPH-340.patch
>
>
> - Added client and server ExecutionHandlers to Netty to avoid doing the business logic with I/O threads (This used to clog up the pipe)
> - Added WrappedAdaptiveReceiveBufferSizePredictorFactory to debug/predict the size of the incoming messages and provide better performance tuning on the server instead of receiving a bunch of small messages.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-340) Added client/server ExecutionHandlers
to Netty to avoid and added
WrappedAdaptiveReceiveBufferSizePredictorFactory to debug/predict the size
of the incoming messages
Posted by "Avery Ching (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Avery Ching updated GIRAPH-340:
-------------------------------
Attachment: GIRAPH-340.patch
Must be applied after GIRAPH-339, ready to go!
> Added client/server ExecutionHandlers to Netty to avoid and added WrappedAdaptiveReceiveBufferSizePredictorFactory to debug/predict the size of the incoming messages
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: GIRAPH-340
> URL: https://issues.apache.org/jira/browse/GIRAPH-340
> Project: Giraph
> Issue Type: Sub-task
> Reporter: Avery Ching
> Attachments: GIRAPH-340.patch
>
>
> - Added client and server ExecutionHandlers to Netty to avoid doing the business logic with I/O threads (This used to clog up the pipe)
> - Added WrappedAdaptiveReceiveBufferSizePredictorFactory to debug/predict the size of the incoming messages and provide better performance tuning on the server instead of receiving a bunch of small messages.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-340) Added client/server
ExecutionHandlers to Netty to avoid and added
WrappedAdaptiveReceiveBufferSizePredictorFactory to debug/predict the size
of the incoming messages
Posted by "Alessandro Presta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464112#comment-13464112 ]
Alessandro Presta commented on GIRAPH-340:
------------------------------------------
Ok, +1 for me.
> Added client/server ExecutionHandlers to Netty to avoid and added WrappedAdaptiveReceiveBufferSizePredictorFactory to debug/predict the size of the incoming messages
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: GIRAPH-340
> URL: https://issues.apache.org/jira/browse/GIRAPH-340
> Project: Giraph
> Issue Type: Sub-task
> Reporter: Avery Ching
> Assignee: Avery Ching
> Attachments: GIRAPH-340.2.patch, GIRAPH-340.3.patch, GIRAPH-340.patch
>
>
> - Added client and server ExecutionHandlers to Netty to avoid doing the business logic with I/O threads (This used to clog up the pipe)
> - Added WrappedAdaptiveReceiveBufferSizePredictorFactory to debug/predict the size of the incoming messages and provide better performance tuning on the server instead of receiving a bunch of small messages.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-340) Added client/server
ExecutionHandlers to Netty to avoid and added
WrappedAdaptiveReceiveBufferSizePredictorFactory to debug/predict the size
of the incoming messages
Posted by "Avery Ching (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463055#comment-13463055 ]
Avery Ching commented on GIRAPH-340:
------------------------------------
Can someone take a quick look at this? It's not very long, but is an important Netty improvement.
> Added client/server ExecutionHandlers to Netty to avoid and added WrappedAdaptiveReceiveBufferSizePredictorFactory to debug/predict the size of the incoming messages
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: GIRAPH-340
> URL: https://issues.apache.org/jira/browse/GIRAPH-340
> Project: Giraph
> Issue Type: Sub-task
> Reporter: Avery Ching
> Assignee: Avery Ching
> Attachments: GIRAPH-340.2.patch, GIRAPH-340.patch
>
>
> - Added client and server ExecutionHandlers to Netty to avoid doing the business logic with I/O threads (This used to clog up the pipe)
> - Added WrappedAdaptiveReceiveBufferSizePredictorFactory to debug/predict the size of the incoming messages and provide better performance tuning on the server instead of receiving a bunch of small messages.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-340) Added client/server
ExecutionHandlers to Netty to avoid and added
WrappedAdaptiveReceiveBufferSizePredictorFactory to debug/predict the size
of the incoming messages
Posted by "Alessandro Presta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463738#comment-13463738 ]
Alessandro Presta commented on GIRAPH-340:
------------------------------------------
I'm not that familiar with Netty, but if benchmarks show this is a winner I'm all for it.
Predicting the buffer size sounds good. The reason you had to wrap it is only to add some logging, right?
This javadoc is incomplete: "Uses composition to learn more about what AdaptiveReceive".
> Added client/server ExecutionHandlers to Netty to avoid and added WrappedAdaptiveReceiveBufferSizePredictorFactory to debug/predict the size of the incoming messages
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: GIRAPH-340
> URL: https://issues.apache.org/jira/browse/GIRAPH-340
> Project: Giraph
> Issue Type: Sub-task
> Reporter: Avery Ching
> Assignee: Avery Ching
> Attachments: GIRAPH-340.2.patch, GIRAPH-340.patch
>
>
> - Added client and server ExecutionHandlers to Netty to avoid doing the business logic with I/O threads (This used to clog up the pipe)
> - Added WrappedAdaptiveReceiveBufferSizePredictorFactory to debug/predict the size of the incoming messages and provide better performance tuning on the server instead of receiving a bunch of small messages.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-340) Added client/server
ExecutionHandlers to Netty to avoid and added
WrappedAdaptiveReceiveBufferSizePredictorFactory to debug/predict the size
of the incoming messages
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464159#comment-13464159 ]
Hudson commented on GIRAPH-340:
-------------------------------
Integrated in Giraph-trunk-Commit #208 (See [https://builds.apache.org/job/Giraph-trunk-Commit/208/])
Forgot changelog entry for GIRAPH-340. (Revision 1390711)
GIRAPH-340: Added client/server ExecutionHandlers to Netty to avoid
and added WrappedAdaptiveReceiveBufferSizePredictorFactory to
debug/predict the size of the incoming messages. (Revision 1390709)
Result = SUCCESS
aching : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1390711
Files :
* /giraph/trunk/CHANGELOG
aching : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1390709
Files :
* /giraph/trunk/src/main/java/org/apache/giraph/comm/netty/NettyClient.java
* /giraph/trunk/src/main/java/org/apache/giraph/comm/netty/NettyServer.java
* /giraph/trunk/src/main/java/org/apache/giraph/comm/netty/WrappedAdaptiveReceiveBufferSizePredictorFactory.java
* /giraph/trunk/src/main/java/org/apache/giraph/comm/netty/handler/RequestEncoder.java
> Added client/server ExecutionHandlers to Netty to avoid and added WrappedAdaptiveReceiveBufferSizePredictorFactory to debug/predict the size of the incoming messages
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: GIRAPH-340
> URL: https://issues.apache.org/jira/browse/GIRAPH-340
> Project: Giraph
> Issue Type: Sub-task
> Reporter: Avery Ching
> Assignee: Avery Ching
> Attachments: GIRAPH-340.2.patch, GIRAPH-340.3.patch, GIRAPH-340.patch
>
>
> - Added client and server ExecutionHandlers to Netty to avoid doing the business logic with I/O threads (This used to clog up the pipe)
> - Added WrappedAdaptiveReceiveBufferSizePredictorFactory to debug/predict the size of the incoming messages and provide better performance tuning on the server instead of receiving a bunch of small messages.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-340) Added client/server ExecutionHandlers
to Netty to avoid and added
WrappedAdaptiveReceiveBufferSizePredictorFactory to debug/predict the size
of the incoming messages
Posted by "Avery Ching (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Avery Ching updated GIRAPH-340:
-------------------------------
Attachment: GIRAPH-340.3.patch
Here's the new patch that fixes the comment that [~apresta] mentioned. Alessandro, you are right it was for logging.
[~initialcontext], I had no problems adding to trunk. Does this one work for you? Was fine for me.
> Added client/server ExecutionHandlers to Netty to avoid and added WrappedAdaptiveReceiveBufferSizePredictorFactory to debug/predict the size of the incoming messages
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: GIRAPH-340
> URL: https://issues.apache.org/jira/browse/GIRAPH-340
> Project: Giraph
> Issue Type: Sub-task
> Reporter: Avery Ching
> Assignee: Avery Ching
> Attachments: GIRAPH-340.2.patch, GIRAPH-340.3.patch, GIRAPH-340.patch
>
>
> - Added client and server ExecutionHandlers to Netty to avoid doing the business logic with I/O threads (This used to clog up the pipe)
> - Added WrappedAdaptiveReceiveBufferSizePredictorFactory to debug/predict the size of the incoming messages and provide better performance tuning on the server instead of receiving a bunch of small messages.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira