You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/11/22 18:24:16 UTC

[GitHub] [solr] risdenk opened a new pull request, #1185: SOLR-16553 and SOLR-16553

risdenk opened a new pull request, #1185:
URL: https://github.com/apache/solr/pull/1185

   Contains two commits that are related to fixing the benchmark stuff.
   * https://issues.apache.org/jira/browse/SOLR-16553
   * https://issues.apache.org/jira/browse/SOLR-16559


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] risdenk merged pull request #1185: SOLR-16553 and SOLR-16559

Posted by GitBox <gi...@apache.org>.
risdenk merged PR #1185:
URL: https://github.com/apache/solr/pull/1185


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] risdenk commented on a diff in pull request #1185: SOLR-16553 and SOLR-16559

Posted by GitBox <gi...@apache.org>.
risdenk commented on code in PR #1185:
URL: https://github.com/apache/solr/pull/1185#discussion_r1033834782


##########
solr/core/src/java/org/apache/solr/core/NodeConfig.java:
##########
@@ -476,18 +479,22 @@ private void addFoldersToSharedLib(Set<String> libDirs) {
 
   // Adds modules to shared classpath
   private void initModules() {
+    Path solrInstallDir = getSolrInstallDir();
+    if (solrInstallDir == null) {
+      return;

Review Comment:
   @janhoy I pushed a change that gives some more detail in the case of modules and shared lib. Let me know if that looks better for you.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] janhoy commented on a diff in pull request #1185: SOLR-16553 and SOLR-16559

Posted by GitBox <gi...@apache.org>.
janhoy commented on code in PR #1185:
URL: https://github.com/apache/solr/pull/1185#discussion_r1033841038


##########
solr/core/src/java/org/apache/solr/core/NodeConfig.java:
##########
@@ -476,18 +479,22 @@ private void addFoldersToSharedLib(Set<String> libDirs) {
 
   // Adds modules to shared classpath
   private void initModules() {
+    Path solrInstallDir = getSolrInstallDir();
+    if (solrInstallDir == null) {
+      return;

Review Comment:
   This was better, although we'd probably be better off for all tests to also set `solr.install.dir` and treat lack thereof as a configuration error. But now we at least report why things are failing if it is not set. I'm ok with this too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] janhoy commented on a diff in pull request #1185: SOLR-16553 and SOLR-16559

Posted by GitBox <gi...@apache.org>.
janhoy commented on code in PR #1185:
URL: https://github.com/apache/solr/pull/1185#discussion_r1031236174


##########
solr/core/src/java/org/apache/solr/core/NodeConfig.java:
##########
@@ -476,18 +479,22 @@ private void addFoldersToSharedLib(Set<String> libDirs) {
 
   // Adds modules to shared classpath
   private void initModules() {
+    Path solrInstallDir = getSolrInstallDir();
+    if (solrInstallDir == null) {
+      return;

Review Comment:
   I'm not a fan of returning null to handle exceptional cases. Why not catch the exception instead? 
   
   And certainly not a fan of silenlty returning like this. At the very least, it should do a check to see if any modules are requested, and throw exception if they are but we cannot load them due to, in this case, a configuration error.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] risdenk commented on a diff in pull request #1185: SOLR-16553 and SOLR-16559

Posted by GitBox <gi...@apache.org>.
risdenk commented on code in PR #1185:
URL: https://github.com/apache/solr/pull/1185#discussion_r1033716691


##########
solr/core/src/java/org/apache/solr/core/NodeConfig.java:
##########
@@ -476,18 +479,22 @@ private void addFoldersToSharedLib(Set<String> libDirs) {
 
   // Adds modules to shared classpath
   private void initModules() {
+    Path solrInstallDir = getSolrInstallDir();
+    if (solrInstallDir == null) {
+      return;

Review Comment:
   I don't think `getSolrInstallDir()`  should return an exception if the property isn't set. Returning `null` from that method is 100% valid since it is saying "there is no install dir" - `initModules` and `setupSharedLib` should handle the case of no install dir. I agree that there should be a message returned in that case if there is no install dir.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org