You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Rodoni (Code Review)" <ge...@cloudera.org> on 2018/07/25 19:38:15 UTC

[Impala-ASF-CR] IMPALA-7218: [DOCS] Fixed an example

Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11049


Change subject: IMPALA-7218: [DOCS] Fixed an example
......................................................................

IMPALA-7218: [DOCS] Fixed an example

Change-Id: I3c455c0309113d1122e24c73882d85ef282fd62e
---
M docs/topics/impala_alter_view.xml
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/49/11049/1
-- 
To view, visit http://gerrit.cloudera.org:8080/11049
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3c455c0309113d1122e24c73882d85ef282fd62e
Gerrit-Change-Number: 11049
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>

[Impala-ASF-CR] IMPALA-7218: [DOCS] Fixed an example

Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11049 )

Change subject: IMPALA-7218: [DOCS] Fixed an example
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/11049
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c455c0309113d1122e24c73882d85ef282fd62e
Gerrit-Change-Number: 11049
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Comment-Date: Wed, 25 Jul 2018 21:48:22 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7218: [DOCS] Fixed an example

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11049 )

Change subject: IMPALA-7218: [DOCS] Fixed an example
......................................................................


Patch Set 1: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/9/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/11049
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c455c0309113d1122e24c73882d85ef282fd62e
Gerrit-Change-Number: 11049
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Comment-Date: Wed, 25 Jul 2018 19:48:48 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7218: [DOCS] Fixed an example

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11049 )

Change subject: IMPALA-7218: [DOCS] Fixed an example
......................................................................

IMPALA-7218: [DOCS] Fixed an example

Change-Id: I3c455c0309113d1122e24c73882d85ef282fd62e
Reviewed-on: http://gerrit.cloudera.org:8080/11049
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Pooja Nilangekar <po...@cloudera.com>
Reviewed-by: Fredy Wijaya <fw...@cloudera.com>
---
M docs/topics/impala_alter_view.xml
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Impala Public Jenkins: Verified
  Pooja Nilangekar: Looks good to me, but someone else must approve
  Fredy Wijaya: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/11049
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3c455c0309113d1122e24c73882d85ef282fd62e
Gerrit-Change-Number: 11049
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>

[Impala-ASF-CR] IMPALA-7218: [DOCS] Fixed an example

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11049 )

Change subject: IMPALA-7218: [DOCS] Fixed an example
......................................................................


Patch Set 1:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/9/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/11049
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c455c0309113d1122e24c73882d85ef282fd62e
Gerrit-Change-Number: 11049
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 25 Jul 2018 19:38:23 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7218: [DOCS] Fixed an example

Posted by "Pooja Nilangekar (Code Review)" <ge...@cloudera.org>.
Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11049 )

Change subject: IMPALA-7218: [DOCS] Fixed an example
......................................................................


Patch Set 1: Code-Review+1

Looks good to me. 

I can't +2 the patch because I am not a committer. Hence adding Fredy as a reviewer.


-- 
To view, visit http://gerrit.cloudera.org:8080/11049
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c455c0309113d1122e24c73882d85ef282fd62e
Gerrit-Change-Number: 11049
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <po...@cloudera.com>
Gerrit-Comment-Date: Wed, 25 Jul 2018 21:42:43 +0000
Gerrit-HasComments: No