You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/05/18 04:04:08 UTC
[GitHub] [apisix] Firstsawyou opened a new pull request #4264: docs(FAQ): add a note in "How to allow all IPs to access Admin API"
Firstsawyou opened a new pull request #4264:
URL: https://github.com/apache/apisix/pull/4264
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
Signed-off-by: Firstsawyou yuelinz99@gmail.com
Add a warning note in the `How to allow all IPs to access the Admin API` section of the FAQ.
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] starsz commented on a change in pull request #4264: docs(FAQ): add a note in "How to allow all IPs to access Admin API"
Posted by GitBox <gi...@apache.org>.
starsz commented on a change in pull request #4264:
URL: https://github.com/apache/apisix/pull/4264#discussion_r634118365
##########
File path: docs/zh/latest/FAQ.md
##########
@@ -479,3 +479,5 @@ apisix:
```
重启或 reload APISIX，所有 IP 便可以访问 `Admin API`。
+
+**注意：您可以在练习中使用此方法，以允许所有 IP 访问您的 `Apache APISIX` 实例，但是在生产环境中使用它并不安全。在生产中，请仅授权特定的 IP 地址或地址范围访问您的实例。**
Review comment:
`练习中` is not very good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on a change in pull request #4264: docs(FAQ): add a note in "How to allow all IPs to access Admin API"
Posted by GitBox <gi...@apache.org>.
Firstsawyou commented on a change in pull request #4264:
URL: https://github.com/apache/apisix/pull/4264#discussion_r634083313
##########
File path: docs/en/latest/FAQ.md
##########
@@ -480,3 +480,5 @@ apisix:
```
Restart or reload APISIX, all IPs can access the `Admin API`.
+
+>Note: You can use this method in the exercise to allow all IPs to access your `Apache APISIX` instance, but it is not safe to use it in a production environment. In production, please only authorize specific IP addresses or address ranges to access your instance.
Review comment:
Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tokers merged pull request #4264: docs(FAQ): add a note in "How to allow all IPs to access Admin API"
Posted by GitBox <gi...@apache.org>.
tokers merged pull request #4264:
URL: https://github.com/apache/apisix/pull/4264
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4264: docs(FAQ): add a note in "How to allow all IPs to access Admin API"
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #4264:
URL: https://github.com/apache/apisix/pull/4264#discussion_r634077773
##########
File path: docs/en/latest/FAQ.md
##########
@@ -480,3 +480,5 @@ apisix:
```
Restart or reload APISIX, all IPs can access the `Admin API`.
+
+>Note: You can use this method in the exercise to allow all IPs to access your `Apache APISIX` instance, but it is not safe to use it in a production environment. In production, please only authorize specific IP addresses or address ranges to access your instance.
Review comment:
Better to use `**...**` for Note.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tokers commented on a change in pull request #4264: docs(FAQ): add a note in "How to allow all IPs to access Admin API"
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #4264:
URL: https://github.com/apache/apisix/pull/4264#discussion_r634857288
##########
File path: docs/en/latest/FAQ.md
##########
@@ -480,3 +480,5 @@ apisix:
```
Restart or reload APISIX, all IPs can access the `Admin API`.
+
+**Note: You can use this method in a non-production environment to allow all IPs to access your `Apache APISIX` instance, but it is not safe to use it in a production environment. In production, please only authorize specific IP addresses or address ranges to access your instance.**
Review comment:
```suggestion
**Note: You can use this method in a non-production environment to allow all clients from anywhere to access your `Apache APISIX` instances, but it is not safe to use it in a production environment. In production, please only authorize specific IP addresses or address ranges to access your instance.**
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on a change in pull request #4264: docs(FAQ): add a note in "How to allow all IPs to access Admin API"
Posted by GitBox <gi...@apache.org>.
Firstsawyou commented on a change in pull request #4264:
URL: https://github.com/apache/apisix/pull/4264#discussion_r634205539
##########
File path: docs/zh/latest/FAQ.md
##########
@@ -479,3 +479,5 @@ apisix:
```
重启或 reload APISIX，所有 IP 便可以访问 `Admin API`。
+
+**注意：您可以在练习中使用此方法，以允许所有 IP 访问您的 `Apache APISIX` 实例，但是在生产环境中使用它并不安全。在生产中，请仅授权特定的 IP 地址或地址范围访问您的实例。**
Review comment:
Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org