You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2019/03/06 00:55:45 UTC

Review Request 70133: Removed unnecessary accept filters in SLRP tests.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70133/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier and Meng Zhu.


Repository: mesos


Description
-------

Removed unnecessary accept filters in SLRP tests.


Diffs
-----

  src/tests/storage_local_resource_provider_tests.cpp a661951a0a326cc342aa0c45dd0967692ae70941 


Diff: https://reviews.apache.org/r/70133/diff/1/


Testing
-------

`sudo make check`

Especially, tested that each of the three modified tests finishes in 5 seconds.


Thanks,

Chun-Hung Hsiao


Re: Review Request 70133: Removed unnecessary accept filters in SLRP tests.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70133/#review213555
-----------------------------------------------------------



Patch looks great!

Reviews applied: [70132, 70133]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On March 6, 2019, 12:55 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70133/
> -----------------------------------------------------------
> 
> (Updated March 6, 2019, 12:55 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Meng Zhu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed unnecessary accept filters in SLRP tests.
> 
> 
> Diffs
> -----
> 
>   src/tests/storage_local_resource_provider_tests.cpp a661951a0a326cc342aa0c45dd0967692ae70941 
> 
> 
> Diff: https://reviews.apache.org/r/70133/diff/1/
> 
> 
> Testing
> -------
> 
> `sudo make check`
> 
> Especially, tested that each of the three modified tests finishes in 5 seconds.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Re: Review Request 70133: Removed unnecessary accept filters in SLRP tests.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70133/#review213468
-----------------------------------------------------------



Patch looks great!

Reviews applied: [70132, 70133]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On March 6, 2019, 12:55 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70133/
> -----------------------------------------------------------
> 
> (Updated March 6, 2019, 12:55 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Meng Zhu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed unnecessary accept filters in SLRP tests.
> 
> 
> Diffs
> -----
> 
>   src/tests/storage_local_resource_provider_tests.cpp a661951a0a326cc342aa0c45dd0967692ae70941 
> 
> 
> Diff: https://reviews.apache.org/r/70133/diff/1/
> 
> 
> Testing
> -------
> 
> `sudo make check`
> 
> Especially, tested that each of the three modified tests finishes in 5 seconds.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Re: Review Request 70133: Removed unnecessary accept filters in SLRP tests.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70133/#review214507
-----------------------------------------------------------



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['70132', '70133']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3129/mesos-review-70133

Relevant logs:

- [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3129/mesos-review-70133/logs/mesos-tests.log):

```
I0409 23:31:43.826845 38072 master.cpp:1295] Agent de7dad45-a3d2-4321-b837-36e3d2b4c399-S0 at slave(501)@192.10.1.4:59330 (windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net) disconnected
I0409 23:31:43.826845 38072 master.cpp:3333] Disconnecting agent de7dad45-a3d2-4321-b837-36e3d2b4c399-S0 at slave(501)@192.10.1.4:59330 (windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0409 23:31:43.826845 38072 master.cpp:3352] Deactivating agent de7dad45-a3d2-4321-b837-36e3d2b4c399-S0 at slave(501)@192.10.1.4:59330 (windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0409 23:31:43.826845 45524 hierarchical.cpp:392] Removed framework de7dad45-a3d2-4321-b837-36e3d2b4c399-0000
I0409 23:31:43.826845 45524 hierarchical.cpp:829] Agent de7dad45-a3d2-4321-b837-36e3d2b4c399-S0 deactivated
I0409 23:31:43.826845 42016 containerizer.cpp:2576] Destroying co[       OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (736 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (752 ms total)

[----------] Global test environment tear-down
[==========] 1159 tests from 108 test cases ran. (577780 ms total)
[  PASSED  ] 1157 tests.
[  FAILED  ] 2 tests, listed below:
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_FetchImage
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_InvokeFetchByName

 2 FAILED TESTS
  YOU HAVE 233 DISABLED TESTS

ntainer 591b4ffd-32a8-4b1e-8f88-c7426e347a3f in RUNNING state
I0409 23:31:43.826845 42016 containerizer.cpp:3278] Transitioning the state of container 591b4ffd-32a8-4b1e-8f88-c7426e347a3f from RUNNING to DESTROYING
I0409 23:31:43.826845 42016 launcher.cpp:161] Asked to destroy container 591b4ffd-32a8-4b1e-8f88-c7426e347a3f
W0409 23:31:43.826845 38316 process.cpp:1423] Failed to recv on socket WindowsFD::Type::SOCKET=992 to peer '192.10.1.4:61756': IO failed with error code: The specified network name is no longer available.

W0409 23:31:43.826845 38316 process.cpp:838] Failed to recv on socket WindowsFD::Type::SOCKET=2068 to peer '192.10.1.4:61757': IO failed with error code: The specified network name is no longer available.

I0409 23:31:43.920641 45524 containerizer.cpp:3117] Container 591b4ffd-32a8-4b1e-8f88-c7426e347a3f has exited
I0409 23:31:43.936213 44940 master.cpp:1135] Master terminating
I0409 23:31:43.951841 43136 hierarchical.cpp:680] Removed agent de7dad45-a3d2-4321-b837-36e3d2b4c399-S0
I0409 23:31:44.483098 38316 process.cpp:927] Stopped the socket accept loop
```

- Mesos Reviewbot Windows


On April 10, 2019, 5:21 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70133/
> -----------------------------------------------------------
> 
> (Updated April 10, 2019, 5:21 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Meng Zhu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed unnecessary accept filters in SLRP tests.
> 
> 
> Diffs
> -----
> 
>   src/tests/storage_local_resource_provider_tests.cpp bd35150200a23ba57408f5d64a975f8a2f062018 
> 
> 
> Diff: https://reviews.apache.org/r/70133/diff/2/
> 
> 
> Testing
> -------
> 
> `sudo make check`
> 
> Especially, tested that each of the three modified tests finishes in 5 seconds.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Re: Review Request 70133: Removed unnecessary accept filters in SLRP tests.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70133/#review214516
-----------------------------------------------------------



Patch looks great!

Reviews applied: [70132, 70133]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 10, 2019, 5:21 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70133/
> -----------------------------------------------------------
> 
> (Updated April 10, 2019, 5:21 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Meng Zhu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed unnecessary accept filters in SLRP tests.
> 
> 
> Diffs
> -----
> 
>   src/tests/storage_local_resource_provider_tests.cpp bd35150200a23ba57408f5d64a975f8a2f062018 
> 
> 
> Diff: https://reviews.apache.org/r/70133/diff/2/
> 
> 
> Testing
> -------
> 
> `sudo make check`
> 
> Especially, tested that each of the three modified tests finishes in 5 seconds.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Re: Review Request 70133: Removed unnecessary accept filters in SLRP tests.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70133/#review214843
-----------------------------------------------------------



Patch looks great!

Reviews applied: [70132, 70537, 70521, 70133]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 9, 2019, 9:21 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70133/
> -----------------------------------------------------------
> 
> (Updated April 9, 2019, 9:21 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Meng Zhu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed unnecessary accept filters in SLRP tests.
> 
> 
> Diffs
> -----
> 
>   src/tests/storage_local_resource_provider_tests.cpp bd35150200a23ba57408f5d64a975f8a2f062018 
> 
> 
> Diff: https://reviews.apache.org/r/70133/diff/2/
> 
> 
> Testing
> -------
> 
> `sudo make check`
> 
> Especially, tested that each of the three modified tests finishes in 5 seconds.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Re: Review Request 70133: Removed unnecessary accept filters in SLRP tests.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70133/#review214907
-----------------------------------------------------------



Patch looks great!

Reviews applied: [70132, 70547, 70537, 70521, 70133]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 9, 2019, 9:21 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70133/
> -----------------------------------------------------------
> 
> (Updated April 9, 2019, 9:21 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Meng Zhu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed unnecessary accept filters in SLRP tests.
> 
> 
> Diffs
> -----
> 
>   src/tests/storage_local_resource_provider_tests.cpp bd35150200a23ba57408f5d64a975f8a2f062018 
> 
> 
> Diff: https://reviews.apache.org/r/70133/diff/2/
> 
> 
> Testing
> -------
> 
> `sudo make check`
> 
> Especially, tested that each of the three modified tests finishes in 5 seconds.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Re: Review Request 70133: Removed unnecessary accept filters in SLRP tests.

Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70133/
-----------------------------------------------------------

(Updated May 2, 2019, 11:40 p.m.)


Review request for mesos, Benjamin Bannier and Meng Zhu.


Changes
-------

Removed the accept filters in a newly-added test.


Repository: mesos


Description
-------

Removed unnecessary accept filters in SLRP tests.


Diffs (updated)
-----

  src/tests/storage_local_resource_provider_tests.cpp 8bf4d2331b59770a7b7f3768499047bec2d67677 


Diff: https://reviews.apache.org/r/70133/diff/3/

Changes: https://reviews.apache.org/r/70133/diff/2-3/


Testing
-------

`sudo make check`

Especially, tested that each of the three modified tests finishes in 5 seconds.


Thanks,

Chun-Hung Hsiao


Re: Review Request 70133: Removed unnecessary accept filters in SLRP tests.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70133/#review214810
-----------------------------------------------------------



Patch looks great!

Reviews applied: [70132, 70521, 70133]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 9, 2019, 9:21 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70133/
> -----------------------------------------------------------
> 
> (Updated April 9, 2019, 9:21 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Meng Zhu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed unnecessary accept filters in SLRP tests.
> 
> 
> Diffs
> -----
> 
>   src/tests/storage_local_resource_provider_tests.cpp bd35150200a23ba57408f5d64a975f8a2f062018 
> 
> 
> Diff: https://reviews.apache.org/r/70133/diff/2/
> 
> 
> Testing
> -------
> 
> `sudo make check`
> 
> Especially, tested that each of the three modified tests finishes in 5 seconds.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Re: Review Request 70133: Removed unnecessary accept filters in SLRP tests.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70133/#review214881
-----------------------------------------------------------



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['70132', '70537', '70521', '70133']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3261/mesos-review-70133

Relevant logs:

- [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3261/mesos-review-70133/logs/mesos-tests.log):

```
I0425 10:45:10.686038 77624 master.cpp:3312] Disconnecting agent 91daf399-45a6-445b-a2c0-b05903a27297-S0 at slave(514)@192.10.1.4:64503 (windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0425 10:45:10.686038 77624 master.cpp:3331] Deactivating agent 91daf399-45a6-445b-a2c0-b05903a27297-S0 at slave(514)@192.10.1.4:64503 (windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0425 10:45:10.687011 70428 hierarchical.cpp:392] Removed framework 91daf399-45a6-445b-a2c0-b05903a27297-0000
I0425 10:45:10.687011 70428 hierarchical.cpp:829] Agent 91daf399-45a6-445b-a2c0-b05903a27297-S0 deactivated
I0425 10:45:10.688022 77624 containerizer.cpp:2576] Destroying container e3573752-a99c-428b-8879-360227de6051 in RUNNING state
I0425 10:45:10.688022 77624 containerizer.cpp:3278] Transitioning the state of container e3573752-a99c-428b-8879-360227de6051 from RUNNING to DESTROYING
I0425 10:45:10.688022 77624 launcher.cpp:161] Asked to destroy container e3573752-a99c-428b-8879-360227de6051
W0425 10:45:10.690022 79864 process.cpp:1423] Failed to recv on [       OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (794 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (813 ms total)

[----------] Global test environment tear-down
[==========] 1176 tests from 109 test cases ran. (594714 ms total)
[  PASSED  ] 1173 tests.
[  FAILED  ] 3 tests, listed below:
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_FetchManifest
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_FetchImage
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_InvokeFetchByName

 3 FAILED TESTS
  YOU HAVE 233 DISABLED TESTS

socket WindowsFD::Type::SOCKET=2816 to peer '192.10.1.4:50593': IO failed with error code: The specified network name is no longer available.

W0425 10:45:10.690022 79864 process.cpp:838] Failed to recv on socket WindowsFD::Type::SOCKET=120 to peer '192.10.1.4:50594': IO failed with error code: The specified network name is no longer available.

I0425 10:45:10.778272 74552 containerizer.cpp:3117] Container e3573752-a99c-428b-8879-360227de6051 has exited
I0425 10:45:10.812242 78640 master.cpp:1135] Master terminating
I0425 10:45:10.813252 74552 hierarchical.cpp:680] Removed agent 91daf399-45a6-445b-a2c0-b05903a27297-S0
I0425 10:45:11.935622 79864 process.cpp:927] Stopped the socket accept loop
```

- Mesos Reviewbot Windows


On April 10, 2019, 2:51 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70133/
> -----------------------------------------------------------
> 
> (Updated April 10, 2019, 2:51 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Meng Zhu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed unnecessary accept filters in SLRP tests.
> 
> 
> Diffs
> -----
> 
>   src/tests/storage_local_resource_provider_tests.cpp bd35150200a23ba57408f5d64a975f8a2f062018 
> 
> 
> Diff: https://reviews.apache.org/r/70133/diff/2/
> 
> 
> Testing
> -------
> 
> `sudo make check`
> 
> Especially, tested that each of the three modified tests finishes in 5 seconds.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Re: Review Request 70133: Removed unnecessary accept filters in SLRP tests.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70133/#review214813
-----------------------------------------------------------



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['70132', '70521', '70133']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3242/mesos-review-70133

Relevant logs:

- [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3242/mesos-review-70133/logs/mesos-tests.log):

```
I0423 12:26:20.012372 74948 master.cpp:3333] Disconnecting agent 0a068c4b-f399-4887-a3c9-ae3eea705cfc-S0 at slave(501)@192.10.1.4:52137 (windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0423 12:26:20.012372 74948 master.cpp:3352] Deactivating agent 0a068c4b-f399-4887-a3c9-ae3eea705cfc-S0 at slave(501)@192.10.1.4:52137 (windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0423 12:26:20.013376 71464 hierarchical.cpp:392] Removed framework 0a068c4b-f399-4887-a3c9-ae3eea705cfc-0000
I0423 12:26:20.013376 71464 hierarchical.cpp:829] Agent 0a068c4b-f399-4887-a3c9-ae3eea705cfc-S0 deactivated
I0423 12:26:20.014398 72056 containerizer.cpp:2576] Destroying container b00a3bb1-9df7-4322-ab24-ad0ff75733a5 in RUNNING state
I0423 12:26:20.014398 72056 containerizer.cpp:3278] Transitioning the state of container b00a3bb1-9df7-4322-ab24-ad0ff75733a5 from RUNNING to DESTROYING
I0423 12:26:20.014398 72056 launcher.cpp:161] Asked to destroy container b00a3bb1-9df7-4322-ab24-ad0ff75733a5
W0423 12:26:20.015440 73000 process.cpp:1423] Failed to recv on socket WindowsFD::Type::SOCKET=1184 to peer '192.10.1.4:54519': IO failed with error code: The specified network name is no longer available.

W0423 12:26:20.016374 73000 process.cpp:838] Failed to recv on socket WindowsFD::Type::SOCKET=1224 to peer '192.10.1.4:54520': IO failed with e[       OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (794 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (812 ms total)

[----------] Global test environment tear-down
[==========] 1162 tests from 109 test cases ran. (588932 ms total)
[  PASSED  ] 1159 tests.
[  FAILED  ] 3 tests, listed below:
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_FetchManifest
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_FetchImage
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_InvokeFetchByName

 3 FAILED TESTS
  YOU HAVE 233 DISABLED TESTS

rror code: The specified network name is no longer available.

I0423 12:26:20.085477 74172 containerizer.cpp:3117] Container b00a3bb1-9df7-4322-ab24-ad0ff75733a5 has exited
I0423 12:26:20.119426 74172 master.cpp:1135] Master terminating
I0423 12:26:20.120602 74728 hierarchical.cpp:680] Removed agent 0a068c4b-f399-4887-a3c9-ae3eea705cfc-S0
I0423 12:26:21.104396 73000 process.cpp:927] Stopped the socket accept loop
```

- Mesos Reviewbot Windows


On April 9, 2019, 9:21 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70133/
> -----------------------------------------------------------
> 
> (Updated April 9, 2019, 9:21 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Meng Zhu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed unnecessary accept filters in SLRP tests.
> 
> 
> Diffs
> -----
> 
>   src/tests/storage_local_resource_provider_tests.cpp bd35150200a23ba57408f5d64a975f8a2f062018 
> 
> 
> Diff: https://reviews.apache.org/r/70133/diff/2/
> 
> 
> Testing
> -------
> 
> `sudo make check`
> 
> Especially, tested that each of the three modified tests finishes in 5 seconds.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Re: Review Request 70133: Removed unnecessary accept filters in SLRP tests.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70133/#review214933
-----------------------------------------------------------



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['70132', '70547', '70537', '70521', '70133']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3274/mesos-review-70133

Relevant logs:

- [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3274/mesos-review-70133/logs/mesos-tests.log):

```
I0429 00:20:56.513547 79220 master.cpp:3312] Disconnecting agent 2f507c98-6e01-4555-a0ce-f8e708ac03ec-S0 at slave(514)@192.10.1.4:64773 (windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0429 00:20:56.513547 79220 master.cpp:3331] Deactivating agent 2f507c98-6e01-4555-a0ce-f8e708ac03ec-S0 at slave(514)@192.10.1.4:64773 (windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0429 00:20:56.513547 84968 hierarchical.cpp:392] Removed framework 2f507c98-6e01-4555-a0ce-f8e708ac03ec-0000
I0429 00:20:56.514546 84968 hierarchical.cpp:829] Agent 2f507c98-6e01-4555-a0ce-f8e708ac03ec-S0 deactivated
I0429 00:20:56.515547 81284 containerizer.cpp:2576] Destroying container 318d952c-52e8-4588-afed-f2d3fbd35803 in RUNNING state
I0429 00:20:56.515547 81284 containerizer.cpp:3278] Transitioning the state of container 318d952c-52e8-4588-afed-f2d3fbd35803 from RUNNING to DESTROYING
I0429 00:20:56.515547 81284 launcher.cpp:161] Asked to destroy container 318d952c-52e8-4588-afed-f2d3fbd35803
W0429 00:20:56.516544 84616 process.cpp:1423] Failed to recv on socket WindowsFD::Type::SOCKET=3448 to peer '192.10.1.4:50850': IO failed with error code: The specified network name is no longer available.

W0429 00:20:56.516544 84616 process.cpp:838] Failed to recv on socket WindowsFD::Type::SOCKET=2060 to peer '192.10.1.4:50851': IO failed with error code: The specified network name is no longer available.

I0429 00:20:56.528580 81156 containerizer.cpp:3117] Container 318d952c-52e8-4588-afed-f2d3fbd35803 has exited
I0429 00:20:56.557595 81156 master.cpp:1135] Master terminating
I0429 00:20:56.559[       OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (684 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (702 ms total)

[----------] Global test environment tear-down
[==========] 1176 tests from 109 test cases ran. (616375 ms total)
[  PASSED  ] 1173 tests.
[  FAILED  ] 3 tests, listed below:
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_FetchManifest
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_FetchImage
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_InvokeFetchByName

 3 FAILED TESTS
  YOU HAVE 233 DISABLED TESTS

551 81284 hierarchical.cpp:680] Removed agent 2f507c98-6e01-4555-a0ce-f8e708ac03ec-S0
I0429 00:20:57.823596 84616 process.cpp:927] Stopped the socket accept loop
```

- Mesos Reviewbot Windows


On April 9, 2019, 2:21 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70133/
> -----------------------------------------------------------
> 
> (Updated April 9, 2019, 2:21 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Meng Zhu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed unnecessary accept filters in SLRP tests.
> 
> 
> Diffs
> -----
> 
>   src/tests/storage_local_resource_provider_tests.cpp bd35150200a23ba57408f5d64a975f8a2f062018 
> 
> 
> Diff: https://reviews.apache.org/r/70133/diff/2/
> 
> 
> Testing
> -------
> 
> `sudo make check`
> 
> Especially, tested that each of the three modified tests finishes in 5 seconds.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Re: Review Request 70133: Removed unnecessary accept filters in SLRP tests.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70133/#review214992
-----------------------------------------------------------



Patch looks great!

Reviews applied: [70132, 70547, 70537, 70521, 70133]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 9, 2019, 9:21 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70133/
> -----------------------------------------------------------
> 
> (Updated April 9, 2019, 9:21 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Meng Zhu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed unnecessary accept filters in SLRP tests.
> 
> 
> Diffs
> -----
> 
>   src/tests/storage_local_resource_provider_tests.cpp bd35150200a23ba57408f5d64a975f8a2f062018 
> 
> 
> Diff: https://reviews.apache.org/r/70133/diff/2/
> 
> 
> Testing
> -------
> 
> `sudo make check`
> 
> Especially, tested that each of the three modified tests finishes in 5 seconds.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Re: Review Request 70133: Removed unnecessary accept filters in SLRP tests.

Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70133/#review214996
-----------------------------------------------------------


Ship it!




Ship It!

- Benjamin Mahler


On April 9, 2019, 9:21 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70133/
> -----------------------------------------------------------
> 
> (Updated April 9, 2019, 9:21 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Meng Zhu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed unnecessary accept filters in SLRP tests.
> 
> 
> Diffs
> -----
> 
>   src/tests/storage_local_resource_provider_tests.cpp bd35150200a23ba57408f5d64a975f8a2f062018 
> 
> 
> Diff: https://reviews.apache.org/r/70133/diff/2/
> 
> 
> Testing
> -------
> 
> `sudo make check`
> 
> Especially, tested that each of the three modified tests finishes in 5 seconds.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Re: Review Request 70133: Removed unnecessary accept filters in SLRP tests.

Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70133/
-----------------------------------------------------------

(Updated April 9, 2019, 9:21 p.m.)


Review request for mesos, Benjamin Bannier and Meng Zhu.


Changes
-------

Rebased.


Repository: mesos


Description
-------

Removed unnecessary accept filters in SLRP tests.


Diffs (updated)
-----

  src/tests/storage_local_resource_provider_tests.cpp bd35150200a23ba57408f5d64a975f8a2f062018 


Diff: https://reviews.apache.org/r/70133/diff/2/

Changes: https://reviews.apache.org/r/70133/diff/1-2/


Testing
-------

`sudo make check`

Especially, tested that each of the three modified tests finishes in 5 seconds.


Thanks,

Chun-Hung Hsiao


Re: Review Request 70133: Removed unnecessary accept filters in SLRP tests.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70133/#review213688
-----------------------------------------------------------



PASS: Mesos patch 70133 was successfully built and tested.

Reviews applied: `['70132', '70133']`

All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2936/mesos-review-70133

- Mesos Reviewbot Windows


On March 6, 2019, 12:55 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70133/
> -----------------------------------------------------------
> 
> (Updated March 6, 2019, 12:55 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Meng Zhu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed unnecessary accept filters in SLRP tests.
> 
> 
> Diffs
> -----
> 
>   src/tests/storage_local_resource_provider_tests.cpp a661951a0a326cc342aa0c45dd0967692ae70941 
> 
> 
> Diff: https://reviews.apache.org/r/70133/diff/1/
> 
> 
> Testing
> -------
> 
> `sudo make check`
> 
> Especially, tested that each of the three modified tests finishes in 5 seconds.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>