You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by yanghua <gi...@git.apache.org> on 2018/04/18 11:14:30 UTC
[GitHub] flink pull request #5869: [FLINK-8946] TaskManager stop sending metrics afte...
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/5869
[FLINK-8946] TaskManager stop sending metrics after JobManager failover
## What is the purpose of the change
*This pull request fixed taskManager stop sending metrics after JobManager failover*
## Brief change log
- *Initialize `TaskManagerMetricGroup`'s instance when invoking `handleJobManagerLeaderAddress`*
- *Close `TaskManagerMetricGroup` when invoking `handleJobManagerDisconnect`*
## Verifying this change
This change is already covered by existing tests, such as *TaskManagerStartupTest*.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yanghua/flink FLINK-8946
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5869.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5869
----
commit 340a8fc30137bea7b6433263f7ea968849e00cdf
Author: yanghua <ya...@...>
Date: 2018-04-18T11:07:30Z
[FLINK-8946] TaskManager stop sending metrics after JobManager failover
----
---
[GitHub] flink issue #5869: [FLINK-8946] TaskManager stop sending metrics after JobMa...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5869
that should do the trick imo.
---
[GitHub] flink issue #5869: [FLINK-8946] TaskManager stop sending metrics after JobMa...
Posted by yanghua <gi...@git.apache.org>.
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5869
cc @zentol would you like to have a look?
---
[GitHub] flink issue #5869: [FLINK-8946] TaskManager stop sending metrics after JobMa...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5869
that shouldn't be possible, as all tasks are removed when a TM disassociates from the JM which also implies removing all metrics related to a specific task.
---
[GitHub] flink issue #5869: [FLINK-8946] TaskManager stop sending metrics after JobMa...
Posted by yanghua <gi...@git.apache.org>.
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5869
@zentol normally, it seems you are right. But I don't know if there is any exception could cause any remained information, at the jm switching moment.
---
[GitHub] flink issue #5869: [FLINK-8946] TaskManager stop sending metrics after JobMa...
Posted by yanghua <gi...@git.apache.org>.
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5869
cc @tillrohrmann
---
[GitHub] flink pull request #5869: [FLINK-8946] TaskManager stop sending metrics afte...
Posted by yanghua <gi...@git.apache.org>.
Github user yanghua closed the pull request at:
https://github.com/apache/flink/pull/5869
---
[GitHub] flink issue #5869: [FLINK-8946] TaskManager stop sending metrics after JobMa...
Posted by yanghua <gi...@git.apache.org>.
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5869
cc @zentol
---
[GitHub] flink issue #5869: [FLINK-8946] TaskManager stop sending metrics after JobMa...
Posted by yanghua <gi...@git.apache.org>.
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5869
cc @tillrohrmann
---
[GitHub] flink issue #5869: [FLINK-8946] TaskManager stop sending metrics after JobMa...
Posted by yanghua <gi...@git.apache.org>.
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5869
@zentol please see new PR #6060 , closing this PR...
---
[GitHub] flink issue #5869: [FLINK-8946] TaskManager stop sending metrics after JobMa...
Posted by yanghua <gi...@git.apache.org>.
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5869
so I just remove the close method from `disassociateFromJobManager `?
---
[GitHub] flink issue #5869: [FLINK-8946] TaskManager stop sending metrics after JobMa...
Posted by yanghua <gi...@git.apache.org>.
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5869
@zentol if we just remove it from `disassociateFromJobManager ` and do not clear and reinitialize it, when a new job manager reconnect to the task manager , it would remain some tasks' information remain. Because when call `submitTask` method would trigger `taskManagerMetricGroup.addTaskForJob` .
---
[GitHub] flink issue #5869: [FLINK-8946] TaskManager stop sending metrics after JobMa...
Posted by yanghua <gi...@git.apache.org>.
Github user yanghua commented on the issue:
https://github.com/apache/flink/pull/5869
cc @zentol @GJL
---