You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by Andrew Gaul <no...@github.com> on 2013/09/03 07:23:27 UTC

[jclouds] Reduce testFileGetsParallel input size to ~160 KB (#139)

Previously this test downloaded 45 MB in 30 seconds which failed on
slower connections, causing spurious test failures.  The larger input
size provides no benefit.
You can merge this Pull Request by running:

  git pull https://github.com/maginatics/jclouds reduce-test-file-gets-parallel

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds/pull/139

-- Commit Summary --

  * Reduce testFileGetsParallel input size to ~160 KB

-- File Changes --

    M blobstore/src/test/java/org/jclouds/blobstore/integration/internal/BaseBlobIntegrationTest.java (34)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/139.patch
https://github.com/jclouds/jclouds/pull/139.diff


Re: [jclouds] Reduce testFileGetsParallel input size to ~160 KB (#139)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #655](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/655/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/139#issuecomment-23692196

Re: [jclouds] Reduce testFileGetsParallel input size to ~160 KB (#139)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #194](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/194/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/139#issuecomment-23692133

Re: [jclouds] Reduce testFileGetsParallel input size to ~160 KB (#139)

Posted by Andrew Phillips <no...@github.com>.
> @@ -214,12 +216,16 @@ public Void apply(Blob from) {
>  
>     }
>  
> -   private void uploadConstitution(String container, String name, String contentDisposition) throws IOException {
> -      view.getBlobStore().putBlob(
> -               container,
> -               view.getBlobStore().blobBuilder(name).payload(oneHundredOneConstitutions.getInput()).contentType(
> -                        "text/plain").contentMD5(oneHundredOneConstitutionsMD5).contentLength(
> -                        oneHundredOneConstitutionsLength).contentDisposition(contentDisposition).build());
> +   private void uploadInputSupplier(String container, String name, String contentDisposition,

[minor] Confusing name? Are we uploading the input supplier here, or the contents it supplies?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/139/files#r6172766