You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2024/02/09 23:24:16 UTC
[PR] [DRAFT] upgrade paradox plugins [incubator-pekko-http]
pjfanning opened a new pull request, #478:
URL: https://github.com/apache/incubator-pekko-http/pull/478
* might fail due to java 8 build issues
* passed on my laptop - which surprised me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] upgrade paradox plugins [incubator-pekko-http]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #478:
URL: https://github.com/apache/incubator-pekko-http/pull/478
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] [DRAFT] upgrade paradox plugins [incubator-pekko-http]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #478:
URL: https://github.com/apache/incubator-pekko-http/pull/478#issuecomment-1936750375
> * today we are dependent on a non-standard maven repo to get these old versions of plugins
> * this is bad
> * we need to use maven central
> * we need a proper control over our builds to avoid supply chain injection attacks
Yes and the whole point of that ticket is to re-release current sbt-paradox 0.9.2 on maven
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] [DRAFT] upgrade paradox plugins [incubator-pekko-http]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #478:
URL: https://github.com/apache/incubator-pekko-http/pull/478#issuecomment-1938616341
@mdedetrich @raboof https://github.com/apache/incubator-pekko-http/actions/runs/7871851115/job/21475933085?pr=478 just built web site ok with Java 8.
My plugins.sbt changes mean we use only artifacts that are on Maven Central but we still retain Java 8 support.
Is this ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] [DRAFT] upgrade paradox plugins [incubator-pekko-http]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #478:
URL: https://github.com/apache/incubator-pekko-http/pull/478#issuecomment-1938516210
> > the whole point of that ticket is to re-release current sbt-paradox 0.9.2 on maven
>
> @mdedetrich Looking at https://repo1.maven.org/maven2/com/lightbend/paradox/sbt-paradox_2.12_1.0/ I think this is the case also for the 0.9.x line already? Or are you talking about a different library?
Oh so it seems that sbt-paradox 0.9.2 has already been published on maven in which case
> * today we are dependent on a non-standard maven repo to get these old versions of plugins
Is no longer an issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] [DRAFT] upgrade paradox plugins [incubator-pekko-http]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #478:
URL: https://github.com/apache/incubator-pekko-http/pull/478#issuecomment-1936739605
* today we are dependent on a non-standard maven repo to get these old versions of plugins
* this is bad
* we need to use maven central
* we need a proper control over our builds to avoid supply chain injection attacks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] [DRAFT] upgrade paradox plugins [incubator-pekko-http]
Posted by "mkurz (via GitHub)" <gi...@apache.org>.
mkurz commented on PR #478:
URL: https://github.com/apache/incubator-pekko-http/pull/478#issuecomment-1938495335
> the whole point of that ticket is to re-release current sbt-paradox 0.9.2 on maven
@mdedetrich Looking at https://repo1.maven.org/maven2/com/lightbend/paradox/sbt-paradox_2.12_1.0/ I think this is the case also for the 0.9.x line already? Or are you talking about a different library?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] [DRAFT] upgrade paradox plugins [incubator-pekko-http]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #478:
URL: https://github.com/apache/incubator-pekko-http/pull/478#issuecomment-1936736735
> * might fail due to java 8 build issues
> * passed on my laptop - which surprised me
We need to be careful with this. The core issue is not that it would fail to compile but rather it links against the wrong JDK which means the generated api docs would t be correct since the lowest JDK version we support is 8.
I am trying to suggest that sbt-paradox maintains maintenance of its 0.9.x branch which supports JDK 8 with backports of from future paradox versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] [DRAFT] upgrade paradox plugins [incubator-pekko-http]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #478:
URL: https://github.com/apache/incubator-pekko-http/pull/478#issuecomment-1939864599
> This introduces a little risk since it's mixing paradox versions that aren't intended to work together, but since this is only used during the build and tested on CI I think that risk is manageable.
We have been doing this for a while and the API between different versions paradox/paradox-theme is completely stable from 0.9.x onwards.
This is one of the reasons why building the docs with JDK 11 hasn't been such a high priority, the JDK breakage between paradox 0.9.x and 0.10.x+ is not due paradox itself but the scala-xml/parboiled dependency that it brings in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org