You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/09/05 14:23:34 UTC
[GitHub] [doris] freemandealer opened a new pull request, #12360: [Enhancement] improve error msg for delta writer fail (#12121)
freemandealer opened a new pull request, #12360:
URL: https://github.com/apache/doris/pull/12360
Signed-off-by: freemandealer <fr...@gmail.com>
# Proposed changes
Issue Number: close #12121
## Problem summary
fuzzy error msg when delta writer writing failed
Describe your changes.
add error code and err stack for detailed info.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [x] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [x] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [x] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [x] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [x] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] stalary commented on pull request #12360: [Enhancement](log) improve error msg for delta writer fail (#12121)
Posted by GitBox <gi...@apache.org>.
stalary commented on PR #12360:
URL: https://github.com/apache/doris/pull/12360#issuecomment-1237562160
It need be code format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] freemandealer commented on pull request #12360: [Enhancement](log) improve error msg for delta writer fail (#12121)
Posted by GitBox <gi...@apache.org>.
freemandealer commented on PR #12360:
URL: https://github.com/apache/doris/pull/12360#issuecomment-1237589095
> It need be code format.
sure, will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on pull request #12360: [Enhancement](log) improve error msg for delta writer fail (#12121)
Posted by GitBox <gi...@apache.org>.
yiguolei commented on PR #12360:
URL: https://github.com/apache/doris/pull/12360#issuecomment-1240064974
This PR could not be picked because 1.1.2 do not have this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zhannngchen commented on a diff in pull request #12360: [Enhancement](log) improve error msg for delta writer fail (#12121)
Posted by GitBox <gi...@apache.org>.
zhannngchen commented on code in PR #12360:
URL: https://github.com/apache/doris/pull/12360#discussion_r963661600
##########
be/src/runtime/tablets_channel.cpp:
##########
@@ -375,8 +375,10 @@ Status TabletsChannel::add_batch(const TabletWriterAddRequest& request,
Status st = tablet_writer_it->second->write(&send_data, tablet_to_rowidxs_it.second);
if (!st.ok()) {
auto err_msg = strings::Substitute(
- "tablet writer write failed, tablet_id=$0, txn_id=$1, err=$2",
- tablet_to_rowidxs_it.first, _txn_id, st.code());
+ "tablet writer write failed, tablet_id=$0, txn_id=$1, err=$2"
+ ", errcode=$3, msg:$4",
Review Comment:
errcode -> precise_code might be better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #12360: [Enhancement](log) improve error msg for delta writer fail (#12121)
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #12360:
URL: https://github.com/apache/doris/pull/12360
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #12360: [Enhancement](log) improve error msg for delta writer fail (#12121)
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12360:
URL: https://github.com/apache/doris/pull/12360#issuecomment-1238132597
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org