You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Vitalyi Brodetskyi <vb...@hortonworks.com> on 2015/11/02 18:24:51 UTC
Re: Review Request 39687: Allow use passwords references in custom
actions
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39687/
-----------------------------------------------------------
(Updated Лис. 2, 2015, 5:24 після полудня)
Review request for Ambari, Dmitro Lisnichenko, Dmytro Sen, Robert Nettleton, and Sid Wagle.
Bugs: AMBARI-13582
https://issues.apache.org/jira/browse/AMBARI-13582
Repository: ambari
Description
-------
Added ability to use secret references in custom actions; /api/v1/blueprints and /api/v1/clusters/cl?format=blueprint returns masked passwords.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java d834731
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 5f432ef
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 625ebc6
ambari-server/src/main/java/org/apache/ambari/server/controller/ConfigurationResponse.java 3ed9306
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java fa355fa
ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java def33f0
ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java e3ac3e0
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 279b31f
ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java 9e8f163
ambari-server/src/main/java/org/apache/ambari/server/utils/SecretReference.java 2b1aeae
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java c6170e4
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java 369bf02
ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintImplTest.java 2199247
ambari-server/src/test/resources/stacks/HDP/2.0.6/services/YARN/configuration/yarn-site.xml 1c02e86
Diff: https://reviews.apache.org/r/39687/diff/
Testing
-------
mvn clean test
Thanks,
Vitalyi Brodetskyi
Re: Review Request 39687: Allow use passwords references in custom
actions
Posted by Eugene Chekanskiy <ec...@hortonworks.com>.
> On Nov. 2, 2015, 9:43 p.m., Robert Nettleton wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java, line 2937
> > <https://reviews.apache.org/r/39687/diff/3/?file=1114085#file1114085line2937>
> >
> > Why was the "synchronized" keyword removed?
> >
> > It looks like this method was moved into the StackInfo class, but I would imagine that the concurrency requirements would be the same for protecting this data from concurrent access.
Cache moved to StackInfo, Collection.synchronizedMap used instead of synchronized.
- Eugene
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39687/#review104798
-----------------------------------------------------------
On Nov. 2, 2015, 5:24 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39687/
> -----------------------------------------------------------
>
> (Updated Nov. 2, 2015, 5:24 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Dmytro Sen, Robert Nettleton, and Sid Wagle.
>
>
> Bugs: AMBARI-13582
> https://issues.apache.org/jira/browse/AMBARI-13582
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added ability to use secret references in custom actions; /api/v1/blueprints and /api/v1/clusters/cl?format=blueprint returns masked passwords.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java d834731
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 5f432ef
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 625ebc6
> ambari-server/src/main/java/org/apache/ambari/server/controller/ConfigurationResponse.java 3ed9306
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java fa355fa
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java def33f0
> ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java e3ac3e0
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 279b31f
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java 9e8f163
> ambari-server/src/main/java/org/apache/ambari/server/utils/SecretReference.java 2b1aeae
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java c6170e4
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java 369bf02
> ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintImplTest.java 2199247
> ambari-server/src/test/resources/stacks/HDP/2.0.6/services/YARN/configuration/yarn-site.xml 1c02e86
>
> Diff: https://reviews.apache.org/r/39687/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 39687: Allow use passwords references in custom
actions
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39687/#review104798
-----------------------------------------------------------
Ship it!
Overall, the patch looks fine to me, just a few minor issues that should be resolved first.
Thanks for providing the overall context information I requested earlier regarding secret references and how they are used in Ambari.
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java (line 47)
<https://reviews.apache.org/r/39687/#comment163041>
Minor Issue:
In general, we try to use explicit references for imports.
I'd recommend changing this import statement to explicitly list each type imported.
ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java (line 442)
<https://reviews.apache.org/r/39687/#comment163042>
Minor issue:
If this whitespace change isn't required for this patch, I'd recommend removing it.
Thanks.
ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java (line 74)
<https://reviews.apache.org/r/39687/#comment163043>
Minor issue:
I'd recommend making this field private, unless there is a specific reason not to.
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java (line 2935)
<https://reviews.apache.org/r/39687/#comment163044>
Why was the "synchronized" keyword removed?
It looks like this method was moved into the StackInfo class, but I would imagine that the concurrency requirements would be the same for protecting this data from concurrent access.
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java (line 47)
<https://reviews.apache.org/r/39687/#comment163045>
Minor issue:
Please use explicit imports here.
- Robert Nettleton
On Nov. 2, 2015, 5:24 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39687/
> -----------------------------------------------------------
>
> (Updated Nov. 2, 2015, 5:24 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Dmytro Sen, Robert Nettleton, and Sid Wagle.
>
>
> Bugs: AMBARI-13582
> https://issues.apache.org/jira/browse/AMBARI-13582
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added ability to use secret references in custom actions; /api/v1/blueprints and /api/v1/clusters/cl?format=blueprint returns masked passwords.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java d834731
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 5f432ef
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 625ebc6
> ambari-server/src/main/java/org/apache/ambari/server/controller/ConfigurationResponse.java 3ed9306
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java fa355fa
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java def33f0
> ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java e3ac3e0
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 279b31f
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java 9e8f163
> ambari-server/src/main/java/org/apache/ambari/server/utils/SecretReference.java 2b1aeae
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java c6170e4
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java 369bf02
> ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintImplTest.java 2199247
> ambari-server/src/test/resources/stacks/HDP/2.0.6/services/YARN/configuration/yarn-site.xml 1c02e86
>
> Diff: https://reviews.apache.org/r/39687/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 39687: Allow use passwords references in custom
actions
Posted by Robert Nettleton <rn...@hortonworks.com>.
> On Nov. 2, 2015, 5:56 p.m., Robert Nettleton wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java, line 24
> > <https://reviews.apache.org/r/39687/diff/3/?file=1114082#file1114082line24>
> >
> > Can we get some more information on why this change is only applied to the Blueprint resource provider, and not to the cluster's resource provider?
> >
> > It's important to note that the Cluster resource currently returns all passwords in cleartext anyway, so any attempt to mask at the Blueprint level would also need to be accompanied by some changes to at least the ClusterResourceProvider, in order to make sure that passwords in this resource are masked as well.
>
> Eugene Chekanskiy wrote:
> Secret reference is a string like SECRET:configType:configVersion:propertyName.
> Cluster-level replacing was implemented in previous patch, thats why in this patch applied only to blueprint(eg blueprint changes is just a part of patch, where main task was to allow using references in custom actions).
> On every call to API all password properties replaced with references. In blueprints used referecnes with config version -1(because we dont have nay configs yet).
> When user send new configuration with secrete reference server automatically extracts its value and writes it to database.
> Communitation between server and agent unchanged, server send property values from database without any references.
Thanks for clarifying. I'll drop this issue now.
- Robert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39687/#review104742
-----------------------------------------------------------
On Nov. 2, 2015, 5:24 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39687/
> -----------------------------------------------------------
>
> (Updated Nov. 2, 2015, 5:24 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Dmytro Sen, Robert Nettleton, and Sid Wagle.
>
>
> Bugs: AMBARI-13582
> https://issues.apache.org/jira/browse/AMBARI-13582
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added ability to use secret references in custom actions; /api/v1/blueprints and /api/v1/clusters/cl?format=blueprint returns masked passwords.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java d834731
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 5f432ef
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 625ebc6
> ambari-server/src/main/java/org/apache/ambari/server/controller/ConfigurationResponse.java 3ed9306
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java fa355fa
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java def33f0
> ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java e3ac3e0
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 279b31f
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java 9e8f163
> ambari-server/src/main/java/org/apache/ambari/server/utils/SecretReference.java 2b1aeae
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java c6170e4
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java 369bf02
> ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintImplTest.java 2199247
> ambari-server/src/test/resources/stacks/HDP/2.0.6/services/YARN/configuration/yarn-site.xml 1c02e86
>
> Diff: https://reviews.apache.org/r/39687/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 39687: Allow use passwords references in custom
actions
Posted by Eugene Chekanskiy <ec...@hortonworks.com>.
> On Nov. 2, 2015, 5:56 p.m., Robert Nettleton wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java, line 24
> > <https://reviews.apache.org/r/39687/diff/3/?file=1114082#file1114082line24>
> >
> > Can we get some more information on why this change is only applied to the Blueprint resource provider, and not to the cluster's resource provider?
> >
> > It's important to note that the Cluster resource currently returns all passwords in cleartext anyway, so any attempt to mask at the Blueprint level would also need to be accompanied by some changes to at least the ClusterResourceProvider, in order to make sure that passwords in this resource are masked as well.
Secret reference is a string like SECRET:configType:configVersion:propertyName.
Cluster-level replacing was implemented in previous patch, thats why in this patch applied only to blueprint(eg blueprint changes is just a part of patch, where main task was to allow using references in custom actions).
On every call to API all password properties replaced with references. In blueprints used referecnes with config version -1(because we dont have nay configs yet).
When user send new configuration with secrete reference server automatically extracts its value and writes it to database.
Communitation between server and agent unchanged, server send property values from database without any references.
- Eugene
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39687/#review104742
-----------------------------------------------------------
On Nov. 2, 2015, 5:24 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39687/
> -----------------------------------------------------------
>
> (Updated Nov. 2, 2015, 5:24 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Dmytro Sen, Robert Nettleton, and Sid Wagle.
>
>
> Bugs: AMBARI-13582
> https://issues.apache.org/jira/browse/AMBARI-13582
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added ability to use secret references in custom actions; /api/v1/blueprints and /api/v1/clusters/cl?format=blueprint returns masked passwords.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java d834731
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 5f432ef
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 625ebc6
> ambari-server/src/main/java/org/apache/ambari/server/controller/ConfigurationResponse.java 3ed9306
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java fa355fa
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java def33f0
> ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java e3ac3e0
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 279b31f
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java 9e8f163
> ambari-server/src/main/java/org/apache/ambari/server/utils/SecretReference.java 2b1aeae
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java c6170e4
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java 369bf02
> ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintImplTest.java 2199247
> ambari-server/src/test/resources/stacks/HDP/2.0.6/services/YARN/configuration/yarn-site.xml 1c02e86
>
> Diff: https://reviews.apache.org/r/39687/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 39687: Allow use passwords references in custom
actions
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39687/#review104742
-----------------------------------------------------------
I'd request that this patch not be merged yet: -1.
Could the filer please provide a write-up of some kind to explain what "secret references" are exactly? I'll review this change today, but the description for this review and the associated JIRA do not provide much information.
This type of change looks like a cross-cutting concern to me, and might need to be handled more generally than just the Blueprints case.
Thanks.
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java (line 24)
<https://reviews.apache.org/r/39687/#comment162989>
Can we get some more information on why this change is only applied to the Blueprint resource provider, and not to the cluster's resource provider?
It's important to note that the Cluster resource currently returns all passwords in cleartext anyway, so any attempt to mask at the Blueprint level would also need to be accompanied by some changes to at least the ClusterResourceProvider, in order to make sure that passwords in this resource are masked as well.
- Robert Nettleton
On Nov. 2, 2015, 5:24 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39687/
> -----------------------------------------------------------
>
> (Updated Nov. 2, 2015, 5:24 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Dmytro Sen, Robert Nettleton, and Sid Wagle.
>
>
> Bugs: AMBARI-13582
> https://issues.apache.org/jira/browse/AMBARI-13582
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added ability to use secret references in custom actions; /api/v1/blueprints and /api/v1/clusters/cl?format=blueprint returns masked passwords.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java d834731
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 5f432ef
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 625ebc6
> ambari-server/src/main/java/org/apache/ambari/server/controller/ConfigurationResponse.java 3ed9306
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java fa355fa
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java def33f0
> ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java e3ac3e0
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 279b31f
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java 9e8f163
> ambari-server/src/main/java/org/apache/ambari/server/utils/SecretReference.java 2b1aeae
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java c6170e4
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java 369bf02
> ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintImplTest.java 2199247
> ambari-server/src/test/resources/stacks/HDP/2.0.6/services/YARN/configuration/yarn-site.xml 1c02e86
>
> Diff: https://reviews.apache.org/r/39687/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 39687: Allow use passwords references in custom
actions
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39687/
-----------------------------------------------------------
(Updated Лис. 3, 2015, 11:15 до полудня)
Review request for Ambari, Dmitro Lisnichenko, Dmytro Sen, Robert Nettleton, and Sid Wagle.
Bugs: AMBARI-13582
https://issues.apache.org/jira/browse/AMBARI-13582
Repository: ambari
Description
-------
Added ability to use secret references in custom actions; /api/v1/blueprints and /api/v1/clusters/cl?format=blueprint returns masked passwords.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java d834731
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 5f432ef
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 625ebc6
ambari-server/src/main/java/org/apache/ambari/server/controller/ConfigurationResponse.java 3ed9306
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java fa355fa
ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java e3ac3e0
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 279b31f
ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java 9e8f163
ambari-server/src/main/java/org/apache/ambari/server/utils/SecretReference.java 2b1aeae
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java c6170e4
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java 369bf02
ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintImplTest.java 2199247
ambari-server/src/test/resources/stacks/HDP/2.0.6/services/YARN/configuration/yarn-site.xml 1c02e86
Diff: https://reviews.apache.org/r/39687/diff/
Testing
-------
mvn clean test
Thanks,
Vitalyi Brodetskyi
Re: Review Request 39687: Allow use passwords references in custom
actions
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39687/#review104736
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Nov. 2, 2015, 7:24 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39687/
> -----------------------------------------------------------
>
> (Updated Nov. 2, 2015, 7:24 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Dmytro Sen, Robert Nettleton, and Sid Wagle.
>
>
> Bugs: AMBARI-13582
> https://issues.apache.org/jira/browse/AMBARI-13582
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added ability to use secret references in custom actions; /api/v1/blueprints and /api/v1/clusters/cl?format=blueprint returns masked passwords.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java d834731
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 5f432ef
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 625ebc6
> ambari-server/src/main/java/org/apache/ambari/server/controller/ConfigurationResponse.java 3ed9306
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java fa355fa
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java def33f0
> ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java e3ac3e0
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 279b31f
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java 9e8f163
> ambari-server/src/main/java/org/apache/ambari/server/utils/SecretReference.java 2b1aeae
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java c6170e4
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java 369bf02
> ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintImplTest.java 2199247
> ambari-server/src/test/resources/stacks/HDP/2.0.6/services/YARN/configuration/yarn-site.xml 1c02e86
>
> Diff: https://reviews.apache.org/r/39687/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>