You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/03/18 23:08:19 UTC

[kudu-CR](branch-1.9.x) KUDU-2743 [subprocess] use RAW LOG() in child process

Hello Adar Dembo,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/12787

to review the following change.


Change subject: KUDU-2743 [subprocess] use RAW_LOG() in child process
......................................................................

KUDU-2743 [subprocess] use RAW_LOG() in child process

For a newly fork()-ed, but not yet exec()-ed process, only async-signal
safe functions should be called.  At least, glog's LOG() should not be
called since it involves acquiring a lock while flushing the message
into the log sink.  Otherwise, the child process can deadlock on attempt
to write a log message if glog's mutex has been copied from the parent's
address space in a locked state.

Change-Id: Ic9dca4ca8b1a6d72c9fc818ea41109c80ace3e39
Reviewed-on: http://gerrit.cloudera.org:8080/12739
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Alexey Serbin <as...@cloudera.com>
(cherry picked from commit d56930fbcdceff911efc8ec30b5c769901888d3d)
(cherry picked from commit 3270d67669e5cf0038fad655178c8c28082425d4)
---
M src/kudu/util/signal.cc
M src/kudu/util/subprocess-test.cc
M src/kudu/util/subprocess.cc
3 files changed, 78 insertions(+), 20 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/87/12787/1
-- 
To view, visit http://gerrit.cloudera.org:8080/12787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.9.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic9dca4ca8b1a6d72c9fc818ea41109c80ace3e39
Gerrit-Change-Number: 12787
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR](branch-1.9.x) KUDU-2743 [subprocess] use RAW LOG() in child process

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12787 )

Change subject: KUDU-2743 [subprocess] use RAW_LOG() in child process
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/12787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.9.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9dca4ca8b1a6d72c9fc818ea41109c80ace3e39
Gerrit-Change-Number: 12787
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 19 Mar 2019 17:44:16 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.9.x) KUDU-2743 [subprocess] use RAW LOG() in child process

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12787 )

Change subject: KUDU-2743 [subprocess] use RAW_LOG() in child process
......................................................................

KUDU-2743 [subprocess] use RAW_LOG() in child process

For a newly fork()-ed, but not yet exec()-ed process, only async-signal
safe functions should be called.  At least, glog's LOG() should not be
called since it involves acquiring a lock while flushing the message
into the log sink.  Otherwise, the child process can deadlock on attempt
to write a log message if glog's mutex has been copied from the parent's
address space in a locked state.

Change-Id: Ic9dca4ca8b1a6d72c9fc818ea41109c80ace3e39
Reviewed-on: http://gerrit.cloudera.org:8080/12739
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Alexey Serbin <as...@cloudera.com>
(cherry picked from commit d56930fbcdceff911efc8ec30b5c769901888d3d)
(cherry picked from commit 3270d67669e5cf0038fad655178c8c28082425d4)
Reviewed-on: http://gerrit.cloudera.org:8080/12787
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/util/signal.cc
M src/kudu/util/subprocess-test.cc
M src/kudu/util/subprocess.cc
3 files changed, 78 insertions(+), 20 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Andrew Wong: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/12787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.9.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic9dca4ca8b1a6d72c9fc818ea41109c80ace3e39
Gerrit-Change-Number: 12787
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)