You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Harikrishna Patnala <ha...@citrix.com> on 2013/06/25 14:11:19 UTC

Review Request 12078: Fix for CLOUDSTACK-3187: cluster.(cpu/memory).allocated.capacity.disablethreshold in not considering overcommit factor.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12078/
-----------------------------------------------------------

Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.


Bugs: CLOUDSTACK-3187


Repository: cloudstack-git


Description
-------

CLOUDSTACK-3187: cluster.(cpu/memory).allocated.capacity.disablethreshold in not considering overcommit factor. cluster is getting disable based on actual use.

While checking for clusters that crosses disable threshold utilization is calculated based on the actual memory value of cluster. This should consider the overcommit ratio from cluster_details table.


Diffs
-----

  engine/schema/src/com/cloud/capacity/dao/CapacityDaoImpl.java d14ad87 

Diff: https://reviews.apache.org/r/12078/diff/


Testing
-------

Tested locally


Thanks,

Harikrishna Patnala


Re: Review Request 12078: Fix for CLOUDSTACK-3187: cluster.(cpu/memory).allocated.capacity.disablethreshold in not considering overcommit factor.

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12078/#review22400
-----------------------------------------------------------


Commit 1a77cdf94687ba93b00a09774f0c5939e30e555f in branch refs/heads/master-6-17-stable from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=1a77cdf ]

CLOUDSTACK-3187: cluster.(cpu/memory).allocated.capacity.disablethreshold in not considering overcommit factor. cluster is getting disable based on actual use

Signed-off-by: Abhinandan Prateek <ap...@apache.org>


- ASF Subversion and Git Services


On June 25, 2013, 12:11 p.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12078/
> -----------------------------------------------------------
> 
> (Updated June 25, 2013, 12:11 p.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
> 
> 
> Bugs: CLOUDSTACK-3187
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-3187: cluster.(cpu/memory).allocated.capacity.disablethreshold in not considering overcommit factor. cluster is getting disable based on actual use.
> 
> While checking for clusters that crosses disable threshold utilization is calculated based on the actual memory value of cluster. This should consider the overcommit ratio from cluster_details table.
> 
> 
> Diffs
> -----
> 
>   engine/schema/src/com/cloud/capacity/dao/CapacityDaoImpl.java d14ad87 
> 
> Diff: https://reviews.apache.org/r/12078/diff/
> 
> 
> Testing
> -------
> 
> Tested locally
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>


Re: Review Request 12078: Fix for CLOUDSTACK-3187: cluster.(cpu/memory).allocated.capacity.disablethreshold in not considering overcommit factor.

Posted by Abhinandan Prateek <ap...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12078/#review22395
-----------------------------------------------------------

Ship it!


Ship It!

- Abhinandan Prateek


On June 25, 2013, 12:11 p.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12078/
> -----------------------------------------------------------
> 
> (Updated June 25, 2013, 12:11 p.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
> 
> 
> Bugs: CLOUDSTACK-3187
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-3187: cluster.(cpu/memory).allocated.capacity.disablethreshold in not considering overcommit factor. cluster is getting disable based on actual use.
> 
> While checking for clusters that crosses disable threshold utilization is calculated based on the actual memory value of cluster. This should consider the overcommit ratio from cluster_details table.
> 
> 
> Diffs
> -----
> 
>   engine/schema/src/com/cloud/capacity/dao/CapacityDaoImpl.java d14ad87 
> 
> Diff: https://reviews.apache.org/r/12078/diff/
> 
> 
> Testing
> -------
> 
> Tested locally
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>


Re: Review Request 12078: Fix for CLOUDSTACK-3187: cluster.(cpu/memory).allocated.capacity.disablethreshold in not considering overcommit factor.

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12078/#review22396
-----------------------------------------------------------


Commit c0591531d8f29505f2f53c008b6d3fb9d8399b94 in branch refs/heads/master from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c059153 ]

CLOUDSTACK-3187: cluster.(cpu/memory).allocated.capacity.disablethreshold in not considering overcommit factor. cluster is getting disable based on actual use

Signed-off-by: Abhinandan Prateek <ap...@apache.org>


- ASF Subversion and Git Services


On June 25, 2013, 12:11 p.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12078/
> -----------------------------------------------------------
> 
> (Updated June 25, 2013, 12:11 p.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
> 
> 
> Bugs: CLOUDSTACK-3187
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-3187: cluster.(cpu/memory).allocated.capacity.disablethreshold in not considering overcommit factor. cluster is getting disable based on actual use.
> 
> While checking for clusters that crosses disable threshold utilization is calculated based on the actual memory value of cluster. This should consider the overcommit ratio from cluster_details table.
> 
> 
> Diffs
> -----
> 
>   engine/schema/src/com/cloud/capacity/dao/CapacityDaoImpl.java d14ad87 
> 
> Diff: https://reviews.apache.org/r/12078/diff/
> 
> 
> Testing
> -------
> 
> Tested locally
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>