You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/26 13:06:22 UTC
[GitHub] [incubator-nuttx] no1wudi opened a new pull request #5348: Revert user space / kernel space isolation for pthread_exit
no1wudi opened a new pull request #5348:
URL: https://github.com/apache/incubator-nuttx/pull/5348
## Summary
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] no1wudi commented on a change in pull request #5348: Revert user space / kernel space isolation for pthread_exit
Posted by GitBox <gi...@apache.org>.
no1wudi commented on a change in pull request #5348:
URL: https://github.com/apache/incubator-nuttx/pull/5348#discussion_r801728596
##########
File path: boards/arm/samv7/samv71-xult/configs/knsh/defconfig
##########
@@ -82,4 +82,4 @@ CONFIG_SYSTEM_I2CTOOL=y
CONFIG_SYSTEM_NSH=y
CONFIG_SYSTEM_RAMTEST=y
CONFIG_SYS_RESERVED=8
-CONFIG_UART3_SERIAL_CONSOLE=y
+CONFIG_USART1_SERIAL_CONSOLE=y
Review comment:
This file had been rebased on latest master, there are no changes on line 85 now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #5348: Revert user space / kernel space isolation for pthread_exit
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #5348:
URL: https://github.com/apache/incubator-nuttx/pull/5348#issuecomment-1022834380
>User space / kernel space isolation introduced a regression issue with pthread cleanup support while asynchronous >canceling a pthread that the cleanup call backs would not be called.
@no1wudi
Which PR does the regression relate to?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5348: Revert user space / kernel space isolation for pthread_exit
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5348:
URL: https://github.com/apache/incubator-nuttx/pull/5348#discussion_r801718804
##########
File path: boards/arm/samv7/samv71-xult/configs/knsh/defconfig
##########
@@ -82,4 +82,4 @@ CONFIG_SYSTEM_I2CTOOL=y
CONFIG_SYSTEM_NSH=y
CONFIG_SYSTEM_RAMTEST=y
CONFIG_SYS_RESERVED=8
-CONFIG_UART3_SERIAL_CONSOLE=y
+CONFIG_USART1_SERIAL_CONSOLE=y
Review comment:
revert the change too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] no1wudi commented on pull request #5348: Revert user space / kernel space isolation for pthread_exit
Posted by GitBox <gi...@apache.org>.
no1wudi commented on pull request #5348:
URL: https://github.com/apache/incubator-nuttx/pull/5348#issuecomment-1032133068
> what's the relationship with #4627 ?
Tasks's atexit/on_exit callbacks function executed in user space by #4627, it would be closed since the implementation is not good enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] no1wudi edited a comment on pull request #5348: Revert user space / kernel space isolation for pthread_exit
Posted by GitBox <gi...@apache.org>.
no1wudi edited a comment on pull request #5348:
URL: https://github.com/apache/incubator-nuttx/pull/5348#issuecomment-1022883008
@yamt In eb1885a7580251c36599b726147f4eb2a8c5ed2a we moved cleanup callbacks from tcb to tls_info_s，so we must re-implement the logic (another way is revert eb1885a7580251c36599b726147f4eb2a8c5ed2a) in pthread_cancel.c
```
#ifdef CONFIG_PTHREAD_CLEANUP
/* Perform any stack pthread clean-up callbacks.
*
* REVISIT: In this case, the clean-up callback will execute on the
* thread of the caller of pthread cancel, not on the thread of
* the thread-to-be-canceled. This is a problem when deferred
* cancellation is not supported because, for example, the clean-up
* function will be unable to unlock its own mutexes.
*/
pthread_cleanup_popall(tcb);
#endif
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on pull request #5348: Revert user space / kernel space isolation for pthread_exit
Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #5348:
URL: https://github.com/apache/incubator-nuttx/pull/5348#issuecomment-1022858333
why did you put the revert and "pthread: Call cleanup callback while asyncrhonous cancel" commit in a PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5348: Revert user space / kernel space isolation for pthread_exit
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5348:
URL: https://github.com/apache/incubator-nuttx/pull/5348#discussion_r801732055
##########
File path: boards/arm/samv7/samv71-xult/configs/knsh/defconfig
##########
@@ -82,4 +82,4 @@ CONFIG_SYSTEM_I2CTOOL=y
CONFIG_SYSTEM_NSH=y
CONFIG_SYSTEM_RAMTEST=y
CONFIG_SYS_RESERVED=8
-CONFIG_UART3_SERIAL_CONSOLE=y
+CONFIG_USART1_SERIAL_CONSOLE=y
Review comment:
Ok, look like github confuse the patchset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5348: Revert user space / kernel space isolation for pthread_exit
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #5348:
URL: https://github.com/apache/incubator-nuttx/pull/5348#issuecomment-1032767461
LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on pull request #5348: Revert user space / kernel space isolation for pthread_exit
Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #5348:
URL: https://github.com/apache/incubator-nuttx/pull/5348#issuecomment-1043866081
does this ring your bell?
https://github.com/apache/incubator-nuttx/pull/5382#issuecomment-1043864572
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5348: Revert user space / kernel space isolation for pthread_exit
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5348:
URL: https://github.com/apache/incubator-nuttx/pull/5348#discussion_r794991517
##########
File path: boards/sparc/bm3823/xx3823/configs/nsh/defconfig
##########
@@ -62,6 +54,3 @@ CONFIG_TASK_SPAWN_DEFAULT_STACKSIZE=768
CONFIG_UART1_BAUD=9600
CONFIG_UART1_SERIAL_CONSOLE=y
CONFIG_UART2_BAUD=9600
-CONFIG_USERMAIN_STACKSIZE=4096
-CONFIG_USER_ENTRYPOINT="nsh_main"
Review comment:
CONFIG_INIT_ENTRYPOINT="nsh_main" and move to the right location
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] no1wudi commented on pull request #5348: Revert user space / kernel space isolation for pthread_exit
Posted by GitBox <gi...@apache.org>.
no1wudi commented on pull request #5348:
URL: https://github.com/apache/incubator-nuttx/pull/5348#issuecomment-1022883008
@yamt In eb1885a7580251c36599b726147f4eb2a8c5ed2a we moved cleanup callbacks from tcb to tls_info_s，so we must re-implement the logic (another way is to revert eb1885a7580251c36599b726147f4eb2a8c5ed2a)
```
#ifdef CONFIG_PTHREAD_CLEANUP
/* Perform any stack pthread clean-up callbacks.
*
* REVISIT: In this case, the clean-up callback will execute on the
* thread of the caller of pthread cancel, not on the thread of
* the thread-to-be-canceled. This is a problem when deferred
* cancellation is not supported because, for example, the clean-up
* function will be unable to unlock its own mutexes.
*/
pthread_cleanup_popall(tcb);
#endif
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] no1wudi commented on a change in pull request #5348: Revert user space / kernel space isolation for pthread_exit
Posted by GitBox <gi...@apache.org>.
no1wudi commented on a change in pull request #5348:
URL: https://github.com/apache/incubator-nuttx/pull/5348#discussion_r795048895
##########
File path: boards/sparc/bm3823/xx3823/configs/nsh/defconfig
##########
@@ -62,6 +54,3 @@ CONFIG_TASK_SPAWN_DEFAULT_STACKSIZE=768
CONFIG_UART1_BAUD=9600
CONFIG_UART1_SERIAL_CONSOLE=y
CONFIG_UART2_BAUD=9600
-CONFIG_USERMAIN_STACKSIZE=4096
-CONFIG_USER_ENTRYPOINT="nsh_main"
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] no1wudi commented on pull request #5348: Revert user space / kernel space isolation for pthread_exit
Posted by GitBox <gi...@apache.org>.
no1wudi commented on pull request #5348:
URL: https://github.com/apache/incubator-nuttx/pull/5348#issuecomment-1022845008
@masayuki2009 Commit eb1885a7580251c36599b726147f4eb2a8c5ed2a in #3626.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on pull request #5348: Revert user space / kernel space isolation for pthread_exit
Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #5348:
URL: https://github.com/apache/incubator-nuttx/pull/5348#issuecomment-1025371338
what's the relationship with https://github.com/apache/incubator-nuttx/pull/4627 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] no1wudi edited a comment on pull request #5348: Revert user space / kernel space isolation for pthread_exit
Posted by GitBox <gi...@apache.org>.
no1wudi edited a comment on pull request #5348:
URL: https://github.com/apache/incubator-nuttx/pull/5348#issuecomment-1022883008
@yamt In eb1885a7580251c36599b726147f4eb2a8c5ed2a we moved cleanup callbacks from tcb to tls_info_s，so we must re-implement the logic (another way is to revert eb1885a7580251c36599b726147f4eb2a8c5ed2a) in pthread_cancel.c
```
#ifdef CONFIG_PTHREAD_CLEANUP
/* Perform any stack pthread clean-up callbacks.
*
* REVISIT: In this case, the clean-up callback will execute on the
* thread of the caller of pthread cancel, not on the thread of
* the thread-to-be-canceled. This is a problem when deferred
* cancellation is not supported because, for example, the clean-up
* function will be unable to unlock its own mutexes.
*/
pthread_cleanup_popall(tcb);
#endif
```
Refer to
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] no1wudi edited a comment on pull request #5348: Revert user space / kernel space isolation for pthread_exit
Posted by GitBox <gi...@apache.org>.
no1wudi edited a comment on pull request #5348:
URL: https://github.com/apache/incubator-nuttx/pull/5348#issuecomment-1022883008
@yamt In eb1885a7580251c36599b726147f4eb2a8c5ed2a we moved cleanup callbacks from tcb to tls_info_s，so we must re-implement the logic (another way is to revert eb1885a7580251c36599b726147f4eb2a8c5ed2a) in pthread_cancel.c
```
#ifdef CONFIG_PTHREAD_CLEANUP
/* Perform any stack pthread clean-up callbacks.
*
* REVISIT: In this case, the clean-up callback will execute on the
* thread of the caller of pthread cancel, not on the thread of
* the thread-to-be-canceled. This is a problem when deferred
* cancellation is not supported because, for example, the clean-up
* function will be unable to unlock its own mutexes.
*/
pthread_cleanup_popall(tcb);
#endif
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5348: Revert user space / kernel space isolation for pthread_exit
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #5348:
URL: https://github.com/apache/incubator-nuttx/pull/5348
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org