You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/10/08 20:38:04 UTC
[GitHub] [netbeans] jlahoda opened a new pull request, #4756: Fixing error recovery when j.l.MatchException is missing, and patterns are present.
jlahoda opened a new pull request, #4756:
URL: https://github.com/apache/netbeans/pull/4756
When https://github.com/apache/netbeans/pull/4586 was integrated, the `VanillaCompileWorkerTest` started to fail, as error recovery no longer work properly for pattern matching and JDK 19 javac, when running on JDK <19, as `j.l.MatchException` is missing. The `MatchException` is needed by the generated code, and hence javac cannot generate the code if it is missing. This patch proposes to improve the error recovery for patterns when the class is missing - the code using the patterns would be removed, as would be done if the code would be referring to `MatchException` explicitly.
---
**^Add meaningful description above**
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
- are all your own work, and you have the right to contribute them.
- are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).
Please make sure (eg. `git log`) that all commits have a valid name and email address for you in the Author field.
If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien merged pull request #4756: Fixing error recovery when j.l.MatchException is missing, and patterns are present.
Posted by GitBox <gi...@apache.org>.
mbien merged PR #4756:
URL: https://github.com/apache/netbeans/pull/4756
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #4756: Fixing error recovery when j.l.MatchException is missing, and patterns are present.
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #4756:
URL: https://github.com/apache/netbeans/pull/4756#issuecomment-1272509843
thanks for fixing this @jlahoda. All java tests are green, lets merge this soon so that master is stable again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists