You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2018/06/26 03:57:43 UTC
Review Request 67736: Removed ifdef from library path construction.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67736/
-----------------------------------------------------------
Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Gilbert Song, Jie Yu, and Till Toenshoff.
Repository: mesos
Description
-------
We don't need to use ifdefs to construct the platform-specific
Mesos library name, we can use the stout `os::libraries` API
instead.
Diffs
-----
src/slave/slave.cpp 8edd652f7f410dbadaf6c2ca3736349065e4340a
Diff: https://reviews.apache.org/r/67736/diff/1/
Testing
-------
make check (Fedora 27)
Thanks,
James Peach
Re: Review Request 67736: Removed ifdef from library path
construction.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67736/#review205348
-----------------------------------------------------------
Patch looks great!
Reviews applied: [67736]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On June 26, 2018, 3:57 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67736/
> -----------------------------------------------------------
>
> (Updated June 26, 2018, 3:57 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Gilbert Song, Jie Yu, and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We don't need to use ifdefs to construct the platform-specific
> Mesos library name, we can use the stout `os::libraries` API
> instead.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 8edd652f7f410dbadaf6c2ca3736349065e4340a
>
>
> Diff: https://reviews.apache.org/r/67736/diff/1/
>
>
> Testing
> -------
>
> make check (Fedora 27)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 67736: Removed ifdef from library path
construction.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67736/#review205358
-----------------------------------------------------------
Ship it!
Ship It!
- Till Toenshoff
On June 26, 2018, 3:57 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67736/
> -----------------------------------------------------------
>
> (Updated June 26, 2018, 3:57 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Gilbert Song, Jie Yu, and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We don't need to use ifdefs to construct the platform-specific
> Mesos library name, we can use the stout `os::libraries` API
> instead.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 8edd652f7f410dbadaf6c2ca3736349065e4340a
>
>
> Diff: https://reviews.apache.org/r/67736/diff/1/
>
>
> Testing
> -------
>
> make check (Fedora 27)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 67736: Removed ifdef from library path
construction.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67736/#review205345
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On June 25, 2018, 8:57 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67736/
> -----------------------------------------------------------
>
> (Updated June 25, 2018, 8:57 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Gilbert Song, Jie Yu, and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We don't need to use ifdefs to construct the platform-specific
> Mesos library name, we can use the stout `os::libraries` API
> instead.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 8edd652f7f410dbadaf6c2ca3736349065e4340a
>
>
> Diff: https://reviews.apache.org/r/67736/diff/1/
>
>
> Testing
> -------
>
> make check (Fedora 27)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 67736: Removed ifdef from library path
construction.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67736/#review205346
-----------------------------------------------------------
PASS: Mesos patch 67736 was successfully built and tested.
Reviews applied: `['67736']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67736
- Mesos Reviewbot Windows
On June 26, 2018, 3:57 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67736/
> -----------------------------------------------------------
>
> (Updated June 26, 2018, 3:57 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Gilbert Song, Jie Yu, and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We don't need to use ifdefs to construct the platform-specific
> Mesos library name, we can use the stout `os::libraries` API
> instead.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 8edd652f7f410dbadaf6c2ca3736349065e4340a
>
>
> Diff: https://reviews.apache.org/r/67736/diff/1/
>
>
> Testing
> -------
>
> make check (Fedora 27)
>
>
> Thanks,
>
> James Peach
>
>