You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@submarine.apache.org by we...@apache.org on 2020/12/17 02:05:52 UTC

[submarine] branch master updated: SUBMARINE-695. Doesn't allocate GPU resource while creating notebook

This is an automated email from the ASF dual-hosted git repository.

wenchih pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/submarine.git


The following commit(s) were added to refs/heads/master by this push:
     new 853db6c  SUBMARINE-695. Doesn't allocate GPU resource while creating notebook
853db6c is described below

commit 853db6c1c1f55b5a2bc7dacd80a700eeb906cad9
Author: kobe860219 <ko...@gmail.com>
AuthorDate: Sat Dec 12 20:05:14 2020 +0800

    SUBMARINE-695. Doesn't allocate GPU resource while creating notebook
    
    ### What is this PR for?
    Modify resources spec when create new notebook. Fix the problem doesn't allocate GPU resource while creating notebook.
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### Todos
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/SUBMARINE-695
    
    ### How should this be tested?
    https://travis-ci.org/github/kobe860219/submarine/builds/749244070
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update?
    * Is there breaking changes for older versions?
    * Does this needs documentation?
    
    Author: kobe860219 <ko...@gmail.com>
    
    Closes #479 from kobe860219/SUBMARINE-695 and squashes the following commits:
    
    0c566e2 [kobe860219] SUBMARINE-695. Doesn't allocate GPU resource while creating notebook
---
 .../src/app/pages/workbench/notebook/notebook.component.ts              | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/submarine-workbench/workbench-web/src/app/pages/workbench/notebook/notebook.component.ts b/submarine-workbench/workbench-web/src/app/pages/workbench/notebook/notebook.component.ts
index 402a08d..b271c88 100644
--- a/submarine-workbench/workbench-web/src/app/pages/workbench/notebook/notebook.component.ts
+++ b/submarine-workbench/workbench-web/src/app/pages/workbench/notebook/notebook.component.ts
@@ -244,7 +244,7 @@ export class NotebookComponent implements OnInit {
         this.notebookForm.get('unit').value
       }`;
     } else {
-      resourceSpec = `cpu=${this.notebookForm.get('cpus').value},gpu=${this.notebookForm.get('gpus').value},memory=${
+      resourceSpec = `cpu=${this.notebookForm.get('cpus').value},nvidia.com/gpu=${this.notebookForm.get('gpus').value},memory=${
         this.notebookForm.get('memoryNum').value
       }${this.notebookForm.get('unit').value}`;
     }


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org